From: David Hildenbrand <david@redhat.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-fsdevel@vger.kernel.org, corbet@lwn.net, osalvador@suse.de,
shuah@kernel.org, Zhao Gongyi <zhaogongyi@huawei.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
akpm@linux-foundation.org
Subject: Re: [PATCH 3/3] debugfs: fix error when writing negative value to atomic_t debugfs file
Date: Tue, 20 Sep 2022 10:19:23 +0200 [thread overview]
Message-ID: <a127720d-ed49-5d20-4d63-13da8914652d@redhat.com> (raw)
In-Reply-To: <20220919172418.45257-4-akinobu.mita@gmail.com>
On 19.09.22 19:24, Akinobu Mita wrote:
> The simple attribute files do not accept a negative value since the
> commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), so we have to use a 64-bit value to write a
> negative value for a debugfs file created by debugfs_create_atomic_t().
Is that comment stale?
I would ahve thought you simply document that we restore the original
behavior essentially by reverting 005747526d4f ("docs: fault-injection:
fix non-working usage of negative values") and the using
DEFINE_DEBUGFS_ATTRIBUTE_SIGNED accordingly.
>
> This restores the previous behaviour by introducing
> DEFINE_DEBUGFS_ATTRIBUTE_SIGNED for a signed value.
>
> Fixes: 488dac0c9237 ("libfs: fix error cast of negative value in simple_attr_write()")
> Reported-by: Zhao Gongyi <zhaogongyi@huawei.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Apart from that
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-20 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 17:24 [PATCH 0/3] fix error when writing negative value to simple attribute files Akinobu Mita
2022-09-19 17:24 ` [PATCH 1/3] libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value Akinobu Mita
2022-09-20 8:14 ` David Hildenbrand
2022-09-19 17:24 ` [PATCH 2/3] lib/notifier-error-inject: fix error when writing -errno to debugfs file Akinobu Mita
2022-09-20 8:15 ` David Hildenbrand
2022-09-19 17:24 ` [PATCH 3/3] debugfs: fix error when writing negative value to atomic_t " Akinobu Mita
2022-09-20 8:19 ` David Hildenbrand [this message]
2022-09-20 7:47 ` [PATCH 0/3] fix error when writing negative value to simple attribute files Greg Kroah-Hartman
2022-09-22 8:06 ` Zhao Gongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a127720d-ed49-5d20-4d63-13da8914652d@redhat.com \
--to=david@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=weiyongjun1@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.