From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org Cc: linux-kernel@vger.kernel.org, Stefano Stabellini <stefano@aporeto.com>, jgross@suse.com, Eric Van Hensbergen <ericvh@gmail.com>, Ron Minnich <rminnich@sandia.gov>, Latchesar Ionkov <lucho@ionkov.net>, v9fs-developer@lists.sourceforge.net Subject: Re: [PATCH 6/7] xen/9pfs: receive responses Date: Tue, 7 Mar 2017 10:49:59 -0500 [thread overview] Message-ID: <a132af66-cbb8-ee5e-cc5b-c82812007eca@oracle.com> (raw) In-Reply-To: <1488830488-18506-6-git-send-email-sstabellini@kernel.org> On 03/06/2017 03:01 PM, Stefano Stabellini wrote: > Upon receiving a notification from the backend, schedule the > p9_xen_response work_struct. p9_xen_response checks if any responses are > available, if so, it reads them one by one, calling p9_client_cb to send > them up to the 9p layer (p9_client_cb completes the request). Handle the > ring following the Xen 9pfs specification. > > Signed-off-by: Stefano Stabellini <stefano@aporeto.com> > CC: boris.ostrovsky@oracle.com > CC: jgross@suse.com > CC: Eric Van Hensbergen <ericvh@gmail.com> > CC: Ron Minnich <rminnich@sandia.gov> > CC: Latchesar Ionkov <lucho@ionkov.net> > CC: v9fs-developer@lists.sourceforge.net > --- > net/9p/trans_xen.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c > index 4e26556..1ca9246 100644 > --- a/net/9p/trans_xen.c > +++ b/net/9p/trans_xen.c > @@ -149,6 +149,59 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req) > > static void p9_xen_response(struct work_struct *work) > { > + struct xen_9pfs_front_priv *priv; > + struct xen_9pfs_dataring *ring; > + RING_IDX cons, prod, masked_cons, masked_prod; > + struct xen_9pfs_header h; > + struct p9_req_t *req; > + int status = REQ_STATUS_ERROR; Doesn't this need to go inside the loop? > + > + ring = container_of(work, struct xen_9pfs_dataring, work); > + priv = ring->priv; > + > + while (1) { > + cons = ring->intf->in_cons; > + prod = ring->intf->in_prod; > + rmb(); Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the previous patch. > + > + if (xen_9pfs_queued(prod, cons, XEN_9PFS_RING_SIZE) < sizeof(h)) { > + notify_remote_via_irq(ring->irq); > + return; > + } > + > + masked_prod = xen_9pfs_mask(prod, XEN_9PFS_RING_SIZE); > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, &h, sizeof(h)); > + > + req = p9_tag_lookup(priv->client, h.tag); > + if (!req || req->status != REQ_STATUS_SENT) { > + dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); > + cons += h.size; > + mb(); > + ring->intf->in_cons = cons; > + continue; I don't know what xen_9pfs_read_packet() does so perhaps it's done there but shouldn't the pointers be updated regardless of the 'if' condition? -boris > + } > + > + memcpy(req->rc, &h, sizeof(h)); > + req->rc->offset = 0; > + > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, req->rc->sdata, h.size); > + > + mb(); > + cons += h.size; > + ring->intf->in_cons = cons; > + > + if (req->status != REQ_STATUS_ERROR) > + status = REQ_STATUS_RCVD; > + > + p9_client_cb(priv->client, req, status); > + } > } > > static irqreturn_t xen_9pfs_front_event_handler(int irq, void *r) >
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org Cc: jgross@suse.com, Latchesar Ionkov <lucho@ionkov.net>, Eric Van Hensbergen <ericvh@gmail.com>, linux-kernel@vger.kernel.org, Stefano Stabellini <stefano@aporeto.com>, v9fs-developer@lists.sourceforge.net, Ron Minnich <rminnich@sandia.gov> Subject: Re: [PATCH 6/7] xen/9pfs: receive responses Date: Tue, 7 Mar 2017 10:49:59 -0500 [thread overview] Message-ID: <a132af66-cbb8-ee5e-cc5b-c82812007eca@oracle.com> (raw) In-Reply-To: <1488830488-18506-6-git-send-email-sstabellini@kernel.org> On 03/06/2017 03:01 PM, Stefano Stabellini wrote: > Upon receiving a notification from the backend, schedule the > p9_xen_response work_struct. p9_xen_response checks if any responses are > available, if so, it reads them one by one, calling p9_client_cb to send > them up to the 9p layer (p9_client_cb completes the request). Handle the > ring following the Xen 9pfs specification. > > Signed-off-by: Stefano Stabellini <stefano@aporeto.com> > CC: boris.ostrovsky@oracle.com > CC: jgross@suse.com > CC: Eric Van Hensbergen <ericvh@gmail.com> > CC: Ron Minnich <rminnich@sandia.gov> > CC: Latchesar Ionkov <lucho@ionkov.net> > CC: v9fs-developer@lists.sourceforge.net > --- > net/9p/trans_xen.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c > index 4e26556..1ca9246 100644 > --- a/net/9p/trans_xen.c > +++ b/net/9p/trans_xen.c > @@ -149,6 +149,59 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req) > > static void p9_xen_response(struct work_struct *work) > { > + struct xen_9pfs_front_priv *priv; > + struct xen_9pfs_dataring *ring; > + RING_IDX cons, prod, masked_cons, masked_prod; > + struct xen_9pfs_header h; > + struct p9_req_t *req; > + int status = REQ_STATUS_ERROR; Doesn't this need to go inside the loop? > + > + ring = container_of(work, struct xen_9pfs_dataring, work); > + priv = ring->priv; > + > + while (1) { > + cons = ring->intf->in_cons; > + prod = ring->intf->in_prod; > + rmb(); Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the previous patch. > + > + if (xen_9pfs_queued(prod, cons, XEN_9PFS_RING_SIZE) < sizeof(h)) { > + notify_remote_via_irq(ring->irq); > + return; > + } > + > + masked_prod = xen_9pfs_mask(prod, XEN_9PFS_RING_SIZE); > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, &h, sizeof(h)); > + > + req = p9_tag_lookup(priv->client, h.tag); > + if (!req || req->status != REQ_STATUS_SENT) { > + dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); > + cons += h.size; > + mb(); > + ring->intf->in_cons = cons; > + continue; I don't know what xen_9pfs_read_packet() does so perhaps it's done there but shouldn't the pointers be updated regardless of the 'if' condition? -boris > + } > + > + memcpy(req->rc, &h, sizeof(h)); > + req->rc->offset = 0; > + > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, req->rc->sdata, h.size); > + > + mb(); > + cons += h.size; > + ring->intf->in_cons = cons; > + > + if (req->status != REQ_STATUS_ERROR) > + status = REQ_STATUS_RCVD; > + > + p9_client_cb(priv->client, req, status); > + } > } > > static irqreturn_t xen_9pfs_front_event_handler(int irq, void *r) > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-07 15:51 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-06 20:00 [PATCH 0/7] Xen transport for 9pfs frontend driver Stefano Stabellini 2017-03-06 20:01 ` [PATCH 1/7] xen: import new ring macros in ring.h Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 21:22 ` Boris Ostrovsky 2017-03-06 21:22 ` Boris Ostrovsky 2017-03-06 21:36 ` Stefano Stabellini 2017-03-06 21:36 ` Stefano Stabellini 2017-03-06 21:42 ` Boris Ostrovsky 2017-03-06 21:42 ` Boris Ostrovsky 2017-03-06 20:01 ` [PATCH 3/7] xen/9pfs: introduce Xen 9pfs transport driver Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 4/7] xen/9pfs: connect to the backend Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:03 ` Boris Ostrovsky 2017-03-07 15:03 ` Boris Ostrovsky 2017-03-08 0:11 ` Stefano Stabellini 2017-03-08 0:11 ` Stefano Stabellini 2017-03-08 13:47 ` Boris Ostrovsky 2017-03-08 13:47 ` Boris Ostrovsky 2017-03-08 19:22 ` Stefano Stabellini 2017-03-08 19:22 ` Stefano Stabellini 2017-03-07 17:37 ` [Xen-devel] " Julien Grall 2017-03-07 17:37 ` Julien Grall 2017-03-08 0:49 ` [Xen-devel] " Stefano Stabellini 2017-03-08 0:49 ` Stefano Stabellini 2017-03-08 12:25 ` [Xen-devel] " Julien Grall 2017-03-08 12:25 ` Julien Grall 2017-03-08 19:08 ` [Xen-devel] " Stefano Stabellini 2017-03-08 19:08 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 5/7] xen/9pfs: send requests " Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:27 ` Boris Ostrovsky 2017-03-07 15:27 ` Boris Ostrovsky 2017-03-08 0:55 ` Stefano Stabellini 2017-03-08 0:55 ` Stefano Stabellini 2017-03-08 13:58 ` Boris Ostrovsky 2017-03-08 13:58 ` Boris Ostrovsky 2017-03-08 19:33 ` Stefano Stabellini 2017-03-08 19:33 ` Stefano Stabellini 2017-03-08 20:02 ` Boris Ostrovsky 2017-03-08 20:02 ` Boris Ostrovsky 2017-03-08 20:56 ` Stefano Stabellini 2017-03-08 20:56 ` Stefano Stabellini 2017-03-08 21:01 ` Boris Ostrovsky 2017-03-08 21:01 ` Boris Ostrovsky 2017-03-06 20:01 ` [PATCH 6/7] xen/9pfs: receive responses Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 15:49 ` Boris Ostrovsky [this message] 2017-03-07 15:49 ` Boris Ostrovsky 2017-03-08 1:06 ` Stefano Stabellini 2017-03-08 1:06 ` Stefano Stabellini 2017-03-08 1:13 ` Stefano Stabellini 2017-03-08 1:13 ` Stefano Stabellini 2017-03-08 20:11 ` Konrad Rzeszutek Wilk 2017-03-08 20:11 ` [Xen-devel] " Konrad Rzeszutek Wilk 2017-03-08 14:33 ` Boris Ostrovsky 2017-03-08 14:33 ` Boris Ostrovsky 2017-03-08 19:26 ` Stefano Stabellini 2017-03-08 19:26 ` Stefano Stabellini 2017-03-06 20:01 ` [PATCH 7/7] xen/9pfs: build 9pfs Xen transport driver Stefano Stabellini 2017-03-06 20:01 ` Stefano Stabellini 2017-03-07 17:15 ` [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h Julien Grall 2017-03-07 17:15 ` Julien Grall 2017-03-08 0:12 ` [Xen-devel] " Stefano Stabellini 2017-03-08 0:12 ` Stefano Stabellini 2017-03-08 11:14 ` [Xen-devel] " Julien Grall 2017-03-08 11:14 ` Julien Grall 2017-03-07 16:38 ` [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver Roger Pau Monné 2017-03-07 16:38 ` Roger Pau Monné 2017-03-07 18:27 ` [Xen-devel] " Stefano Stabellini 2017-03-07 18:27 ` Stefano Stabellini 2017-03-09 3:02 ` [Xen-devel] " Roger Pau Monné 2017-03-09 3:02 ` Roger Pau Monné 2017-03-13 22:36 ` Stefano Stabellini 2017-03-13 22:36 ` [Xen-devel] " Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a132af66-cbb8-ee5e-cc5b-c82812007eca@oracle.com \ --to=boris.ostrovsky@oracle.com \ --cc=ericvh@gmail.com \ --cc=jgross@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lucho@ionkov.net \ --cc=rminnich@sandia.gov \ --cc=sstabellini@kernel.org \ --cc=stefano@aporeto.com \ --cc=v9fs-developer@lists.sourceforge.net \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.