From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbdCGPvX (ORCPT ); Tue, 7 Mar 2017 10:51:23 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:16389 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbdCGPvO (ORCPT ); Tue, 7 Mar 2017 10:51:14 -0500 Subject: Re: [PATCH 6/7] xen/9pfs: receive responses To: Stefano Stabellini , xen-devel@lists.xenproject.org References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-6-git-send-email-sstabellini@kernel.org> Cc: linux-kernel@vger.kernel.org, Stefano Stabellini , jgross@suse.com, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net From: Boris Ostrovsky Message-ID: Date: Tue, 7 Mar 2017 10:49:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1488830488-18506-6-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2017 03:01 PM, Stefano Stabellini wrote: > Upon receiving a notification from the backend, schedule the > p9_xen_response work_struct. p9_xen_response checks if any responses are > available, if so, it reads them one by one, calling p9_client_cb to send > them up to the 9p layer (p9_client_cb completes the request). Handle the > ring following the Xen 9pfs specification. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrovsky@oracle.com > CC: jgross@suse.com > CC: Eric Van Hensbergen > CC: Ron Minnich > CC: Latchesar Ionkov > CC: v9fs-developer@lists.sourceforge.net > --- > net/9p/trans_xen.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c > index 4e26556..1ca9246 100644 > --- a/net/9p/trans_xen.c > +++ b/net/9p/trans_xen.c > @@ -149,6 +149,59 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req) > > static void p9_xen_response(struct work_struct *work) > { > + struct xen_9pfs_front_priv *priv; > + struct xen_9pfs_dataring *ring; > + RING_IDX cons, prod, masked_cons, masked_prod; > + struct xen_9pfs_header h; > + struct p9_req_t *req; > + int status = REQ_STATUS_ERROR; Doesn't this need to go inside the loop? > + > + ring = container_of(work, struct xen_9pfs_dataring, work); > + priv = ring->priv; > + > + while (1) { > + cons = ring->intf->in_cons; > + prod = ring->intf->in_prod; > + rmb(); Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the previous patch. > + > + if (xen_9pfs_queued(prod, cons, XEN_9PFS_RING_SIZE) < sizeof(h)) { > + notify_remote_via_irq(ring->irq); > + return; > + } > + > + masked_prod = xen_9pfs_mask(prod, XEN_9PFS_RING_SIZE); > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, &h, sizeof(h)); > + > + req = p9_tag_lookup(priv->client, h.tag); > + if (!req || req->status != REQ_STATUS_SENT) { > + dev_warn(&priv->dev->dev, "Wrong req tag=%x\n", h.tag); > + cons += h.size; > + mb(); > + ring->intf->in_cons = cons; > + continue; I don't know what xen_9pfs_read_packet() does so perhaps it's done there but shouldn't the pointers be updated regardless of the 'if' condition? -boris > + } > + > + memcpy(req->rc, &h, sizeof(h)); > + req->rc->offset = 0; > + > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + xen_9pfs_read_packet(ring->ring.in, > + masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, req->rc->sdata, h.size); > + > + mb(); > + cons += h.size; > + ring->intf->in_cons = cons; > + > + if (req->status != REQ_STATUS_ERROR) > + status = REQ_STATUS_RCVD; > + > + p9_client_cb(priv->client, req, status); > + } > } > > static irqreturn_t xen_9pfs_front_event_handler(int irq, void *r) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 6/7] xen/9pfs: receive responses Date: Tue, 7 Mar 2017 10:49:59 -0500 Message-ID: References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-6-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clHMK-0003Wi-8z for xen-devel@lists.xenproject.org; Tue, 07 Mar 2017 15:49:08 +0000 In-Reply-To: <1488830488-18506-6-git-send-email-sstabellini@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Latchesar Ionkov , Eric Van Hensbergen , linux-kernel@vger.kernel.org, Stefano Stabellini , v9fs-developer@lists.sourceforge.net, Ron Minnich List-Id: xen-devel@lists.xenproject.org T24gMDMvMDYvMjAxNyAwMzowMSBQTSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+IFVwb24g cmVjZWl2aW5nIGEgbm90aWZpY2F0aW9uIGZyb20gdGhlIGJhY2tlbmQsIHNjaGVkdWxlIHRoZQo+ IHA5X3hlbl9yZXNwb25zZSB3b3JrX3N0cnVjdC4gcDlfeGVuX3Jlc3BvbnNlIGNoZWNrcyBpZiBh bnkgcmVzcG9uc2VzIGFyZQo+IGF2YWlsYWJsZSwgaWYgc28sIGl0IHJlYWRzIHRoZW0gb25lIGJ5 IG9uZSwgY2FsbGluZyBwOV9jbGllbnRfY2IgdG8gc2VuZAo+IHRoZW0gdXAgdG8gdGhlIDlwIGxh eWVyIChwOV9jbGllbnRfY2IgY29tcGxldGVzIHRoZSByZXF1ZXN0KS4gSGFuZGxlIHRoZQo+IHJp bmcgZm9sbG93aW5nIHRoZSBYZW4gOXBmcyBzcGVjaWZpY2F0aW9uLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFub0BhcG9yZXRvLmNvbT4KPiBDQzogYm9yaXMu b3N0cm92c2t5QG9yYWNsZS5jb20KPiBDQzogamdyb3NzQHN1c2UuY29tCj4gQ0M6IEVyaWMgVmFu IEhlbnNiZXJnZW4gPGVyaWN2aEBnbWFpbC5jb20+Cj4gQ0M6IFJvbiBNaW5uaWNoIDxybWlubmlj aEBzYW5kaWEuZ292Pgo+IENDOiBMYXRjaGVzYXIgSW9ua292IDxsdWNob0Bpb25rb3YubmV0Pgo+ IENDOiB2OWZzLWRldmVsb3BlckBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKPiAtLS0KPiAgbmV0Lzlw L3RyYW5zX3hlbi5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvbmV0LzlwL3RyYW5zX3hlbi5jIGIvbmV0LzlwL3RyYW5zX3hlbi5jCj4gaW5k ZXggNGUyNjU1Ni4uMWNhOTI0NiAxMDA2NDQKPiAtLS0gYS9uZXQvOXAvdHJhbnNfeGVuLmMKPiAr KysgYi9uZXQvOXAvdHJhbnNfeGVuLmMKPiBAQCAtMTQ5LDYgKzE0OSw1OSBAQCBzdGF0aWMgaW50 IHA5X3hlbl9yZXF1ZXN0KHN0cnVjdCBwOV9jbGllbnQgKmNsaWVudCwgc3RydWN0IHA5X3JlcV90 ICpwOV9yZXEpCj4gIAo+ICBzdGF0aWMgdm9pZCBwOV94ZW5fcmVzcG9uc2Uoc3RydWN0IHdvcmtf c3RydWN0ICp3b3JrKQo+ICB7Cj4gKwlzdHJ1Y3QgeGVuXzlwZnNfZnJvbnRfcHJpdiAqcHJpdjsK PiArCXN0cnVjdCB4ZW5fOXBmc19kYXRhcmluZyAqcmluZzsKPiArCVJJTkdfSURYIGNvbnMsIHBy b2QsIG1hc2tlZF9jb25zLCBtYXNrZWRfcHJvZDsKPiArCXN0cnVjdCB4ZW5fOXBmc19oZWFkZXIg aDsKPiArCXN0cnVjdCBwOV9yZXFfdCAqcmVxOwo+ICsJaW50IHN0YXR1cyA9IFJFUV9TVEFUVVNf RVJST1I7CgoKRG9lc24ndCB0aGlzIG5lZWQgdG8gZ28gaW5zaWRlIHRoZSBsb29wPwoKPiArCj4g KwlyaW5nID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCB4ZW5fOXBmc19kYXRhcmluZywgd29y ayk7Cj4gKwlwcml2ID0gcmluZy0+cHJpdjsKPiArCj4gKwl3aGlsZSAoMSkgewo+ICsJCWNvbnMg PSByaW5nLT5pbnRmLT5pbl9jb25zOwo+ICsJCXByb2QgPSByaW5nLT5pbnRmLT5pbl9wcm9kOwo+ ICsJCXJtYigpOwoKCklzIHRoaXMgcm1iKCkgb3IgbWIoKT8gKE9yLCBpbiBmYWN0LCB2aXJ0X1hY WCgpPykgWW91IHVzZWQgbWIoKSBpbiB0aGUKcHJldmlvdXMgcGF0Y2guCgoKPiArCj4gKwkJaWYg KHhlbl85cGZzX3F1ZXVlZChwcm9kLCBjb25zLCBYRU5fOVBGU19SSU5HX1NJWkUpIDwgc2l6ZW9m KGgpKSB7Cj4gKwkJCW5vdGlmeV9yZW1vdGVfdmlhX2lycShyaW5nLT5pcnEpOwo+ICsJCQlyZXR1 cm47Cj4gKwkJfQo+ICsKPiArCQltYXNrZWRfcHJvZCA9IHhlbl85cGZzX21hc2socHJvZCwgWEVO XzlQRlNfUklOR19TSVpFKTsKPiArCQltYXNrZWRfY29ucyA9IHhlbl85cGZzX21hc2soY29ucywg WEVOXzlQRlNfUklOR19TSVpFKTsKPiArCj4gKwkJeGVuXzlwZnNfcmVhZF9wYWNrZXQocmluZy0+ cmluZy5pbiwKPiArCQkJCW1hc2tlZF9wcm9kLCAmbWFza2VkX2NvbnMsCj4gKwkJCQlYRU5fOVBG U19SSU5HX1NJWkUsICZoLCBzaXplb2YoaCkpOwo+ICsKPiArCQlyZXEgPSBwOV90YWdfbG9va3Vw KHByaXYtPmNsaWVudCwgaC50YWcpOwo+ICsJCWlmICghcmVxIHx8IHJlcS0+c3RhdHVzICE9IFJF UV9TVEFUVVNfU0VOVCkgewo+ICsJCQlkZXZfd2FybigmcHJpdi0+ZGV2LT5kZXYsICJXcm9uZyBy ZXEgdGFnPSV4XG4iLCBoLnRhZyk7Cj4gKwkJCWNvbnMgKz0gaC5zaXplOwo+ICsJCQltYigpOwo+ ICsJCQlyaW5nLT5pbnRmLT5pbl9jb25zID0gY29uczsKPiArCQkJY29udGludWU7CgoKSSBkb24n dCBrbm93IHdoYXQgeGVuXzlwZnNfcmVhZF9wYWNrZXQoKSBkb2VzIHNvIHBlcmhhcHMgaXQncyBk b25lIHRoZXJlCmJ1dCBzaG91bGRuJ3QgdGhlIHBvaW50ZXJzIGJlIHVwZGF0ZWQgcmVnYXJkbGVz cyBvZiB0aGUgJ2lmJyBjb25kaXRpb24/CgotYm9yaXMKCgo+ICsJCX0KPiArCj4gKwkJbWVtY3B5 KHJlcS0+cmMsICZoLCBzaXplb2YoaCkpOwo+ICsJCXJlcS0+cmMtPm9mZnNldCA9IDA7Cj4gKwo+ ICsJCW1hc2tlZF9jb25zID0geGVuXzlwZnNfbWFzayhjb25zLCBYRU5fOVBGU19SSU5HX1NJWkUp Owo+ICsJCXhlbl85cGZzX3JlYWRfcGFja2V0KHJpbmctPnJpbmcuaW4sCj4gKwkJCQltYXNrZWRf cHJvZCwgJm1hc2tlZF9jb25zLAo+ICsJCQkJWEVOXzlQRlNfUklOR19TSVpFLCByZXEtPnJjLT5z ZGF0YSwgaC5zaXplKTsKPiArCj4gKwkJbWIoKTsKPiArCQljb25zICs9IGguc2l6ZTsKPiArCQly aW5nLT5pbnRmLT5pbl9jb25zID0gY29uczsKPiArCj4gKwkJaWYgKHJlcS0+c3RhdHVzICE9IFJF UV9TVEFUVVNfRVJST1IpCj4gKwkJCXN0YXR1cyA9IFJFUV9TVEFUVVNfUkNWRDsKPiArCj4gKwkJ cDlfY2xpZW50X2NiKHByaXYtPmNsaWVudCwgcmVxLCBzdGF0dXMpOwo+ICsJfQo+ICB9Cj4gIAo+ ICBzdGF0aWMgaXJxcmV0dXJuX3QgeGVuXzlwZnNfZnJvbnRfZXZlbnRfaGFuZGxlcihpbnQgaXJx LCB2b2lkICpyKQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=