From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joao Pinto Subject: Re: [PATCH 10/37] PCI: dwc: designware: Fix style errors in pcie-designware.c Date: Fri, 13 Jan 2017 16:38:24 +0000 Message-ID: References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-11-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1484216786-17292-11-git-send-email-kishon@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann Cc: linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com List-Id: linux-arm-msm@vger.kernel.org Ās 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Fix all checkpatch warnings and check errors > in pcie-designware.c > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pcie-designware.c | 42 ++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c > index 89cdb6b..ff04074 100644 > --- a/drivers/pci/dwc/pcie-designware.c > +++ b/drivers/pci/dwc/pcie-designware.c > @@ -40,13 +40,13 @@ int dw_pcie_read(void __iomem *addr, int size, u32 *val) > return PCIBIOS_BAD_REGISTER_NUMBER; > } > > - if (size == 4) > + if (size == 4) { > *val = readl(addr); > - else if (size == 2) > + } else if (size == 2) { > *val = readw(addr); > - else if (size == 1) > + } else if (size == 1) { > *val = readb(addr); > - else { > + } else { > *val = 0; > return PCIBIOS_BAD_REGISTER_NUMBER; > } > @@ -203,16 +203,15 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) > > for (i = 0; i < MAX_MSI_CTRLS; i++) { > dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, > - (u32 *)&val); > + (u32 *)&val); > if (val) { > ret = IRQ_HANDLED; > pos = 0; > while ((pos = find_next_bit(&val, 32, pos)) != 32) { > irq = irq_find_mapping(pp->irq_domain, > - i * 32 + pos); > - dw_pcie_wr_own_conf(pp, > - PCIE_MSI_INTR0_STATUS + i * 12, > - 4, 1 << pos); > + i * 32 + pos); > + dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + > + i * 12, 4, 1 << pos); > generic_handle_irq(irq); > pos++; > } > @@ -278,8 +277,9 @@ static void dw_pcie_msi_set_irq(struct pcie_port *pp, int irq) > static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) > { > int irq, pos0, i; > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(desc); > + struct pcie_port *pp; > > + pp = (struct pcie_port *)msi_desc_to_pci_sysdata(desc); > pos0 = bitmap_find_free_region(pp->msi_irq_in_use, MAX_MSI_IRQS, > order_base_2(no_irqs)); > if (pos0 < 0) > @@ -341,7 +341,7 @@ static void dw_msi_setup_msg(struct pcie_port *pp, unsigned int irq, u32 pos) > } > > static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, > - struct msi_desc *desc) > + struct msi_desc *desc) > { > int irq, pos; > struct pcie_port *pp = pdev->bus->sysdata; > @@ -389,7 +389,7 @@ static void dw_msi_teardown_irq(struct msi_controller *chip, unsigned int irq) > { > struct irq_data *data = irq_get_irq_data(irq); > struct msi_desc *msi = irq_data_get_msi_desc(data); > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(msi); > + struct pcie_port *pp = (struct pcie_port *)msi_desc_to_pci_sysdata(msi); > > clear_irq_range(pp, irq, 1, data->hwirq); > } > @@ -431,7 +431,7 @@ int dw_pcie_link_up(struct dw_pcie *pci) > } > > static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > + irq_hw_number_t hwirq) > { > irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > @@ -468,8 +468,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > > cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config"); > if (cfg_res) { > - pp->cfg0_size = resource_size(cfg_res)/2; > - pp->cfg1_size = resource_size(cfg_res)/2; > + pp->cfg0_size = resource_size(cfg_res) / 2; > + pp->cfg1_size = resource_size(cfg_res) / 2; > pp->cfg0_base = cfg_res->start; > pp->cfg1_base = cfg_res->start + pp->cfg0_size; > } else if (!pp->va_cfg0_base) { > @@ -508,8 +508,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > break; > case 0: > pp->cfg = win->res; > - pp->cfg0_size = resource_size(pp->cfg)/2; > - pp->cfg1_size = resource_size(pp->cfg)/2; > + pp->cfg0_size = resource_size(pp->cfg) / 2; > + pp->cfg1_size = resource_size(pp->cfg) / 2; > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > @@ -615,7 +615,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > } > > static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 *val) > + u32 devfn, int where, int size, u32 *val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -654,7 +654,7 @@ static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 val) > + u32 devfn, int where, int size, u32 val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -711,7 +711,7 @@ static int dw_pcie_valid_device(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > - int size, u32 *val) > + int size, u32 *val) > { > struct pcie_port *pp = bus->sysdata; > > @@ -727,7 +727,7 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > } > > static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, > - int where, int size, u32 val) > + int where, int size, u32 val) > { > struct pcie_port *pp = bus->sysdata; > > Always good to make clean up! Thanks! Acked-By: Joao Pinto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdAMQkV (ORCPT ); Fri, 13 Jan 2017 11:40:21 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:50194 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdAMQkS (ORCPT ); Fri, 13 Jan 2017 11:40:18 -0500 Subject: Re: [PATCH 10/37] PCI: dwc: designware: Fix style errors in pcie-designware.c To: Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-11-git-send-email-kishon@ti.com> CC: , , , , , , , , , , From: Joao Pinto Message-ID: Date: Fri, 13 Jan 2017 16:38:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484216786-17292-11-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.116] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ās 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Fix all checkpatch warnings and check errors > in pcie-designware.c > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pcie-designware.c | 42 ++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c > index 89cdb6b..ff04074 100644 > --- a/drivers/pci/dwc/pcie-designware.c > +++ b/drivers/pci/dwc/pcie-designware.c > @@ -40,13 +40,13 @@ int dw_pcie_read(void __iomem *addr, int size, u32 *val) > return PCIBIOS_BAD_REGISTER_NUMBER; > } > > - if (size == 4) > + if (size == 4) { > *val = readl(addr); > - else if (size == 2) > + } else if (size == 2) { > *val = readw(addr); > - else if (size == 1) > + } else if (size == 1) { > *val = readb(addr); > - else { > + } else { > *val = 0; > return PCIBIOS_BAD_REGISTER_NUMBER; > } > @@ -203,16 +203,15 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) > > for (i = 0; i < MAX_MSI_CTRLS; i++) { > dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, > - (u32 *)&val); > + (u32 *)&val); > if (val) { > ret = IRQ_HANDLED; > pos = 0; > while ((pos = find_next_bit(&val, 32, pos)) != 32) { > irq = irq_find_mapping(pp->irq_domain, > - i * 32 + pos); > - dw_pcie_wr_own_conf(pp, > - PCIE_MSI_INTR0_STATUS + i * 12, > - 4, 1 << pos); > + i * 32 + pos); > + dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + > + i * 12, 4, 1 << pos); > generic_handle_irq(irq); > pos++; > } > @@ -278,8 +277,9 @@ static void dw_pcie_msi_set_irq(struct pcie_port *pp, int irq) > static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) > { > int irq, pos0, i; > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(desc); > + struct pcie_port *pp; > > + pp = (struct pcie_port *)msi_desc_to_pci_sysdata(desc); > pos0 = bitmap_find_free_region(pp->msi_irq_in_use, MAX_MSI_IRQS, > order_base_2(no_irqs)); > if (pos0 < 0) > @@ -341,7 +341,7 @@ static void dw_msi_setup_msg(struct pcie_port *pp, unsigned int irq, u32 pos) > } > > static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, > - struct msi_desc *desc) > + struct msi_desc *desc) > { > int irq, pos; > struct pcie_port *pp = pdev->bus->sysdata; > @@ -389,7 +389,7 @@ static void dw_msi_teardown_irq(struct msi_controller *chip, unsigned int irq) > { > struct irq_data *data = irq_get_irq_data(irq); > struct msi_desc *msi = irq_data_get_msi_desc(data); > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(msi); > + struct pcie_port *pp = (struct pcie_port *)msi_desc_to_pci_sysdata(msi); > > clear_irq_range(pp, irq, 1, data->hwirq); > } > @@ -431,7 +431,7 @@ int dw_pcie_link_up(struct dw_pcie *pci) > } > > static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > + irq_hw_number_t hwirq) > { > irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > @@ -468,8 +468,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > > cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config"); > if (cfg_res) { > - pp->cfg0_size = resource_size(cfg_res)/2; > - pp->cfg1_size = resource_size(cfg_res)/2; > + pp->cfg0_size = resource_size(cfg_res) / 2; > + pp->cfg1_size = resource_size(cfg_res) / 2; > pp->cfg0_base = cfg_res->start; > pp->cfg1_base = cfg_res->start + pp->cfg0_size; > } else if (!pp->va_cfg0_base) { > @@ -508,8 +508,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > break; > case 0: > pp->cfg = win->res; > - pp->cfg0_size = resource_size(pp->cfg)/2; > - pp->cfg1_size = resource_size(pp->cfg)/2; > + pp->cfg0_size = resource_size(pp->cfg) / 2; > + pp->cfg1_size = resource_size(pp->cfg) / 2; > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > @@ -615,7 +615,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > } > > static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 *val) > + u32 devfn, int where, int size, u32 *val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -654,7 +654,7 @@ static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 val) > + u32 devfn, int where, int size, u32 val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -711,7 +711,7 @@ static int dw_pcie_valid_device(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > - int size, u32 *val) > + int size, u32 *val) > { > struct pcie_port *pp = bus->sysdata; > > @@ -727,7 +727,7 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > } > > static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, > - int where, int size, u32 val) > + int where, int size, u32 val) > { > struct pcie_port *pp = bus->sysdata; > > Always good to make clean up! Thanks! Acked-By: Joao Pinto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 10/37] PCI: dwc: designware: Fix style errors in pcie-designware.c To: Kishon Vijay Abraham I , Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-11-git-send-email-kishon@ti.com> From: Joao Pinto Message-ID: Date: Fri, 13 Jan 2017 16:38:24 +0000 MIME-Version: 1.0 In-Reply-To: <1484216786-17292-11-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="windows-1252" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: =C0s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Fix all checkpatch warnings and check errors > in pcie-designware.c > = > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pcie-designware.c | 42 ++++++++++++++++++-------------= ------ > 1 file changed, 21 insertions(+), 21 deletions(-) > = > diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-des= ignware.c > index 89cdb6b..ff04074 100644 > --- a/drivers/pci/dwc/pcie-designware.c > +++ b/drivers/pci/dwc/pcie-designware.c > @@ -40,13 +40,13 @@ int dw_pcie_read(void __iomem *addr, int size, u32 *v= al) > return PCIBIOS_BAD_REGISTER_NUMBER; > } > = > - if (size =3D=3D 4) > + if (size =3D=3D 4) { > *val =3D readl(addr); > - else if (size =3D=3D 2) > + } else if (size =3D=3D 2) { > *val =3D readw(addr); > - else if (size =3D=3D 1) > + } else if (size =3D=3D 1) { > *val =3D readb(addr); > - else { > + } else { > *val =3D 0; > return PCIBIOS_BAD_REGISTER_NUMBER; > } > @@ -203,16 +203,15 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) > = > for (i =3D 0; i < MAX_MSI_CTRLS; i++) { > dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, > - (u32 *)&val); > + (u32 *)&val); > if (val) { > ret =3D IRQ_HANDLED; > pos =3D 0; > while ((pos =3D find_next_bit(&val, 32, pos)) !=3D 32) { > irq =3D irq_find_mapping(pp->irq_domain, > - i * 32 + pos); > - dw_pcie_wr_own_conf(pp, > - PCIE_MSI_INTR0_STATUS + i * 12, > - 4, 1 << pos); > + i * 32 + pos); > + dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + > + i * 12, 4, 1 << pos); > generic_handle_irq(irq); > pos++; > } > @@ -278,8 +277,9 @@ static void dw_pcie_msi_set_irq(struct pcie_port *pp,= int irq) > static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) > { > int irq, pos0, i; > - struct pcie_port *pp =3D (struct pcie_port *) msi_desc_to_pci_sysdata(d= esc); > + struct pcie_port *pp; > = > + pp =3D (struct pcie_port *)msi_desc_to_pci_sysdata(desc); > pos0 =3D bitmap_find_free_region(pp->msi_irq_in_use, MAX_MSI_IRQS, > order_base_2(no_irqs)); > if (pos0 < 0) > @@ -341,7 +341,7 @@ static void dw_msi_setup_msg(struct pcie_port *pp, un= signed int irq, u32 pos) > } > = > static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev = *pdev, > - struct msi_desc *desc) > + struct msi_desc *desc) > { > int irq, pos; > struct pcie_port *pp =3D pdev->bus->sysdata; > @@ -389,7 +389,7 @@ static void dw_msi_teardown_irq(struct msi_controller= *chip, unsigned int irq) > { > struct irq_data *data =3D irq_get_irq_data(irq); > struct msi_desc *msi =3D irq_data_get_msi_desc(data); > - struct pcie_port *pp =3D (struct pcie_port *) msi_desc_to_pci_sysdata(m= si); > + struct pcie_port *pp =3D (struct pcie_port *)msi_desc_to_pci_sysdata(ms= i); > = > clear_irq_range(pp, irq, 1, data->hwirq); > } > @@ -431,7 +431,7 @@ int dw_pcie_link_up(struct dw_pcie *pci) > } > = > static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > + irq_hw_number_t hwirq) > { > irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > @@ -468,8 +468,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > = > cfg_res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "config"= ); > if (cfg_res) { > - pp->cfg0_size =3D resource_size(cfg_res)/2; > - pp->cfg1_size =3D resource_size(cfg_res)/2; > + pp->cfg0_size =3D resource_size(cfg_res) / 2; > + pp->cfg1_size =3D resource_size(cfg_res) / 2; > pp->cfg0_base =3D cfg_res->start; > pp->cfg1_base =3D cfg_res->start + pp->cfg0_size; > } else if (!pp->va_cfg0_base) { > @@ -508,8 +508,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > break; > case 0: > pp->cfg =3D win->res; > - pp->cfg0_size =3D resource_size(pp->cfg)/2; > - pp->cfg1_size =3D resource_size(pp->cfg)/2; > + pp->cfg0_size =3D resource_size(pp->cfg) / 2; > + pp->cfg1_size =3D resource_size(pp->cfg) / 2; > pp->cfg0_base =3D pp->cfg->start; > pp->cfg1_base =3D pp->cfg->start + pp->cfg0_size; > break; > @@ -615,7 +615,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > } > = > static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *b= us, > - u32 devfn, int where, int size, u32 *val) > + u32 devfn, int where, int size, u32 *val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -654,7 +654,7 @@ static int dw_pcie_rd_other_conf(struct pcie_port *pp= , struct pci_bus *bus, > } > = > static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *b= us, > - u32 devfn, int where, int size, u32 val) > + u32 devfn, int where, int size, u32 val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -711,7 +711,7 @@ static int dw_pcie_valid_device(struct pcie_port *pp,= struct pci_bus *bus, > } > = > static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > - int size, u32 *val) > + int size, u32 *val) > { > struct pcie_port *pp =3D bus->sysdata; > = > @@ -727,7 +727,7 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 d= evfn, int where, > } > = > static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, > - int where, int size, u32 val) > + int where, int size, u32 val) > { > struct pcie_port *pp =3D bus->sysdata; > = > = Always good to make clean up! Thanks! Acked-By: Joao Pinto _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joao.Pinto@synopsys.com (Joao Pinto) Date: Fri, 13 Jan 2017 16:38:24 +0000 Subject: [PATCH 10/37] PCI: dwc: designware: Fix style errors in pcie-designware.c In-Reply-To: <1484216786-17292-11-git-send-email-kishon@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-11-git-send-email-kishon@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ?s 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Fix all checkpatch warnings and check errors > in pcie-designware.c > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/dwc/pcie-designware.c | 42 ++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-designware.c b/drivers/pci/dwc/pcie-designware.c > index 89cdb6b..ff04074 100644 > --- a/drivers/pci/dwc/pcie-designware.c > +++ b/drivers/pci/dwc/pcie-designware.c > @@ -40,13 +40,13 @@ int dw_pcie_read(void __iomem *addr, int size, u32 *val) > return PCIBIOS_BAD_REGISTER_NUMBER; > } > > - if (size == 4) > + if (size == 4) { > *val = readl(addr); > - else if (size == 2) > + } else if (size == 2) { > *val = readw(addr); > - else if (size == 1) > + } else if (size == 1) { > *val = readb(addr); > - else { > + } else { > *val = 0; > return PCIBIOS_BAD_REGISTER_NUMBER; > } > @@ -203,16 +203,15 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) > > for (i = 0; i < MAX_MSI_CTRLS; i++) { > dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, 4, > - (u32 *)&val); > + (u32 *)&val); > if (val) { > ret = IRQ_HANDLED; > pos = 0; > while ((pos = find_next_bit(&val, 32, pos)) != 32) { > irq = irq_find_mapping(pp->irq_domain, > - i * 32 + pos); > - dw_pcie_wr_own_conf(pp, > - PCIE_MSI_INTR0_STATUS + i * 12, > - 4, 1 << pos); > + i * 32 + pos); > + dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + > + i * 12, 4, 1 << pos); > generic_handle_irq(irq); > pos++; > } > @@ -278,8 +277,9 @@ static void dw_pcie_msi_set_irq(struct pcie_port *pp, int irq) > static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) > { > int irq, pos0, i; > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(desc); > + struct pcie_port *pp; > > + pp = (struct pcie_port *)msi_desc_to_pci_sysdata(desc); > pos0 = bitmap_find_free_region(pp->msi_irq_in_use, MAX_MSI_IRQS, > order_base_2(no_irqs)); > if (pos0 < 0) > @@ -341,7 +341,7 @@ static void dw_msi_setup_msg(struct pcie_port *pp, unsigned int irq, u32 pos) > } > > static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, > - struct msi_desc *desc) > + struct msi_desc *desc) > { > int irq, pos; > struct pcie_port *pp = pdev->bus->sysdata; > @@ -389,7 +389,7 @@ static void dw_msi_teardown_irq(struct msi_controller *chip, unsigned int irq) > { > struct irq_data *data = irq_get_irq_data(irq); > struct msi_desc *msi = irq_data_get_msi_desc(data); > - struct pcie_port *pp = (struct pcie_port *) msi_desc_to_pci_sysdata(msi); > + struct pcie_port *pp = (struct pcie_port *)msi_desc_to_pci_sysdata(msi); > > clear_irq_range(pp, irq, 1, data->hwirq); > } > @@ -431,7 +431,7 @@ int dw_pcie_link_up(struct dw_pcie *pci) > } > > static int dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > + irq_hw_number_t hwirq) > { > irq_set_chip_and_handler(irq, &dw_msi_irq_chip, handle_simple_irq); > irq_set_chip_data(irq, domain->host_data); > @@ -468,8 +468,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > > cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config"); > if (cfg_res) { > - pp->cfg0_size = resource_size(cfg_res)/2; > - pp->cfg1_size = resource_size(cfg_res)/2; > + pp->cfg0_size = resource_size(cfg_res) / 2; > + pp->cfg1_size = resource_size(cfg_res) / 2; > pp->cfg0_base = cfg_res->start; > pp->cfg1_base = cfg_res->start + pp->cfg0_size; > } else if (!pp->va_cfg0_base) { > @@ -508,8 +508,8 @@ int dw_pcie_host_init(struct pcie_port *pp) > break; > case 0: > pp->cfg = win->res; > - pp->cfg0_size = resource_size(pp->cfg)/2; > - pp->cfg1_size = resource_size(pp->cfg)/2; > + pp->cfg0_size = resource_size(pp->cfg) / 2; > + pp->cfg1_size = resource_size(pp->cfg) / 2; > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > @@ -615,7 +615,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > } > > static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 *val) > + u32 devfn, int where, int size, u32 *val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -654,7 +654,7 @@ static int dw_pcie_rd_other_conf(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus, > - u32 devfn, int where, int size, u32 val) > + u32 devfn, int where, int size, u32 val) > { > int ret, type; > u32 busdev, cfg_size; > @@ -711,7 +711,7 @@ static int dw_pcie_valid_device(struct pcie_port *pp, struct pci_bus *bus, > } > > static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > - int size, u32 *val) > + int size, u32 *val) > { > struct pcie_port *pp = bus->sysdata; > > @@ -727,7 +727,7 @@ static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > } > > static int dw_pcie_wr_conf(struct pci_bus *bus, u32 devfn, > - int where, int size, u32 val) > + int where, int size, u32 val) > { > struct pcie_port *pp = bus->sysdata; > > Always good to make clean up! Thanks! Acked-By: Joao Pinto