From: Joe Perches <joe@perches.com>
To: Krzysztof Wilczynski <kw@linux.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c
Date: Wed, 28 Aug 2019 11:02:55 -0700 [thread overview]
Message-ID: <a13a086c2dd6dd6259d28e5d1d360e2b4d04ca83.camel@perches.com> (raw)
In-Reply-To: <20190828175120.22164-1-kw@linux.com>
On Wed, 2019-08-28 at 19:51 +0200, Krzysztof Wilczynski wrote:
> Add missing log facility where two instances of printk() that did not
> use any (so it would be using MESSAGE_LOGLEVEL_DEFAULT set in Kconfig)
> to make all the warnings in the arch/x86/pci/pcbios.c to be printed
> consistently at the same log facility. Also resolve the following
> checkpatch.pl script warning:
>
> WARNING: printk() should include KERN_<LEVEL> facility level
>
> While adding the missing log facility move over to using pr_ macros
> over using printk(KERN_<level> ...) and DBG().
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
> Changes in v2:
> Change wording and include checkpatch.pl script warning.
> Leverage pr_fmt and remove "PCI: " prefix used throught.
> Move to pr_debug() over using DBG() from arch/x86/include/asm/pci_x86.h.
You might also consider the checkpatch output for this patch.
arch/x86/pci/pcbios.c:116: WARNING: line over 80 characters
arch/x86/pci/pcbios.c:116: WARNING: Prefer using '"%s...", __func__' to using 'bios32_service', this function's name, in a string
arch/x86/pci/pcbios.c:119: WARNING: Prefer using '"%s...", __func__' to using 'bios32_service', this function's name, in a string
arch/x86/pci/pcbios.c:391: WARNING: line over 80 characters
next prev parent reply other threads:[~2019-08-28 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 18:25 [PATCH] x86/PCI: Add missing log facility and move to use pr_ macros in pcbios.c Krzysztof Wilczynski
2019-08-27 22:47 ` Bjorn Helgaas
2019-08-28 10:59 ` Krzysztof Wilczynski
2019-08-28 17:51 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 18:02 ` Joe Perches [this message]
2019-08-28 18:40 ` Krzysztof Wilczynski
2019-08-28 18:43 ` Joe Perches
2019-08-28 18:58 ` Krzysztof Wilczynski
2019-08-29 17:11 ` [PATCH v3] x86/PCI: Add missing log facility and move to use pr_ macros Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13a086c2dd6dd6259d28e5d1d360e2b4d04ca83.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.