Re: [Buildroot] [PATCH 07/19] package/x11r7/xdriver_xf86-video-imx-viv: switch dependency from mesa3d to libgl

[Arnout Vandecappelle <arnout@mind.be>]

On 14/05/2022 19:56, Bernd Kuhls wrote:
> DRI support for this driver is provided by the xserver_xorg-server
> package when BR2_PACKAGE_HAS_LIBGL is enabled:
> https://git.busybox.net/buildroot/tree/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk#n91
> 
> Change the dependency to follow the logic of xserver_xorg-server.
> 
> Also fix a typo in the Config.in help text while being at it.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>   package/x11r7/xdriver_xf86-video-imx-viv/Config.in | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/package/x11r7/xdriver_xf86-video-imx-viv/Config.in b/package/x11r7/xdriver_xf86-video-imx-viv/Config.in
> index 13cee14deb..292fdd05a4 100644
> --- a/package/x11r7/xdriver_xf86-video-imx-viv/Config.in
> +++ b/package/x11r7/xdriver_xf86-video-imx-viv/Config.in
> @@ -1,10 +1,9 @@
>   config BR2_PACKAGE_XDRIVER_XF86_VIDEO_IMX_VIV
>   	bool "xf86-video-imx-viv"
> +	depends on BR2_PACKAGE_HAS_LIBGL
>   	depends on BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
>   	depends on BR2_PACKAGE_IMX_GPU_G2D
>   	depends on BR2_TOOLCHAIN_HAS_SYNC_1 # mesa3d
> -	select BR2_PACKAGE_MESA3D # Needed in order to compile xorg with glx/dri
> -	select BR2_PACKAGE_MESA3D_DRI_DRIVER
>   	select BR2_PACKAGE_LIBDRM
>   	select BR2_PACKAGE_XORGPROTO
>   	help
> @@ -26,7 +25,10 @@ config BR2_PACKAGE_XDRIVER_XF86_VIDEO_IMX_VIV
>   
>   	  Don't forget to load galcore.ko and create /dev/galcore
>   	  before using this driver (else, Xorg will exit with an
> -	  obscur message like "Segmentation fault at address 0xc").
> +	  obscure message like "Segmentation fault at address 0xc").
> +
> +comment "xf86-video-imx-viv needs an OpenGL backend"
> +	depends on !BR2_PACKAGE_HAS_LIBGL

  This should also retain the arch dependencies: BR2_arch and 
BR2_TOOLCHAIN_HAS_SYNC_1.

  Regards,
  Arnout

>   
>   comment "xf86-video-imx-viv depends on imx-gpu-viv with X11 output"
>   	depends on BR2_arm
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot