Re: [PATCH net-next v4 5/8] net: fou: regenerate the uAPI from the spec

From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<edumazet@google.com>, <pabeni@redhat.com>, <robh@kernel.org>,
	<johannes@sipsolutions.net>, <stephen@networkplumber.org>,
	<ecree.xilinx@gmail.com>, <sdf@google.com>,
	<f.fainelli@gmail.com>, <fw@strlen.de>,
	<linux-doc@vger.kernel.org>, <razor@blackwall.org>,
	<nicolas.dichtel@6wind.com>
Subject: Re: [PATCH net-next v4 5/8] net: fou: regenerate the uAPI from the spec
Date: Tue, 24 Jan 2023 18:49:48 +0100	[thread overview]
Message-ID: <a16382e3-b66f-0a57-2482-72afd00cdabe@intel.com> (raw)
In-Reply-To: <20230120175041.342573-6-kuba@kernel.org>

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 20 Jan 2023 09:50:38 -0800

> Regenerate the FOU uAPI header from the YAML spec.
> 
> The flags now come before attributes which use them,
> and the comments for type disappear (coders should look
> at the spec instead).

Sorry I missed the whole history of this topic. Wanted to ask: if we can
generate these headers and even C files, why ship the generated with the
source code and not generate them during building? Or it's slow and/or
requires some software etc.?

> 
> Acked-by: Stanislav Fomichev <sdf@google.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  include/uapi/linux/fou.h | 54 +++++++++++++++++++---------------------
>  1 file changed, 26 insertions(+), 28 deletions(-)

[...]

> -#define FOU_CMD_MAX	(__FOU_CMD_MAX - 1)
> +#define FOU_CMD_MAX (__FOU_CMD_MAX - 1)
>  
>  #endif /* _UAPI_LINUX_FOU_H */

Thanks,
Olek