From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDE3C76188 for ; Tue, 16 Jul 2019 10:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B3E720880 for ; Tue, 16 Jul 2019 10:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732499AbfGPKC2 (ORCPT ); Tue, 16 Jul 2019 06:02:28 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:44684 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727849AbfGPKC2 (ORCPT ); Tue, 16 Jul 2019 06:02:28 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C042B4E321EA8CF8BCE8; Tue, 16 Jul 2019 18:02:26 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 18:02:23 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to do sanity with enabled features in image From: Chao Yu To: Jaegeuk Kim , Chao Yu CC: , References: <20190424094850.118323-1-yuchao0@huawei.com> <20190428133802.GB37346@jaegeuk-macbookpro.roam.corp.google.com> <373f4633-d331-5cf3-74b7-e982072bc4b4@kernel.org> <20190501032242.GA84420@jaegeuk-macbookpro.roam.corp.google.com> <3f170d86-e556-13ae-ce19-3bba3944f5fa@huawei.com> <192bae92-2193-570f-7b50-00334271bd2e@huawei.com> Message-ID: Date: Tue, 16 Jul 2019 18:02:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <192bae92-2193-570f-7b50-00334271bd2e@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2019/5/9 9:15, Chao Yu wrote: > On 2019/5/5 10:51, Chao Yu wrote: >> On 2019/5/1 11:22, Jaegeuk Kim wrote: >>> On 04/29, Chao Yu wrote: >>>> On 2019-4-28 21:38, Jaegeuk Kim wrote: >>>>> On 04/24, Chao Yu wrote: >>>>>> This patch fixes to do sanity with enabled features in image, if >>>>>> there are features kernel can not recognize, just fail the mount. >>>>> >>>>> We need to figure out per-feature-based rejection, since some of them can >>>>> be set without layout change. What about adding one field in superblock for compatible features in future? sb.feature(F2FS_FEATURE_LAST, max] stores uncompatible features sb.compatible_feature stores compatible features If we follow above rule when adding one feature, then, we can fail the mount if sb.feature(F2FS_FEATURE_LAST, max] is valid. Thanks, >>>> >>>> So any suggestion on how to implement this? >>> >>> Which features do we need to disallow? When we introduce new features, they >> >> I guess it should be the new features. >> >>> didn't hurt the previous flow by checking f2fs_sb_has_###(). >> >> Yes, but new features may use new disk layout, if old kernel handled it with old >> disk layout, there must be problematic. >> >> e.g. format image with -O extra_attr, and mount it with kernel who don't >> recognize new inode layout. > > Jaegeuk, > > Any thoughts? > > Thanks, > >> >> Thanks, >> >>> >>>> >>>> Maybe: >>>> >>>> if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)) >>>> check 4.14+ features >>>> else if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 9, 0)) >>>> check 4.9+ features >>>> else if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 4, 0)) >>>> check 4.4+ features >>>> >>>> Thanks, >>>> >>>>> >>>>>> >>>>>> Signed-off-by: Chao Yu >>>>>> --- >>>>>> fs/f2fs/f2fs.h | 13 +++++++++++++ >>>>>> fs/f2fs/super.c | 9 +++++++++ >>>>>> 2 files changed, 22 insertions(+) >>>>>> >>>>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>>>>> index f5ffc09705eb..15b640967e12 100644 >>>>>> --- a/fs/f2fs/f2fs.h >>>>>> +++ b/fs/f2fs/f2fs.h >>>>>> @@ -151,6 +151,19 @@ struct f2fs_mount_info { >>>>>> #define F2FS_FEATURE_VERITY 0x0400 /* reserved */ >>>>>> #define F2FS_FEATURE_SB_CHKSUM 0x0800 >>>>>> >>>>>> +#define F2FS_ALL_FEATURES (F2FS_FEATURE_ENCRYPT | \ >>>>>> + F2FS_FEATURE_BLKZONED | \ >>>>>> + F2FS_FEATURE_ATOMIC_WRITE | \ >>>>>> + F2FS_FEATURE_EXTRA_ATTR | \ >>>>>> + F2FS_FEATURE_PRJQUOTA | \ >>>>>> + F2FS_FEATURE_INODE_CHKSUM | \ >>>>>> + F2FS_FEATURE_FLEXIBLE_INLINE_XATTR | \ >>>>>> + F2FS_FEATURE_QUOTA_INO | \ >>>>>> + F2FS_FEATURE_INODE_CRTIME | \ >>>>>> + F2FS_FEATURE_LOST_FOUND | \ >>>>>> + F2FS_FEATURE_VERITY | \ >>>>>> + F2FS_FEATURE_SB_CHKSUM) >>>>>> + >>>>>> #define __F2FS_HAS_FEATURE(raw_super, mask) \ >>>>>> ((raw_super->feature & cpu_to_le32(mask)) != 0) >>>>>> #define F2FS_HAS_FEATURE(sbi, mask) __F2FS_HAS_FEATURE(sbi->raw_super, mask) >>>>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>>>>> index 4f8e9ab48b26..57f2fc6d14ba 100644 >>>>>> --- a/fs/f2fs/super.c >>>>>> +++ b/fs/f2fs/super.c >>>>>> @@ -2573,6 +2573,15 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi, >>>>>> return 1; >>>>>> } >>>>>> >>>>>> + /* check whether kernel supports all features */ >>>>>> + if (le32_to_cpu(raw_super->feature) & (~F2FS_ALL_FEATURES)) { >>>>>> + f2fs_msg(sb, KERN_INFO, >>>>>> + "Unsupported feature:%u: supported:%u", >>>>>> + le32_to_cpu(raw_super->feature), >>>>>> + F2FS_ALL_FEATURES); >>>>>> + return 1; >>>>>> + } >>>>>> + >>>>>> /* check CP/SIT/NAT/SSA/MAIN_AREA area boundary */ >>>>>> if (sanity_check_area_boundary(sbi, bh)) >>>>>> return 1; >>>>>> -- >>>>>> 2.18.0.rc1 >>> . >>> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >> . >> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D74C76188 for ; Tue, 16 Jul 2019 10:02:39 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 228B020665 for ; Tue, 16 Jul 2019 10:02:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="lS8njZ60"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="T9eopnge" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 228B020665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hnKIA-000122-NB; Tue, 16 Jul 2019 10:02:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hnKI8-00011U-VV for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Jul 2019 10:02:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:CC:To:From:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BSUY5qRxni8VHmSKhxtavKVobNaqXM0nNcFnMM0ZEGc=; b=lS8njZ60QeNxYQhL4daK1A0hll UxsmKayFMnZbW5I1o1phYbmnTieSdlZixqpkG28I9ApNjtB1/Dyd95b5/uCsCYBEu4Kz2+E9Eo9nD ZL47aWDq2ygPQocHaCOftsdqMxuAhlsC3wyusxKb3hRQ5W6K3+CKftZ9Ul4j5d5WrJ9c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:References:CC:To:From:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BSUY5qRxni8VHmSKhxtavKVobNaqXM0nNcFnMM0ZEGc=; b=T9eopngepXQE/Yxr0pzmgxM5i8 xz+36eWfe1yBHi7YmznNsqkphV3aZHoPjAHptT8BcJhVMAv/AY3uygIkNgMQYVXFp9pezX9WTMsAz +9lGdZClw8xxTVYgcbWunsgMO1lD3SPQ+vqWQtke65oZG07sMHj+VMKlTxdaXS+f4ef8=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hnKI6-002we0-RF for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Jul 2019 10:02:36 +0000 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C042B4E321EA8CF8BCE8; Tue, 16 Jul 2019 18:02:26 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jul 2019 18:02:23 +0800 From: Chao Yu To: Jaegeuk Kim , Chao Yu References: <20190424094850.118323-1-yuchao0@huawei.com> <20190428133802.GB37346@jaegeuk-macbookpro.roam.corp.google.com> <373f4633-d331-5cf3-74b7-e982072bc4b4@kernel.org> <20190501032242.GA84420@jaegeuk-macbookpro.roam.corp.google.com> <3f170d86-e556-13ae-ce19-3bba3944f5fa@huawei.com> <192bae92-2193-570f-7b50-00334271bd2e@huawei.com> Message-ID: Date: Tue, 16 Jul 2019 18:02:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <192bae92-2193-570f-7b50-00334271bd2e@huawei.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1hnKI6-002we0-RF Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to do sanity with enabled features in image X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Jaegeuk, On 2019/5/9 9:15, Chao Yu wrote: > On 2019/5/5 10:51, Chao Yu wrote: >> On 2019/5/1 11:22, Jaegeuk Kim wrote: >>> On 04/29, Chao Yu wrote: >>>> On 2019-4-28 21:38, Jaegeuk Kim wrote: >>>>> On 04/24, Chao Yu wrote: >>>>>> This patch fixes to do sanity with enabled features in image, if >>>>>> there are features kernel can not recognize, just fail the mount. >>>>> >>>>> We need to figure out per-feature-based rejection, since some of them can >>>>> be set without layout change. What about adding one field in superblock for compatible features in future? sb.feature(F2FS_FEATURE_LAST, max] stores uncompatible features sb.compatible_feature stores compatible features If we follow above rule when adding one feature, then, we can fail the mount if sb.feature(F2FS_FEATURE_LAST, max] is valid. Thanks, >>>> >>>> So any suggestion on how to implement this? >>> >>> Which features do we need to disallow? When we introduce new features, they >> >> I guess it should be the new features. >> >>> didn't hurt the previous flow by checking f2fs_sb_has_###(). >> >> Yes, but new features may use new disk layout, if old kernel handled it with old >> disk layout, there must be problematic. >> >> e.g. format image with -O extra_attr, and mount it with kernel who don't >> recognize new inode layout. > > Jaegeuk, > > Any thoughts? > > Thanks, > >> >> Thanks, >> >>> >>>> >>>> Maybe: >>>> >>>> if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)) >>>> check 4.14+ features >>>> else if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 9, 0)) >>>> check 4.9+ features >>>> else if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 4, 0)) >>>> check 4.4+ features >>>> >>>> Thanks, >>>> >>>>> >>>>>> >>>>>> Signed-off-by: Chao Yu >>>>>> --- >>>>>> fs/f2fs/f2fs.h | 13 +++++++++++++ >>>>>> fs/f2fs/super.c | 9 +++++++++ >>>>>> 2 files changed, 22 insertions(+) >>>>>> >>>>>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>>>>> index f5ffc09705eb..15b640967e12 100644 >>>>>> --- a/fs/f2fs/f2fs.h >>>>>> +++ b/fs/f2fs/f2fs.h >>>>>> @@ -151,6 +151,19 @@ struct f2fs_mount_info { >>>>>> #define F2FS_FEATURE_VERITY 0x0400 /* reserved */ >>>>>> #define F2FS_FEATURE_SB_CHKSUM 0x0800 >>>>>> >>>>>> +#define F2FS_ALL_FEATURES (F2FS_FEATURE_ENCRYPT | \ >>>>>> + F2FS_FEATURE_BLKZONED | \ >>>>>> + F2FS_FEATURE_ATOMIC_WRITE | \ >>>>>> + F2FS_FEATURE_EXTRA_ATTR | \ >>>>>> + F2FS_FEATURE_PRJQUOTA | \ >>>>>> + F2FS_FEATURE_INODE_CHKSUM | \ >>>>>> + F2FS_FEATURE_FLEXIBLE_INLINE_XATTR | \ >>>>>> + F2FS_FEATURE_QUOTA_INO | \ >>>>>> + F2FS_FEATURE_INODE_CRTIME | \ >>>>>> + F2FS_FEATURE_LOST_FOUND | \ >>>>>> + F2FS_FEATURE_VERITY | \ >>>>>> + F2FS_FEATURE_SB_CHKSUM) >>>>>> + >>>>>> #define __F2FS_HAS_FEATURE(raw_super, mask) \ >>>>>> ((raw_super->feature & cpu_to_le32(mask)) != 0) >>>>>> #define F2FS_HAS_FEATURE(sbi, mask) __F2FS_HAS_FEATURE(sbi->raw_super, mask) >>>>>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >>>>>> index 4f8e9ab48b26..57f2fc6d14ba 100644 >>>>>> --- a/fs/f2fs/super.c >>>>>> +++ b/fs/f2fs/super.c >>>>>> @@ -2573,6 +2573,15 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi, >>>>>> return 1; >>>>>> } >>>>>> >>>>>> + /* check whether kernel supports all features */ >>>>>> + if (le32_to_cpu(raw_super->feature) & (~F2FS_ALL_FEATURES)) { >>>>>> + f2fs_msg(sb, KERN_INFO, >>>>>> + "Unsupported feature:%u: supported:%u", >>>>>> + le32_to_cpu(raw_super->feature), >>>>>> + F2FS_ALL_FEATURES); >>>>>> + return 1; >>>>>> + } >>>>>> + >>>>>> /* check CP/SIT/NAT/SSA/MAIN_AREA area boundary */ >>>>>> if (sanity_check_area_boundary(sbi, bh)) >>>>>> return 1; >>>>>> -- >>>>>> 2.18.0.rc1 >>> . >>> >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >> . >> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel