From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org, "Choong,
Yin Thong" <yin.thong.choong@intel.com>
Subject: Re: [PATCH v2 4/8] logrotate: replace fedorahosted.org SRC_URI with github.com source
Date: Tue, 4 Apr 2017 13:40:19 +0300 [thread overview]
Message-ID: <a178ed58-d530-6097-d341-f9203504f06d@linux.intel.com> (raw)
In-Reply-To: <1491298154-68270-5-git-send-email-yin.thong.choong@intel.com>
On 04/04/2017 12:29 PM, yin.thong.choong@intel.com wrote:
> -SRC_URI = "https://fedorahosted.org/releases/l/o/logrotate/logrotate-${PV}.tar.gz \
> +S = "${WORKDIR}/${PN}-r3-9-1"
> +
> +UPSTREAM_CHECK_URI = "https://github.com/${PN}/${PN}/releases"
> +
> +SRC_URI = "https://github.com/${PN}/${PN}/archive/r3-9-1.tar.gz \
Why are we taking a github snapshot tarball (which is not standard
parctice in oe-core)? Put a comment here that when updating logrotate to
latest upstream, SRC_URI should point to a proper release tarball from
https://github.com/logrotate/logrotate/releases and we have to take the
snapshot for now because there is no such tarball available for 3.9.1.
Generally, don't be afraid to put comments next to your changes, the
more the better! And especially when you are doing something unusual
that is not self-explanatory like above.
Otherwise, I am happy with the patchset!
Alex
next prev parent reply other threads:[~2017-04-04 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 9:29 [PATCH v2 0/8] Remove all use of fedorahosted SRC_URI [yocto #11226] yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 1/8] selftest/recipetool: replace fedorahosted.org SRC_URI with github.com source yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 2/8] xmlto: replace fedorahosted.org SRC_URI with pagure.io source yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 3/8] libuser: " yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 4/8] logrotate: replace fedorahosted.org SRC_URI with github.com source yin.thong.choong
2017-04-04 10:40 ` Alexander Kanavin [this message]
2017-04-05 7:55 ` Choong, Yin Thong
2017-04-04 9:29 ` [PATCH v2 5/8] libnewt: replace fedorahosted.org SRC_URI with pagure.io source yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 6/8] liberation-fonts: " yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 7/8] chkconfig: replace fedorahosted.org SRC_URI with github.com source yin.thong.choong
2017-04-04 9:29 ` [PATCH v2 8/8] cronie: " yin.thong.choong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a178ed58-d530-6097-d341-f9203504f06d@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yin.thong.choong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.