From: Sergey Shtylyov <firstname.lastname@example.org>
To: Greg Kroah-Hartman <email@example.com>
Cc: "Rafael J. Wysocki" <firstname.lastname@example.org>,
<email@example.com>, Marc Zyngier <firstname.lastname@example.org>
Subject: Re: [PATCH v2] platform: finally disallow IRQ0 in platform_get_irq() and its ilk
Date: Thu, 28 Apr 2022 22:59:11 +0300 [thread overview]
Message-ID: <email@example.com> (raw)
On 4/28/22 9:13 AM, Greg Kroah-Hartman wrote:
>>>> The commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is
>>>> invalid") only calls WARN() when IRQ0 is about to be returned, however
>>>> using IRQ0 is considered invalid (according to Linus) outside the arch/
>>>> code where it's used by the i8253 drivers. Many driver subsystems treat
>>>> 0 specially (e.g. as an indication of the polling mode by libata), so
>>>> the users of platform_get_irq[_byname]() in them would have to filter
>>>> out IRQ0 explicitly and this (quite obviously) doesn't scale...
>>>> Let's finally get this straight and return -EINVAL instead of IRQ0!
>>>> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
>>>> Signed-off-by: Sergey Shtylyov <firstname.lastname@example.org>
>>>> Acked-by: Marc Zyngier <email@example.com>
>>> Ok, let's try this now.
>> Well, better late than never! :-)
>>> Worst case, we revert it later :)
>> Please just don't revert it outright on the 1st issue report -- give me time
>> to look at the issue(s) reported...
>> BTW, I've CC'ed you on the SH patch that avoids using IRQ0. Please help to
>> merge it (v1/v2 were posted on February 11th and there was no motion since then)!
> I can't merge that until a sh maintainer acks it.
Hm, looking at the arch/sh/ commit history, you've recently merged couple patches
without any ACKs from the SH people. ;-) What concerns you in this case, me touching
the assembly code? Who's worth looping in on that patch, do you think, maybe Andrew
Morton or Linus himself?
> Is that arch even still alive?
Well, considering J-core should be still alive (there's #jcore channel on Libera.chat,
where you can find Rich Felker as dalias), arch/sh/ must be still alive too...
It probably needs the better maintainers though... :-)
> greg k-h
prev parent reply other threads:[~2022-04-28 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 19:35 [PATCH v2] platform: finally disallow IRQ0 in platform_get_irq() and its ilk Sergey Shtylyov
2022-03-28 7:30 ` Sergey Shtylyov
2022-04-26 10:46 ` Greg Kroah-Hartman
2022-04-27 18:59 ` Sergey Shtylyov
2022-04-28 6:13 ` Greg Kroah-Hartman
2022-04-28 19:59 ` Sergey Shtylyov [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.