From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64346C433EF for ; Thu, 28 Apr 2022 19:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351614AbiD1UCh (ORCPT ); Thu, 28 Apr 2022 16:02:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351574AbiD1UCd (ORCPT ); Thu, 28 Apr 2022 16:02:33 -0400 Received: from mxout02.lancloud.ru (mxout02.lancloud.ru [45.84.86.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92E87BF319 for ; Thu, 28 Apr 2022 12:59:15 -0700 (PDT) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru D722022F0625 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v2] platform: finally disallow IRQ0 in platform_get_irq() and its ilk To: Greg Kroah-Hartman CC: "Rafael J. Wysocki" , , Marc Zyngier References: <025679e1-1f0a-ae4b-4369-01164f691511@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Thu, 28 Apr 2022 22:59:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/22 9:13 AM, Greg Kroah-Hartman wrote: [...] >>>> The commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is >>>> invalid") only calls WARN() when IRQ0 is about to be returned, however >>>> using IRQ0 is considered invalid (according to Linus) outside the arch/ >>>> code where it's used by the i8253 drivers. Many driver subsystems treat >>>> 0 specially (e.g. as an indication of the polling mode by libata), so >>>> the users of platform_get_irq[_byname]() in them would have to filter >>>> out IRQ0 explicitly and this (quite obviously) doesn't scale... >>>> Let's finally get this straight and return -EINVAL instead of IRQ0! >>>> >>>> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid") >>>> Signed-off-by: Sergey Shtylyov >>>> Acked-by: Marc Zyngier >> >> [...] >> >>> Ok, let's try this now. >> >> Well, better late than never! :-) >> >>> Worst case, we revert it later :) >> >> Please just don't revert it outright on the 1st issue report -- give me time >> to look at the issue(s) reported... >> BTW, I've CC'ed you on the SH patch that avoids using IRQ0. Please help to >> merge it (v1/v2 were posted on February 11th and there was no motion since then)! > > I can't merge that until a sh maintainer acks it. Hm, looking at the arch/sh/ commit history, you've recently merged couple patches without any ACKs from the SH people. ;-) What concerns you in this case, me touching the assembly code? Who's worth looping in on that patch, do you think, maybe Andrew Morton or Linus himself? > Is that arch even still alive? Well, considering J-core should be still alive (there's #jcore channel on Libera.chat, where you can find Rich Felker as dalias), arch/sh/ must be still alive too... It probably needs the better maintainers though... :-) > thanks, > > greg k-h MBR, Sergey