From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEBAC47095 for ; Wed, 9 Jun 2021 07:44:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49BDB6135D for ; Wed, 9 Jun 2021 07:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235781AbhFIHqL (ORCPT ); Wed, 9 Jun 2021 03:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233136AbhFIHqG (ORCPT ); Wed, 9 Jun 2021 03:46:06 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A65EEC061574; Wed, 9 Jun 2021 00:43:58 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id m41-20020a05600c3b29b02901b9e5d74f02so401848wms.3; Wed, 09 Jun 2021 00:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ihs/M3HXxfcfdqcK6ShERGmNiIwPqOR4VL78BLcUpL2KZujymyOFRY/qkAe+5slhsW QGGw1zRiCl3/oKgVIG0L5N/UwmRohLjxkvDZYW0ZgMgueMUgQ5p5KxICAKZgBW5MByI6 1wvCIUA4w09NWUzZMCsAe/bdnLIHleQDciilgfOlygDXs/99S1fxZBhSQw6YZDXtKLlB V41F7zfaEGWNQ5hZOl22FQ+UI2Sr/vnqfRXBRST0lTMBAO+FcANq+f6kJlFDVIetgOv4 5yuqeeUBORrQos9RQszQJMuytnjC2598FLs9JBlRP5FS28zZQcfdYtjdaRYVh/4Ldxoy rfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=r1KGaJrkOLNhIJhYKDzsYigEKZlRfS7DgiHHUGnjPPhwhsI+Ykzh8uuz7i/Ft6kqVw Yhn8lPapkiCZ7+0NcheuQXBm6nm0T/WLtGCzCBFKjODQLYOdeHXsmRKRJ4PeOtV/iwTa WQ6kvo8fH0xpWpk7wp0yBK0zjx6WdVeS/8MhUmrFw2zBmSe3J5MkTGLwuwVNPDM3weqd ZOEN83iqwkvRreO0eAZv04ylwzLRSIvPVvvwkEKJLrX1eGdIN4vFLGmS8BTFS5UG1h9N gMRtIsM2Xb60ZamfUQNq8e/5J775Z7tyryjP24Ass5DF0sUP/mJYHp4I7UYCJFRFe/TY 9w6g== X-Gm-Message-State: AOAM532qFay7k/cnfRj7PDAlm5Nh+TTEfIyUaFcyVCDYp2vr9dIdEOmo 0+G/EGEnVoXFnikTyXTiP/c= X-Google-Smtp-Source: ABdhPJy1TN5g9HVPQta2ngBPCU9iX96cZHpN+j/ZJV4T2M0MwzeH3BbE0S0m5qwPSCAQmLDWiA+gmw== X-Received: by 2002:a7b:c189:: with SMTP id y9mr26040858wmi.106.1623224637195; Wed, 09 Jun 2021 00:43:57 -0700 (PDT) Received: from ziggy.stardust (81.172.61.185.dyn.user.ono.com. [81.172.61.185]) by smtp.gmail.com with ESMTPSA id q3sm22548486wrr.43.2021.06.09.00.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 00:43:56 -0700 (PDT) Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4 To: Yongqiang Niu , Chun-Kuang Hu Cc: Rob Herring , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1618236288-1617-1-git-send-email-yongqiang.niu@mediatek.com> <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> From: Matthias Brugger Message-ID: Date: Wed, 9 Jun 2021 09:43:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/2021 16:04, Yongqiang Niu wrote: > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h > index 7718cd6..4bba275 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_RDMA0, > DDP_COMPONENT_RDMA1, > DDP_COMPONENT_RDMA2, > + DDP_COMPONENT_RDMA4, Pach 1-3 looks good, but could be squashed in one patch. Please try to come up with a more descriptive commit message. Rule of thumb is to explain why we need a patch not what the patch does. Regards, Matthias > DDP_COMPONENT_UFOE, > DDP_COMPONENT_WDMA0, > DDP_COMPONENT_WDMA1, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E122FC47095 for ; Wed, 9 Jun 2021 07:44:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1A6F61351 for ; Wed, 9 Jun 2021 07:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A6F61351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uRTtgQkBgaNrTm8zrVAc2xVCaFizpa00gV40na5EgWc=; b=KDD+I56dj1H33IJBQkpRcuc3VL XxOEjxolRjwQ2JuYVbGv+mFn+qs9VswRCIkdob/0UuC9JGlcz+351ReoarjtjoNXJNcIWc7B0CQSH xKJci/wpF5luKB240pj5VS1c1OxqhHMKe4BbNIt18ot3TmxquFwtEyof9kh5TNxuIQERJhxC1J2bd caMCxyktlqiRG1pcGugXNs3xEEHtsS/eSc88B2J1CMNUH4boP2aJmWdeN5ACXYZC+4POu5CO5YAhf BAUKbc+hy9NNQEgE+nc9dLmCntzLwr50LzdQhhdHbSG4Zj7UdV0in4N6MGAeVH0bcJDxrlrOMh5HL g8e7bLvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqssb-00C9Gj-FY; Wed, 09 Jun 2021 07:44:01 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqssZ-00C9F9-LV; Wed, 09 Jun 2021 07:44:00 +0000 Received: by mail-wm1-x332.google.com with SMTP id l11-20020a05600c4f0bb029017a7cd488f5so3537929wmq.0; Wed, 09 Jun 2021 00:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ihs/M3HXxfcfdqcK6ShERGmNiIwPqOR4VL78BLcUpL2KZujymyOFRY/qkAe+5slhsW QGGw1zRiCl3/oKgVIG0L5N/UwmRohLjxkvDZYW0ZgMgueMUgQ5p5KxICAKZgBW5MByI6 1wvCIUA4w09NWUzZMCsAe/bdnLIHleQDciilgfOlygDXs/99S1fxZBhSQw6YZDXtKLlB V41F7zfaEGWNQ5hZOl22FQ+UI2Sr/vnqfRXBRST0lTMBAO+FcANq+f6kJlFDVIetgOv4 5yuqeeUBORrQos9RQszQJMuytnjC2598FLs9JBlRP5FS28zZQcfdYtjdaRYVh/4Ldxoy rfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ZuG+17VK2KAtS9d5KFzt+OjiR6IBtLEZuED4bC0Jxx5/UoWTUfmBU2r/Ck/pTQO+lt lgJ3uA539RuxiQUYX68NsNsLS3nqY8rD87LrPzDhYl0oOA3Y66iXQmHaDfF217r2MFm9 qkONE+ZpojdW9YbMKNRONxoCi8ROiYmWC76X7otdNmWBezWzTkrf7lY5stSeYNhXKAb4 yOTvyfqotc1YzKOkzTc4nUKGiNb8EwKPwoOo8lh7MzP2v9SQK2ZC9HaoVs3e6z+xDTTk viiuX0VeuDkm2RVjc8nRtCPrRlwX6sGVzZJavThVMjhBWkj+PUuWGS8TLaJn0pZ1bxjX JvoA== X-Gm-Message-State: AOAM531Rb6hpvTVrZqTWo8///2i7iVxYZwE3UvEpvVIScXmN6BJXTSVd 77X8MrCu4Pbc1v8t0Z4Cr84= X-Google-Smtp-Source: ABdhPJy1TN5g9HVPQta2ngBPCU9iX96cZHpN+j/ZJV4T2M0MwzeH3BbE0S0m5qwPSCAQmLDWiA+gmw== X-Received: by 2002:a7b:c189:: with SMTP id y9mr26040858wmi.106.1623224637195; Wed, 09 Jun 2021 00:43:57 -0700 (PDT) Received: from ziggy.stardust (81.172.61.185.dyn.user.ono.com. [81.172.61.185]) by smtp.gmail.com with ESMTPSA id q3sm22548486wrr.43.2021.06.09.00.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 00:43:56 -0700 (PDT) Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4 To: Yongqiang Niu , Chun-Kuang Hu Cc: Rob Herring , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1618236288-1617-1-git-send-email-yongqiang.niu@mediatek.com> <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> From: Matthias Brugger Message-ID: Date: Wed, 9 Jun 2021 09:43:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_004359_742757_E57466F3 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 12/04/2021 16:04, Yongqiang Niu wrote: > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h > index 7718cd6..4bba275 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_RDMA0, > DDP_COMPONENT_RDMA1, > DDP_COMPONENT_RDMA2, > + DDP_COMPONENT_RDMA4, Pach 1-3 looks good, but could be squashed in one patch. Please try to come up with a more descriptive commit message. Rule of thumb is to explain why we need a patch not what the patch does. Regards, Matthias > DDP_COMPONENT_UFOE, > DDP_COMPONENT_WDMA0, > DDP_COMPONENT_WDMA1, > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75590C47095 for ; Wed, 9 Jun 2021 07:45:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 410DB61361 for ; Wed, 9 Jun 2021 07:45:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410DB61361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+n+GsU1Fhlug2mGUo80BcvPBEQt0vD0Wi1bGwa5SiR8=; b=bpMY91MHdMnyI1pgmFOUg0zFbq BPH/7if4LnXd5m7ofEoz7vOFMcx9gNA3+VEbzpX12rkOd2YAs2y3OQrGfdLzoYNHnwVSHYtzWGtmh tvF5geuQ2sLZBuXEySeaZpYx6rSfwbp/z57ZJFdjprfxia3q5PkqNXgF7NQ32n3VYL7+vo2HJJR0H NAB8IssHgKkfIdS57reOI01B28sPIRHpqpUvCYIz0Ly/7JGGCq3egdtF/fpIUEBiyiLZW5yrwKPm4 /PlYrhv6KxlNIZLG5TbWCfhzsWHhwUnUQ1Nk+j8opiirLKcaDO51tHeTia4LqM4YHvNVdOF4gLDul 6i+dvRPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqssd-00C9HB-NA; Wed, 09 Jun 2021 07:44:03 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqssZ-00C9F9-LV; Wed, 09 Jun 2021 07:44:00 +0000 Received: by mail-wm1-x332.google.com with SMTP id l11-20020a05600c4f0bb029017a7cd488f5so3537929wmq.0; Wed, 09 Jun 2021 00:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ihs/M3HXxfcfdqcK6ShERGmNiIwPqOR4VL78BLcUpL2KZujymyOFRY/qkAe+5slhsW QGGw1zRiCl3/oKgVIG0L5N/UwmRohLjxkvDZYW0ZgMgueMUgQ5p5KxICAKZgBW5MByI6 1wvCIUA4w09NWUzZMCsAe/bdnLIHleQDciilgfOlygDXs/99S1fxZBhSQw6YZDXtKLlB V41F7zfaEGWNQ5hZOl22FQ+UI2Sr/vnqfRXBRST0lTMBAO+FcANq+f6kJlFDVIetgOv4 5yuqeeUBORrQos9RQszQJMuytnjC2598FLs9JBlRP5FS28zZQcfdYtjdaRYVh/4Ldxoy rfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ZuG+17VK2KAtS9d5KFzt+OjiR6IBtLEZuED4bC0Jxx5/UoWTUfmBU2r/Ck/pTQO+lt lgJ3uA539RuxiQUYX68NsNsLS3nqY8rD87LrPzDhYl0oOA3Y66iXQmHaDfF217r2MFm9 qkONE+ZpojdW9YbMKNRONxoCi8ROiYmWC76X7otdNmWBezWzTkrf7lY5stSeYNhXKAb4 yOTvyfqotc1YzKOkzTc4nUKGiNb8EwKPwoOo8lh7MzP2v9SQK2ZC9HaoVs3e6z+xDTTk viiuX0VeuDkm2RVjc8nRtCPrRlwX6sGVzZJavThVMjhBWkj+PUuWGS8TLaJn0pZ1bxjX JvoA== X-Gm-Message-State: AOAM531Rb6hpvTVrZqTWo8///2i7iVxYZwE3UvEpvVIScXmN6BJXTSVd 77X8MrCu4Pbc1v8t0Z4Cr84= X-Google-Smtp-Source: ABdhPJy1TN5g9HVPQta2ngBPCU9iX96cZHpN+j/ZJV4T2M0MwzeH3BbE0S0m5qwPSCAQmLDWiA+gmw== X-Received: by 2002:a7b:c189:: with SMTP id y9mr26040858wmi.106.1623224637195; Wed, 09 Jun 2021 00:43:57 -0700 (PDT) Received: from ziggy.stardust (81.172.61.185.dyn.user.ono.com. [81.172.61.185]) by smtp.gmail.com with ESMTPSA id q3sm22548486wrr.43.2021.06.09.00.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 00:43:56 -0700 (PDT) Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4 To: Yongqiang Niu , Chun-Kuang Hu Cc: Rob Herring , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1618236288-1617-1-git-send-email-yongqiang.niu@mediatek.com> <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> From: Matthias Brugger Message-ID: Date: Wed, 9 Jun 2021 09:43:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_004359_742757_E57466F3 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/2021 16:04, Yongqiang Niu wrote: > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h > index 7718cd6..4bba275 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_RDMA0, > DDP_COMPONENT_RDMA1, > DDP_COMPONENT_RDMA2, > + DDP_COMPONENT_RDMA4, Pach 1-3 looks good, but could be squashed in one patch. Please try to come up with a more descriptive commit message. Rule of thumb is to explain why we need a patch not what the patch does. Regards, Matthias > DDP_COMPONENT_UFOE, > DDP_COMPONENT_WDMA0, > DDP_COMPONENT_WDMA1, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB64C47095 for ; Wed, 9 Jun 2021 07:44:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DBA56135D for ; Wed, 9 Jun 2021 07:44:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DBA56135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD2AD89FA6; Wed, 9 Jun 2021 07:43:59 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id A384E89FA6 for ; Wed, 9 Jun 2021 07:43:58 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id h22-20020a05600c3516b02901a826f84095so3493214wmq.5 for ; Wed, 09 Jun 2021 00:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=ihs/M3HXxfcfdqcK6ShERGmNiIwPqOR4VL78BLcUpL2KZujymyOFRY/qkAe+5slhsW QGGw1zRiCl3/oKgVIG0L5N/UwmRohLjxkvDZYW0ZgMgueMUgQ5p5KxICAKZgBW5MByI6 1wvCIUA4w09NWUzZMCsAe/bdnLIHleQDciilgfOlygDXs/99S1fxZBhSQw6YZDXtKLlB V41F7zfaEGWNQ5hZOl22FQ+UI2Sr/vnqfRXBRST0lTMBAO+FcANq+f6kJlFDVIetgOv4 5yuqeeUBORrQos9RQszQJMuytnjC2598FLs9JBlRP5FS28zZQcfdYtjdaRYVh/4Ldxoy rfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Ed9mm909+j2egVHjfeRzyEVoKd06Gn517VmwgTGDNY=; b=Z6Pi4DVIdeIlpFHWYOSpsfSw5cN8bU6LNo3DMss3wKtURdvfwbtelL0B9ZSyzT4U2d L7AVv1mbISXdH65DV/rLZgefsXOTYaXGQC2R93iQ/QZ+t5vj5E/CjpDOA8FOtSkAc7jz 4LWKmSNTae7BwagILBarpAvx+8APUffWqvL1ILOCe+UV6MLN4qk3FKYoH0XlSmjgMQy4 GwGhJ4fDGMwew+X0CQabOcayk3MivniADCPMqU+QzTq5CFnso5ly9niIp9y4kLjKr3im dv7tDLdLKmbh7Vkj2SH9H+F/eWh3LZfsA4cmS58xbjZnsD2aI20faBXfTRQBJIvN36Mn WBsg== X-Gm-Message-State: AOAM532AXNM5PNT4vJ2HXfq3IgCO8WHwd+q7nrry0YMfY632FrAwkLtH kdYQfjnUYuMVSEuFviTTM+U= X-Google-Smtp-Source: ABdhPJy1TN5g9HVPQta2ngBPCU9iX96cZHpN+j/ZJV4T2M0MwzeH3BbE0S0m5qwPSCAQmLDWiA+gmw== X-Received: by 2002:a7b:c189:: with SMTP id y9mr26040858wmi.106.1623224637195; Wed, 09 Jun 2021 00:43:57 -0700 (PDT) Received: from ziggy.stardust (81.172.61.185.dyn.user.ono.com. [81.172.61.185]) by smtp.gmail.com with ESMTPSA id q3sm22548486wrr.43.2021.06.09.00.43.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 00:43:56 -0700 (PDT) Subject: Re: [PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4 To: Yongqiang Niu , Chun-Kuang Hu References: <1618236288-1617-1-git-send-email-yongqiang.niu@mediatek.com> <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> From: Matthias Brugger Message-ID: Date: Wed, 9 Jun 2021 09:43:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1618236288-1617-4-git-send-email-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, David Airlie , Jassi Brar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dennis YC Hsieh , Fabien Parent , Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/04/2021 16:04, Yongqiang Niu wrote: > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu > --- > include/linux/soc/mediatek/mtk-mmsys.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h > index 7718cd6..4bba275 100644 > --- a/include/linux/soc/mediatek/mtk-mmsys.h > +++ b/include/linux/soc/mediatek/mtk-mmsys.h > @@ -38,6 +38,7 @@ enum mtk_ddp_comp_id { > DDP_COMPONENT_RDMA0, > DDP_COMPONENT_RDMA1, > DDP_COMPONENT_RDMA2, > + DDP_COMPONENT_RDMA4, Pach 1-3 looks good, but could be squashed in one patch. Please try to come up with a more descriptive commit message. Rule of thumb is to explain why we need a patch not what the patch does. Regards, Matthias > DDP_COMPONENT_UFOE, > DDP_COMPONENT_WDMA0, > DDP_COMPONENT_WDMA1, >