From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyJGY-0001Wx-LA for qemu-devel@nongnu.org; Fri, 07 Sep 2018 12:05:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyJGU-0000XT-CD for qemu-devel@nongnu.org; Fri, 07 Sep 2018 12:05:50 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:42513 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fyJGU-0000Qb-0X for qemu-devel@nongnu.org; Fri, 07 Sep 2018 12:05:46 -0400 From: Paul Durrant Date: Fri, 7 Sep 2018 16:05:39 +0000 Message-ID: References: <153631568068.32214.13361287430751567885.stgit@dhcp-3-135.uk.xensource.com> <153631569081.32214.17009673757832831029.stgit@dhcp-3-135.uk.xensource.com> In-Reply-To: <153631569081.32214.17009673757832831029.stgit@dhcp-3-135.uk.xensource.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tim Smith , "qemu-devel@nongnu.org" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBRZW11LWRldmVsIFttYWlsdG86 cWVtdS1kZXZlbC0NCj4gYm91bmNlcytwYXVsLmR1cnJhbnQ9Y2l0cml4LmNvbUBub25nbnUub3Jn XSBPbiBCZWhhbGYgT2YgVGltIFNtaXRoDQo+IFNlbnQ6IDA3IFNlcHRlbWJlciAyMDE4IDExOjIy DQo+IFRvOiBxZW11LWRldmVsQG5vbmdudS5vcmcNCj4gU3ViamVjdDogW1FlbXUtZGV2ZWxdIFtQ QVRDSCAzLzNdIEF2b2lkIHJlcGVhdGVkIG1lbW9yeSBhbGxvY2F0aW9uIGluDQo+IHhlbl9kaXNr DQo+IA0KPiB4ZW5fZGlzayBjdXJyZW50bHkgYWxsb2NhdGVzIG1lbW9yeSB0byBob2xkIHRoZSBk YXRhIGZvciBlYWNoIGlvcmVxDQo+IGFzIHRoYXQgaW9yZXEgaXMgdXNlZCwgYW5kIGZyZWVzIGl0 IGFmdGVyd2FyZHMuIEJlY2F1c2UgaXQgcmVxdWlyZXMNCj4gcGFnZS1hbGlnbmVkIGJsb2Nrcywg dGhpcyBpbnRlcmFjdHMgcG9vcmx5IHdpdGggbm9uLXBhZ2UtYWxpZ25lZA0KPiBhbGxvY2F0aW9u cyBhbmQgYmFsbG9vbnMgdGhlIGhlYXAuDQo+IA0KPiBJbnN0ZWFkLCBhbGxvY2F0ZSB0aGUgbWF4 aW11bSBwb3NzaWJsZSByZXF1aXJlbWVudCwgd2hpY2ggaXMNCj4gQkxLSUZfTUFYX1NFR01FTlRT X1BFUl9SRVFVRVNUIHBhZ2VzIChjdXJyZW50bHkgMTEgcGFnZXMpIHdoZW4NCj4gdGhlIGlvcmVx IGlzIGNyZWF0ZWQsIGFuZCBrZWVwIHRoYXQgYWxsb2NhdGlvbiB1bnRpbCBpdCBpcyBkZXN0cm95 ZWQuDQo+IFNpbmNlIHRoZSBpb3JlcXMgdGhlbXNlbHZlcyBhcmUgcmUtdXNlZCB2aWEgYSBmcmVl IGxpc3QsIHRoaXMNCj4gc2hvdWxkIGFjdHVhbGx5IGltcHJvdmUgbWVtb3J5IHVzYWdlLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogVGltIFNtaXRoIDx0aW0uc21pdGhAY2l0cml4LmNvbT4NCg0KUmV2 aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQoNCj4gLS0t DQo+ICBody9ibG9jay94ZW5fZGlzay5jIHwgICAxMCArKysrKy0tLS0tDQo+ICAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L2h3L2Jsb2NrL3hlbl9kaXNrLmMgYi9ody9ibG9jay94ZW5fZGlzay5jDQo+IGluZGV4IGMxMWNk MjFkMzcuLjY3Zjg5NGJiYTUgMTAwNjQ0DQo+IC0tLSBhL2h3L2Jsb2NrL3hlbl9kaXNrLmMNCj4g KysrIGIvaHcvYmxvY2sveGVuX2Rpc2suYw0KPiBAQCAtMTEyLDcgKzExMiw2IEBAIHN0YXRpYyB2 b2lkIGlvcmVxX3Jlc2V0KHN0cnVjdCBpb3JlcSAqaW9yZXEpDQo+ICAgICAgbWVtc2V0KCZpb3Jl cS0+cmVxLCAwLCBzaXplb2YoaW9yZXEtPnJlcSkpOw0KPiAgICAgIGlvcmVxLT5zdGF0dXMgPSAw Ow0KPiAgICAgIGlvcmVxLT5zdGFydCA9IDA7DQo+IC0gICAgaW9yZXEtPmJ1ZiA9IE5VTEw7DQo+ ICAgICAgaW9yZXEtPnNpemUgPSAwOw0KPiAgICAgIGlvcmVxLT5wcmVzeW5jID0gMDsNCj4gDQo+ IEBAIC0xMzcsNiArMTM2LDEwIEBAIHN0YXRpYyBzdHJ1Y3QgaW9yZXEgKmlvcmVxX3N0YXJ0KHN0 cnVjdCBYZW5CbGtEZXYNCj4gKmJsa2RldikNCj4gICAgICAgICAgLyogYWxsb2NhdGUgbmV3IHN0 cnVjdCAqLw0KPiAgICAgICAgICBpb3JlcSA9IGdfbWFsbG9jMChzaXplb2YoKmlvcmVxKSk7DQo+ ICAgICAgICAgIGlvcmVxLT5ibGtkZXYgPSBibGtkZXY7DQo+ICsgICAgICAgIC8qIFdlIGNhbm5v dCBuZWVkIG1vcmUgcGFnZXMgcGVyIGlvcmVxIHRoYW4gdGhpcywgYW5kIHdlIGRvIHJlLXVzZQ0K PiBpb3JlcXMsDQo+ICsgICAgICAgICAqIHNvIGFsbG9jYXRlIHRoZSBtZW1vcnkgb25jZSBoZXJl LCB0byBiZSBmcmVlZCBpbiBibGtfZnJlZSgpIHdoZW4NCj4gdGhlDQo+ICsgICAgICAgICAqIGlv cmVxIGlzIGZyZWVkLiAqLw0KPiArICAgICAgICBpb3JlcS0+YnVmID0gcWVtdV9tZW1hbGlnbihY Q19QQUdFX1NJWkUsDQo+IEJMS0lGX01BWF9TRUdNRU5UU19QRVJfUkVRVUVTVCAqIFhDX1BBR0Vf U0laRSk7DQo+ICAgICAgICAgIGJsa2Rldi0+cmVxdWVzdHNfdG90YWwrKzsNCj4gICAgICAgICAg cWVtdV9pb3ZlY19pbml0KCZpb3JlcS0+diwgMSk7DQo+ICAgICAgfSBlbHNlIHsNCj4gQEAgLTMx MywxNCArMzE2LDEyIEBAIHN0YXRpYyB2b2lkIHFlbXVfYWlvX2NvbXBsZXRlKHZvaWQgKm9wYXF1 ZSwgaW50DQo+IHJldCkNCj4gICAgICAgICAgaWYgKHJldCA9PSAwKSB7DQo+ICAgICAgICAgICAg ICBpb3JlcV9ncmFudF9jb3B5KGlvcmVxKTsNCj4gICAgICAgICAgfQ0KPiAtICAgICAgICBxZW11 X3ZmcmVlKGlvcmVxLT5idWYpOw0KPiAgICAgICAgICBicmVhazsNCj4gICAgICBjYXNlIEJMS0lG X09QX1dSSVRFOg0KPiAgICAgIGNhc2UgQkxLSUZfT1BfRkxVU0hfRElTS0NBQ0hFOg0KPiAgICAg ICAgICBpZiAoIWlvcmVxLT5yZXEubnJfc2VnbWVudHMpIHsNCj4gICAgICAgICAgICAgIGJyZWFr Ow0KPiAgICAgICAgICB9DQo+IC0gICAgICAgIHFlbXVfdmZyZWUoaW9yZXEtPmJ1Zik7DQo+ICAg ICAgICAgIGJyZWFrOw0KPiAgICAgIGRlZmF1bHQ6DQo+ICAgICAgICAgIGJyZWFrOw0KPiBAQCAt MzkyLDEyICszOTMsMTAgQEAgc3RhdGljIGludCBpb3JlcV9ydW5pb19xZW11X2FpbyhzdHJ1Y3Qg aW9yZXENCj4gKmlvcmVxKQ0KPiAgew0KPiAgICAgIHN0cnVjdCBYZW5CbGtEZXYgKmJsa2RldiA9 IGlvcmVxLT5ibGtkZXY7DQo+IA0KPiAtICAgIGlvcmVxLT5idWYgPSBxZW11X21lbWFsaWduKFhD X1BBR0VfU0laRSwgaW9yZXEtPnNpemUpOw0KPiAgICAgIGlmIChpb3JlcS0+cmVxLm5yX3NlZ21l bnRzICYmDQo+ICAgICAgICAgIChpb3JlcS0+cmVxLm9wZXJhdGlvbiA9PSBCTEtJRl9PUF9XUklU RSB8fA0KPiAgICAgICAgICAgaW9yZXEtPnJlcS5vcGVyYXRpb24gPT0gQkxLSUZfT1BfRkxVU0hf RElTS0NBQ0hFKSAmJg0KPiAgICAgICAgICBpb3JlcV9ncmFudF9jb3B5KGlvcmVxKSkgew0KPiAt ICAgICAgICBxZW11X3ZmcmVlKGlvcmVxLT5idWYpOw0KPiAgICAgICAgICBnb3RvIGVycjsNCj4g ICAgICB9DQo+IA0KPiBAQCAtOTg5LDYgKzk4OCw3IEBAIHN0YXRpYyBpbnQgYmxrX2ZyZWUoc3Ry dWN0IFhlbkRldmljZSAqeGVuZGV2KQ0KPiAgICAgICAgICBpb3JlcSA9IFFMSVNUX0ZJUlNUKCZi bGtkZXYtPmZyZWVsaXN0KTsNCj4gICAgICAgICAgUUxJU1RfUkVNT1ZFKGlvcmVxLCBsaXN0KTsN Cj4gICAgICAgICAgcWVtdV9pb3ZlY19kZXN0cm95KCZpb3JlcS0+dik7DQo+ICsgICAgICAgIHFl bXVfdmZyZWUoaW9yZXEtPmJ1Zik7DQo+ICAgICAgICAgIGdfZnJlZShpb3JlcSk7DQo+ICAgICAg fQ0KPiANCj4gDQoNCg==