Re: [PATCH v2 2/2] remoteproc: mediatek: allow reading firmware-name from DT - allen-kh.cheng

From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"Ohad Ben-Cohen" <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	 <linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] remoteproc: mediatek: allow reading firmware-name from DT
Date: Tue, 19 Apr 2022 20:25:40 +0800	[thread overview]
Message-ID: <a1bd1703b39d46be48bfa1500f57c59f049d532a.camel@mediatek.com> (raw)
In-Reply-To: <cb56d23b-fb80-426f-cc30-50ef351b0ad6@collabora.com>

hi Angelo,

On Tue, 2022-04-19 at 13:49 +0200, AngeloGioacchino Del Regno wrote:
> Il 14/04/22 14:21, Allen-KH Cheng ha scritto:
> > The SCP firmware blob differs between platforms and SoCs. We add
> > support in the SCP driver for reading the path of firmware file
> > from
> > DT in order to allow these files to live in a generic file system
> > (or linux-firmware).
> > 
> > The firmware-name property is optional and the code falls back to
> > the
> > old filename if the property isn't present.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > ---
> >   drivers/remoteproc/mtk_scp.c | 7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/remoteproc/mtk_scp.c
> > b/drivers/remoteproc/mtk_scp.c
> > index ee6c4009586e..82813d74e829 100644
> > --- a/drivers/remoteproc/mtk_scp.c
> > +++ b/drivers/remoteproc/mtk_scp.c
> > @@ -809,9 +809,14 @@ static int scp_probe(struct platform_device
> > *pdev)
> >   	struct mtk_scp *scp;
> >   	struct rproc *rproc;
> >   	struct resource *res;
> > -	char *fw_name = "scp.img";
> > +	const char *fw_name = "scp.img";
> >   	int ret, i;
> >   
> > +	ret = of_property_read_string(pdev->dev.of_node, "firmware-
> > name",
> > +				      &fw_name);
> 
> Hello Allen,
> the remoteproc subsystem provides a helper for that, please use it:
> 
> 	ret = rproc_of_parse_firmware(&pdev->dev, 0, &fw_name);
> 
> 
> > +	if (ret < 0 && ret != -EINVAL)
> > +		return ret;
> 
> ... this check is necessary, so you can keep this one.
> 
> Thanks,
> Angelo
> 

ok, no problem.
I will update in next version.

thanks,
Allen

> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek