From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73EBC636D4 for ; Tue, 31 Jan 2023 16:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231577AbjAaQ5X (ORCPT ); Tue, 31 Jan 2023 11:57:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231576AbjAaQ5V (ORCPT ); Tue, 31 Jan 2023 11:57:21 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA1B01CAC3 for ; Tue, 31 Jan 2023 08:57:19 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id h16so14806200wrz.12 for ; Tue, 31 Jan 2023 08:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JRIRICEmrabbDC+z0qM+J82wcNj3dmfUYUXd7QSBt1w=; b=dy5A3IWNvdGGhkzZ4Hj/Cfw51B8qkHkcMUzU3/PlUeCci5HdMHsIC1yFgUpWlENTQT O5t+pLbzM/gY0Pf8v407BzziOP0eiV1/aW2wxhteWADN1oGKiE2NO3C2kX8YnzB6NjVJ AC7rtWjy01xrw/iCU9vOwsKQI9/ESEkwBSUNluB/+Xzx7mrz0dUNYCYulr+jvHz1QpFd GW+Hle5B6VXl1UVMpjO/uo96iZLVLXNlcgvRhpJjWU0qARNkD5W/+gagohEizqgCGJ0K O5CGmYfNn8mnZPjJIhH1Iy0lMQY9Ky2PEspg4/DhK9FN6eL3gSj7dH6tsikCwdyGDQbe DLyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JRIRICEmrabbDC+z0qM+J82wcNj3dmfUYUXd7QSBt1w=; b=JaPMNwqaD2h71MmGaC0no8DJ3YsH8RPdDr/Gxrxv9U9Xar5CSYT/Rev/0sZY8l+bNi hRmuZK3tQJkYkyenapnwpOmDBRR1o/c4CcSF5sReD1LFeWNNvwQthfc7gFf9Edn8iwE4 qQtOrebwsYatO8myglEkxYRNVHuNIZoC8w9uQ5BtCO4RLiv6peYHi9ER6DXJirK1f/5H Tc2LHxj76l2zyVKFy47XB7r2ZjC5AthBuQQVx3LUn9gZrxmanfC1ML9zs1Cjjw/sSkCq HiX6/yrVkkkANXWBwTfpB1I+8atUPQQzQmoHJhfsUkMZWp8Dfe3dgNtZqD84Iu33NsTb 1btw== X-Gm-Message-State: AO0yUKXjk7POaMe/y5/qnEAx7JSyWFO0Pl5IpTPGBBO0Qw1qIrcDWueG woRLBXb4VnCydcwLmCmD9Ub5qg== X-Google-Smtp-Source: AK7set+3+ztKUDCKlgPVjR+GgF5ntUTYGyYRvo//VfdzWE0w1Fddd6HXGe9FrQc6VumDHMX9cCqrwQ== X-Received: by 2002:a5d:62cb:0:b0:2bf:bdbd:25c0 with SMTP id o11-20020a5d62cb000000b002bfbdbd25c0mr18271625wrv.15.1675184238576; Tue, 31 Jan 2023 08:57:18 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i6-20020adff306000000b002425be3c9e2sm15364628wro.60.2023.01.31.08.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 08:57:18 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 17:57:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] dt-bindings: mmc: Add cap-aggressive-pm property Content-Language: en-US To: Hermes Zhang , Ulf Hansson , Rob Herring , Krzysztof Kozlowski Cc: kernel@axis.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230129023630.830764-1-chenhuiz@axis.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/2023 07:54, Hermes Zhang wrote: > On 2023/1/29 18:58, Krzysztof Kozlowski wrote: >> On 29/01/2023 03:36, Hermes Zhang wrote: >>> This commit add a new property: cap-aggressive-pm to enable the >> Do not use "This commit/patch". >> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Done > >>> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving. >> Why this is a property suitable for DT? IOW, why this isn't enabled always? > > This property will benfit for the power consumption, but it also may > degradation in performance as it will prevent the > > the card from executing internal house-keeping operations in idle mode. > So it's better to config it from DT. Why? DT is not for policy. How you described it, this is policy or system tuning choice thus the job for Linux (OS), not for DT. So I will repeat - why this property fits the purpose of DT (describe the hardware). Best regards, Krzysztof