From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E08C4363A for ; Fri, 30 Oct 2020 02:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55A372076E for ; Fri, 30 Oct 2020 02:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725841AbgJ3Chi (ORCPT ); Thu, 29 Oct 2020 22:37:38 -0400 Received: from mail-sz.amlogic.com ([211.162.65.117]:9143 "EHLO mail-sz.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgJ3Chi (ORCPT ); Thu, 29 Oct 2020 22:37:38 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Thu, 29 Oct 2020 22:37:37 EDT Received: from [10.28.39.46] (10.28.39.46) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 30 Oct 2020 10:22:31 +0800 Subject: Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments To: Sergei Antonov , CC: , , References: <20201028094940.11765-1-saproj@gmail.com> From: Liang Yang Message-ID: Date: Fri, 30 Oct 2020 10:22:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201028094940.11765-1-saproj@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.28.39.46] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Sergei, miquel On 2020/10/28 17:49, Sergei Antonov wrote: > Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up. > > Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Cc: stable@vger.kernel.org > Signed-off-by: Sergei Antonov > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 48e6dac96be6..a76afea6ea77 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf, > } > > static void meson_nfc_dma_buffer_release(struct nand_chip *nand, > - int infolen, int datalen, > + int datalen, int infolen, > enum dma_data_direction dir) > { > struct meson_nfc *nfc = nand_get_controller_data(nand); It is good to me: Acked-by: Liang Yang and thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9C7C4363A for ; Fri, 30 Oct 2020 02:24:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C54020756 for ; Fri, 30 Oct 2020 02:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IbIwy6Y+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C54020756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IJB38x2JGsXCuMQ3rr5QtAkwk1Tjij6IE6f6lbr57q0=; b=IbIwy6Y+lslvlic54HF3LmnVS xpKj/Gxm3KOLUWq/KwbdDIN/5vtCVIT/qdj8NKf5NIWCSZ3HZ1DVGfoxcXZlIlWb/qG46GVa4DGon VwAvZk6P3R/HVI/ukL1kFMFKU2pZTWUTzIh1MpZDGFxffrgj+ImMYowzEz3FY3U7msaTuet/svCwc 3VRVmfy6J1jgzffiZdf3tQM0xNm82KE+r8t5jPhLFpVNYlU4rr63cbRWFVeMmqeIhrPNVu6R0ttpB XhXpGWcxoA/hzw+J99/5g4ZwwaHcYVHAsxgXbplbcHkcCr6nWJ1pqKvgUDLi/Xvg6I5JkJermaSCS tQOOaoyAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYK3x-0006GR-HO; Fri, 30 Oct 2020 02:22:45 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYK3v-0006G3-G4 for linux-mtd@lists.infradead.org; Fri, 30 Oct 2020 02:22:44 +0000 Received: from [10.28.39.46] (10.28.39.46) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 30 Oct 2020 10:22:31 +0800 Subject: Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments To: Sergei Antonov , References: <20201028094940.11765-1-saproj@gmail.com> From: Liang Yang Message-ID: Date: Fri, 30 Oct 2020 10:22:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201028094940.11765-1-saproj@gmail.com> Content-Language: en-US X-Originating-IP: [10.28.39.46] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_222243_553574_D808A119 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, jianxin.pan@amlogic.com, miquel.raynal@bootlin.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Sergei, miquel On 2020/10/28 17:49, Sergei Antonov wrote: > Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up. > > Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Cc: stable@vger.kernel.org > Signed-off-by: Sergei Antonov > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 48e6dac96be6..a76afea6ea77 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf, > } > > static void meson_nfc_dma_buffer_release(struct nand_chip *nand, > - int infolen, int datalen, > + int datalen, int infolen, > enum dma_data_direction dir) > { > struct meson_nfc *nfc = nand_get_controller_data(nand); It is good to me: Acked-by: Liang Yang and thanks. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/