From: Ankur Arora <ankur.a.arora@oracle.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen
Date: Wed, 22 Mar 2017 10:56:02 -0700 [thread overview]
Message-ID: <a1f0404e-899e-8d56-ef65-858dacecb62d@oracle.com> (raw)
In-Reply-To: <20170322090541.GA2860@redhat.com>
On 2017-03-22 02:05 AM, Stanislaw Gruszka wrote:
> On Tue, Mar 21, 2017 at 03:43:38PM -0700, Ankur Arora wrote:
>> This was broken in commit cd979883b9ede90643e019f33cb317933eb867b4.
>> do_suspend (from xen/manage.c) and thus xen_resume_notifier never get
>> called on the initial-domain at resume (it is if running as guest.)
>>
>> The rationale for the breaking change was that upload_pm_data()
>> potentially does blocking work in syscore_resume(). This patch
>> addresses the original issue by scheduling upload_pm_data() to
>> execute in workqueue context.
>
> It is ok to do upload_pm_data() with delay i.e. after some other
> resume actions are done and possibly xen-acpi-processor is in
> running state ?
The state uploaded is ACPI P and C state from struct acpi_processor
which AFAICS is stable once inited so a delay would not lead to
invalid state.
The only concern would be the ACPI pCPU hotplug logic in
acpi_processor_add() which could add a new entry in
per_cpu(processors) but that also looks okay because either we
get a NULL or we get a pointer to an inited structure.
As for the hypervisor -- that falls back to more limited state after
resume (because some of this state is thrown away at suspend) and so
uses that until it gets the uploaded PM state from the initial-domain.
Ankur
>
> Stanislaw
>
next prev parent reply other threads:[~2017-03-22 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 22:43 [PATCH 0/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora
2017-03-21 22:43 ` Ankur Arora
2017-03-21 22:43 ` [PATCH 1/2 v2] xen/acpi: Replace hard coded "ACPI0007" Ankur Arora
2017-03-21 22:43 ` Ankur Arora
2017-03-21 22:43 ` [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora
2017-03-21 22:43 ` Ankur Arora
2017-03-22 9:05 ` Stanislaw Gruszka
2017-03-22 9:05 ` Stanislaw Gruszka
2017-03-22 17:56 ` Ankur Arora
2017-03-22 17:56 ` Ankur Arora [this message]
2017-03-23 13:12 ` Stanislaw Gruszka
2017-03-23 13:12 ` Stanislaw Gruszka
2017-03-23 16:45 ` [PATCH 0/2 " Boris Ostrovsky
2017-03-23 16:45 ` [Xen-devel] " Boris Ostrovsky
2017-03-24 14:09 ` Konrad Rzeszutek Wilk
2017-03-24 14:09 ` [Xen-devel] " Konrad Rzeszutek Wilk
[not found] <1490136167-3753-1-git-send-email-ankur.a.arora@oracle.com>
2017-03-21 22:42 ` [PATCH 2/2 " Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f0404e-899e-8d56-ef65-858dacecb62d@oracle.com \
--to=ankur.a.arora@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.