All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: mac80211 spam and deadlock on OpenWrt
Date: Mon, 25 May 2020 09:14:06 -0700	[thread overview]
Message-ID: <a1fa1a38-4985-6311-fd06-8353ef7275ff@candelatech.com> (raw)
In-Reply-To: <83abd321a059b4bed470775333f3dbc598661c68.camel@sipsolutions.net>



On 05/25/2020 02:25 AM, Johannes Berg wrote:
> On Wed, 2020-05-13 at 06:56 -0700, Ben Greear wrote:
>> Hello,
>>
>> I've been running some stress tests against OpenWrt APs.  My AP partially died yesterday
>> during a test and did not recover.  It looks like firmware became non responsive,
>> but then it could not recover due to what I think is bugs I fixed long ago in
>> the kernel that I normally use.  The OpenWrt image is using my ath10k-ct driver and firmware,
>> but stock OpenWrt kernel/mac80211 as far as I know.
>>
>> I think there are several issues:
>>
>> 1)  The WARN-ON about check-sdata-in-driver should be a warn-on-once.  Spamming serial
>>    console logs like this is both very slow and also useless for debugging.
>>
>> I posted a patch with this title some time back to mitigate this problem:
>> "mac80211: Don't spam kernel with sdata-in-driver failures."
>>
>> 2)  I suspect that the ensuing lockup may be fixed by this patch I posted
>> back in 12/1/2016:
>> "mac80211:  do not iterate active interfaces when in re-configure"
>>
>> I have been running both of those patches since posting them to the list, so they have good
>> soak time in some strenuous wifi usage cases.
>
> Huh, these are kinda old I guess.
>
> Can you repost them?

For the warning log-spam, you could grab patch 3 and 4 from this series I posted late last year:

[PATCH 00/10] Ben's grab bag of mac80211 patches

I think patch 5 in there is also nice to have, we passed email about it, but not sure it ever
made it upstream.

I'll dig out the 'iterate active' patch and post it stand-alone.

Thanks,
Ben

>
> johannes
>

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

      reply	other threads:[~2020-05-25 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 13:56 mac80211 spam and deadlock on OpenWrt Ben Greear
2020-05-25  9:25 ` Johannes Berg
2020-05-25 16:14   ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1fa1a38-4985-6311-fd06-8353ef7275ff@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.