All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: exynos4-is: Fix compile warning
       [not found] <CGME20220420045732epcms1p7bdaf82873a4328153b456ee4e3a5660a@epcms1p4>
@ 2022-04-20  5:11 ` Kwanghoon Son
  2022-04-20  6:31   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Kwanghoon Son @ 2022-04-20  5:11 UTC (permalink / raw)
  To: Sylwester Nawrocki, mchehab, krzysztof.kozlowski, ALIM AKHTAR
  Cc: linux-media, linux-samsung-soc

declare 'static' to fix warning message from
https://lore.kernel.org/linux-media/202204192315.ZHbOex51-lkp@intel.com/T/#u

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kwang Son <k.son@samsung.com>
---
 drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
index edcb3a5e3cb9..2dd4ddbc748a 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
@@ -32,7 +32,7 @@ static inline int fimc_isp_video_device_register(struct fimc_isp *isp,
 	return 0;
 }
 
-void fimc_isp_video_device_unregister(struct fimc_isp *isp,
+static inline void fimc_isp_video_device_unregister(struct fimc_isp *isp,
 				enum v4l2_buf_type type)
 {
 }
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: exynos4-is: Fix compile warning
  2022-04-20  5:11 ` [PATCH] media: exynos4-is: Fix compile warning Kwanghoon Son
@ 2022-04-20  6:31   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-20  6:31 UTC (permalink / raw)
  To: k.son, Sylwester Nawrocki, mchehab, ALIM AKHTAR
  Cc: linux-media, linux-samsung-soc

Hi,

You sent three almost the same patches, so how can we know which one to
choose? Please use versioning of the patches (git help format-patch).

On 20/04/2022 07:11, Kwanghoon Son wrote:
> declare 'static' to fix warning message from
> https://lore.kernel.org/linux-media/202204192315.ZHbOex51-lkp@intel.com/T/#u

No external references, instead quote trimmed warning message (only the
relevant part).

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kwang Son <k.son@samsung.com>

Name used here does not match name used for commit, so please fix your
setup.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] media: exynos4-is: Fix compile warning
       [not found] <CGME20220420045732epcms1p7bdaf82873a4328153b456ee4e3a5660a@epcms1p2>
@ 2022-04-20  5:07 ` Kwanghoon Son
  0 siblings, 0 replies; 3+ messages in thread
From: Kwanghoon Son @ 2022-04-20  5:07 UTC (permalink / raw)
  To: Sylwester Nawrocki, mchehab, krzysztof.kozlowski, ALIM AKHTAR
  Cc: linux-media, linux-samsung-soc

declare 'static' to fix warning message from
https://lore.kernel.org/linux-media/202204192315.ZHbOex51-lkp@intel.com/T/#u
 
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kwanghoon Son <k.son@samsung.com>
---
 drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
index edcb3a5e3cb9..2dd4ddbc748a 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
@@ -32,7 +32,7 @@ static inline int fimc_isp_video_device_register(struct fimc_isp *isp,
         return 0;
 }
 
-void fimc_isp_video_device_unregister(struct fimc_isp *isp,
+static inline void fimc_isp_video_device_unregister(struct fimc_isp *isp,
                                 enum v4l2_buf_type type)
 {
 }
-- 
2.20.1
 
 
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-20  6:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20220420045732epcms1p7bdaf82873a4328153b456ee4e3a5660a@epcms1p4>
2022-04-20  5:11 ` [PATCH] media: exynos4-is: Fix compile warning Kwanghoon Son
2022-04-20  6:31   ` Krzysztof Kozlowski
     [not found] <CGME20220420045732epcms1p7bdaf82873a4328153b456ee4e3a5660a@epcms1p2>
2022-04-20  5:07 ` Kwanghoon Son

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.