From: Ben Dooks <ben.dooks@codethink.co.uk> To: Akira Tsukamoto <akira.tsukamoto@gmail.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/5] riscv: improving uaccess with logs from network bench Date: Tue, 22 Jun 2021 18:45:37 +0100 [thread overview] Message-ID: <a222f892-a2bc-c531-d17e-3ec2c8708fcd@codethink.co.uk> (raw) In-Reply-To: <f54ec904-2bf5-0c29-d467-7465993d5d6b@gmail.com> On 22/06/2021 13:05, Akira Tsukamoto wrote: > On 6/22/2021 5:30 PM, Ben Dooks wrote: >> On 19/06/2021 12:21, Akira Tsukamoto wrote: >>> Optimizing copy_to_user and copy_from_user. >>> >>> I rewrote the functions in v2, heavily influenced by Garry's memcpy >>> function [1]. >>> The functions must be written in assembler to handle page faults manually >>> inside the function. >>> >>> With the changes, improves in the percentage usage and some performance >>> of network speed in UDP packets. >>> Only patching copy_user. Using the original memcpy. >>> >>> All results are from the same base kernel, same rootfs and same >>> BeagleV beta board. >>> >>> Comparison by "perf top -Ue task-clock" while running iperf3. >> >> I did a quick test on a SiFive Unmatched with IO to an NVME. >> >> before: cached-reads=172.47MB/sec, buffered-reads=135.8MB/sec >> with-patch: cached-read=s177.54Mb/sec, buffered-reads=137.79MB/sec >> >> That was just one test run, so there was a small improvement. I am >> sort of surprised we didn't get more of a win from this. >> >> perf record on hdparm shows that it spends approx 15% cpu time in >> asm_copy_to_user. Does anyone have a benchmark for this which just >> looks at copy/to user? if not should we create one? > > Thanks for the result on the Unmatched with hdparm. Have you tried > iperf3? I will see if there is iperf3 installed. I've not done much other than try booting it and then try booting it with a kernel i've built from upstream. > The 15% is high, is it before or with-patch? Can't remember, I did this more to find out if the copy to/from user was going to show up in the times for hdparm. > Akira > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk> To: Akira Tsukamoto <akira.tsukamoto@gmail.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/5] riscv: improving uaccess with logs from network bench Date: Tue, 22 Jun 2021 18:45:37 +0100 [thread overview] Message-ID: <a222f892-a2bc-c531-d17e-3ec2c8708fcd@codethink.co.uk> (raw) In-Reply-To: <f54ec904-2bf5-0c29-d467-7465993d5d6b@gmail.com> On 22/06/2021 13:05, Akira Tsukamoto wrote: > On 6/22/2021 5:30 PM, Ben Dooks wrote: >> On 19/06/2021 12:21, Akira Tsukamoto wrote: >>> Optimizing copy_to_user and copy_from_user. >>> >>> I rewrote the functions in v2, heavily influenced by Garry's memcpy >>> function [1]. >>> The functions must be written in assembler to handle page faults manually >>> inside the function. >>> >>> With the changes, improves in the percentage usage and some performance >>> of network speed in UDP packets. >>> Only patching copy_user. Using the original memcpy. >>> >>> All results are from the same base kernel, same rootfs and same >>> BeagleV beta board. >>> >>> Comparison by "perf top -Ue task-clock" while running iperf3. >> >> I did a quick test on a SiFive Unmatched with IO to an NVME. >> >> before: cached-reads=172.47MB/sec, buffered-reads=135.8MB/sec >> with-patch: cached-read=s177.54Mb/sec, buffered-reads=137.79MB/sec >> >> That was just one test run, so there was a small improvement. I am >> sort of surprised we didn't get more of a win from this. >> >> perf record on hdparm shows that it spends approx 15% cpu time in >> asm_copy_to_user. Does anyone have a benchmark for this which just >> looks at copy/to user? if not should we create one? > > Thanks for the result on the Unmatched with hdparm. Have you tried > iperf3? I will see if there is iperf3 installed. I've not done much other than try booting it and then try booting it with a kernel i've built from upstream. > The 15% is high, is it before or with-patch? Can't remember, I did this more to find out if the copy to/from user was going to show up in the times for hdparm. > Akira > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-06-22 17:46 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-19 11:21 [PATCH v2 0/5] riscv: improving uaccess with logs from network bench Akira Tsukamoto 2021-06-19 11:21 ` Akira Tsukamoto 2021-06-19 11:34 ` [PATCH 1/5] riscv: __asm_to/copy_from_user: delete existing code Akira Tsukamoto 2021-06-19 11:34 ` Akira Tsukamoto 2021-06-21 11:45 ` David Laight 2021-06-21 11:45 ` David Laight 2021-06-21 13:55 ` Akira Tsukamoto 2021-06-21 13:55 ` Akira Tsukamoto 2021-06-19 11:35 ` [PATCH 2/5] riscv: __asm_to/copy_from_user: Adding byte copy first Akira Tsukamoto 2021-06-19 11:35 ` Akira Tsukamoto 2021-06-19 11:36 ` [PATCH 3/5] riscv: __asm_to/copy_from_user: Copy until dst is aligned Akira Tsukamoto 2021-06-19 11:36 ` Akira Tsukamoto 2021-06-19 11:37 ` [PATCH 4/5] riscv: __asm_to/copy_from_user: Bulk copy while shifting Akira Tsukamoto 2021-06-19 11:37 ` Akira Tsukamoto 2021-06-19 11:43 ` [PATCH 5/5] riscv: __asm_to/copy_from_user: Bulk copy when both src, dst are aligned Akira Tsukamoto 2021-06-19 11:43 ` Akira Tsukamoto 2021-06-21 11:55 ` David Laight 2021-06-21 11:55 ` David Laight 2021-06-21 14:13 ` Akira Tsukamoto 2021-06-21 14:13 ` Akira Tsukamoto 2021-06-20 10:02 ` [PATCH v2 0/5] riscv: improving uaccess with logs from network bench Ben Dooks 2021-06-20 10:02 ` Ben Dooks 2021-06-20 16:36 ` Akira Tsukamoto 2021-06-20 16:36 ` Akira Tsukamoto 2021-06-22 8:30 ` Ben Dooks 2021-06-22 8:30 ` Ben Dooks 2021-06-22 12:05 ` Akira Tsukamoto 2021-06-22 12:05 ` Akira Tsukamoto 2021-06-22 17:45 ` Ben Dooks [this message] 2021-06-22 17:45 ` Ben Dooks 2021-07-12 21:24 ` Ben Dooks 2021-07-12 21:24 ` Ben Dooks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a222f892-a2bc-c531-d17e-3ec2c8708fcd@codethink.co.uk \ --to=ben.dooks@codethink.co.uk \ --cc=akira.tsukamoto@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.