Re: cron job: media_tree daily build: WARNINGS

[Hans Verkuil <hverkuil-cisco@xs4all.nl>]

On 04/10/2023 03:46, Hans Verkuil wrote:
> This message is generated daily by a cron job that builds media_tree for
> the architectures in the list below.
> 
> Results of the daily build of media_tree:
> 
> date:			Wed Oct  4 03:00:08 CEST 2023
> media-tree git repo:	git://linuxtv.org/hverkuil/media_tree.git
> media-tree git branch:	media_stage/master
> media-tree git hash:	d39216ece42e5d4b0150e0b414fd69e52ae90857
> v4l-utils git hash:	99c4f6dd80613c7bd1fe02bd34492bbd4c999fea
> edid-decode git hash:	e59b8a2ffd690d6576639365a67e890d91ca443d
> gcc version:		i686-linux-gcc (GCC) 13.2.0
> ccache version:		ccache version 4.8.3
> smatch/sparse repo:     git://repo.or.cz/smatch.git
> smatch version:		v0.5.0-8471-g6f3cce86
> sparse version:		v0.5.0-8471-g6f3cce86
> build-scripts repo:     https://git.linuxtv.org/hverkuil/build-scripts.git
> build-scripts git hash: ce72105881befed252121ffc203e7c155e655c05
> host hardware:		x86_64
> host os:		6.5.0-1-amd64
> 
> linux-git-arm: OK
> linux-git-powerpc64: OK
> linux-git-arm64: OK
> linux-git-i686: OK
> linux-git-x86_64: OK
> no-acpi.config: OK
> no-of.config: OK
> no-pm.config: OK
> no-pm-sleep.config: OK
> no-debug-fs.config: OK
> sparse: WARNINGS:
> 
> drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
> 
> smatch: WARNINGS:
> 
> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:446 gc0310_s_stream() warn: missing error code 'ret'
> drivers/media/common/siano/smscoreapi.c:650 smscore_register_device() warn: use 'gfp_buf_flags' here instead of GFP_KERNEL?
> drivers/media/common/siano/smscoreapi.c:689 smscore_register_device() warn: use 'gfp_buf_flags' here instead of GFP_KERNEL?
> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1412 __s5c73m3_power_off() warn: 'state->clock' from clk_prepare_enable() not released on lines: 1412.
> drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
> drivers/staging/media/atomisp/pci/atomisp_cmd.c:2779 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
> drivers/staging/media/atomisp/pci/atomisp_cmd.c:2878 atomisp_cp_morph_table() warn: missing unwind goto?
> drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
>   Locked on  : 326,387
>   Unlocked on: 465,467
> drivers/media/i2c/ar0521.c:913 ar0521_power_on() warn: 'sensor->extclk' from clk_prepare_enable() not released on lines: 913.
> drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2792 mxc_jpeg_probe() warn: missing unwind goto?
> drivers/media/platform/qcom/venus/pm_helpers.c:873 vcodec_domains_get() warn: passing zero to 'PTR_ERR'
> drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
> drivers/media/pci/mgb4/mgb4_sysfs_out.c:118 video_source_store() warn: potential spectre issue 'mgbdev->vin' [r] (local cap)
> drivers/media/pci/mgb4/mgb4_sysfs_out.c:122 video_source_store() warn: possible spectre second half.  'loopin_new'
> drivers/media/i2c/tc358746.c:790 tc358746_set_fmt() error: 'fmt' dereferencing possible ERR_PTR()
> drivers/media/i2c/tc358746.c:1624 tc358746_suspend() warn: 'tc358746->refclk' from clk_prepare_enable() not released on lines: 1624.
> drivers/staging/media/ipu3/ipu3-dmamap.c:42 imgu_dmamap_alloc_buffer() warn: use 'gfp' here instead of GFP_KERNEL?

The reason for these new warnings is that it turned out that the build
script was missing a crucial smatch option. After enabling that, I now get
new warnings.

Regards,

	Hans

> 
> COMPILE_TEST: OK
> strcpy/strncpy/strlcpy: OK
> abi-compliance: ABI OK
> pahole: ABI OK
> utils: OK
> spec-git: OK
> kerneldoc: OK
> 
> date:			Wed Oct  4 03:17:14 CEST 2023
> virtme: WARNINGS: Final Summary: 3080, Succeeded: 3080, Failed: 0, Warnings: 3
> virtme-32: WARNINGS: Final Summary: 3193, Succeeded: 3193, Failed: 0, Warnings: 2
> 
> date:			Wed Oct  4 03:44:45 CEST 2023
> 
> Detailed results are available here:
> 
> https://hverkuil.home.xs4all.nl/logs/Wednesday.log
> 
> Detailed regression test results are available here:
> 
> https://hverkuil.home.xs4all.nl/logs/Wednesday-test-media.log
> https://hverkuil.home.xs4all.nl/logs/Wednesday-test-media-dmesg.log
> https://hverkuil.home.xs4all.nl/logs/Wednesday-test-media-32.log
> https://hverkuil.home.xs4all.nl/logs/Wednesday-test-media-32-dmesg.log
> 
> Full logs are available here:
> 
> https://hverkuil.home.xs4all.nl/logs/Wednesday.tar.bz2
> 
> The Media Infrastructure API from this daily build is here:
> 
> https://hverkuil.home.xs4all.nl/spec/index.html