From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B91C433E1 for ; Wed, 13 May 2020 19:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8358A206CC for ; Wed, 13 May 2020 19:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="LatWmSXj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390783AbgEMTlK (ORCPT ); Wed, 13 May 2020 15:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390674AbgEMTlK (ORCPT ); Wed, 13 May 2020 15:41:10 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10489C061A0E for ; Wed, 13 May 2020 12:41:10 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id l11so988974wru.0 for ; Wed, 13 May 2020 12:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=m9izSOZDzA62EkVIVJaM9RQB78HtwGR7Vc4fH0Cr3MY=; b=LatWmSXjR+eXddCxx4Fpk4fo9igRHLhD0wdivRc/eNsLlnnZs5nWsT8gJG8meyHtw4 UUQkcffYPMX4wdRgrMtJsNtJX3jUTj4ye3jBgUQduaGLLcqEOsJSw4CXVNHD0b8AxF3i nGGoOxnAcHym+F6QKUhTXu1sRVeypKEn8nPbQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=m9izSOZDzA62EkVIVJaM9RQB78HtwGR7Vc4fH0Cr3MY=; b=dkrN7DmR+KK9i6RVEYy3JGDEheGBME8H0Q9x2sdNwE+LnsDeYmXIda/Pb0u7bK2KRj wf4z/NttZcKNj637w4gmqk5QPebW0TDjXxceMS38HaVbDxjxVc5AoRJCpRxH290ge8jc IZeyvhPL3EUP3UunhxA3J1f0Ch+OXJMb23lu9tHU0HRIx8yJulziaO/IDw+o4cBIau/t bA8KRF2hPs1PZl7msuN5nI1OGmQXDdkgYcWx6G/ihrwP0lABwZCtaxa6XgyIxbU/02wA uShN9EfihsNuHQJxtzpyei1SZiryYEmguO53SQ/5xY0R6fvv6IAgaMmjL2C8xTDdsyMT S8Pg== X-Gm-Message-State: AOAM531ZUQMTTLHAeHZZt5IxgnI1cq+dQ6hxo2x+tq1KeuQhe3CXCtul 7b35U/YquRowg3TVpAZeyvfX9g== X-Google-Smtp-Source: ABdhPJwAFFVlJnMtr4CXEiXONgk4Jd3OlSsLP62BuGb86vDdhyyIRrvNuimetMcYerb/TfC75/UB2g== X-Received: by 2002:a5d:4950:: with SMTP id r16mr1048168wrs.350.1589398868576; Wed, 13 May 2020 12:41:08 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id n9sm15165510wmj.5.2020.05.13.12.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 12:41:07 -0700 (PDT) Subject: Re: [PATCH v5 1/7] fs: introduce kernel_pread_file* support To: Mimi Zohar , Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann Cc: "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-security-module , linux-integrity References: <20200508002739.19360-1-scott.branden@broadcom.com> <20200508002739.19360-2-scott.branden@broadcom.com> <1589395153.5098.158.camel@kernel.org> <0e6b5f65-8c61-b02e-7d35-b4ae52aebcf3@broadcom.com> <1589396593.5098.166.camel@kernel.org> <1589398747.5098.178.camel@kernel.org> From: Scott Branden Message-ID: Date: Wed, 13 May 2020 12:41:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1589398747.5098.178.camel@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-05-13 12:39 p.m., Mimi Zohar wrote: > On Wed, 2020-05-13 at 12:18 -0700, Scott Branden wrote: >> On 2020-05-13 12:03 p.m., Mimi Zohar wrote: >>> On Wed, 2020-05-13 at 11:53 -0700, Scott Branden wrote: >> Even if the kernel successfully verified the firmware file signature it >> would just be wasting its time.  The kernel in these use cases is not always >> trusted.  The device needs to authenticate the firmware image itself. > There are also environments where the kernel is trusted and limits the > firmware being provided to the device to one which they signed. > >>> The device firmware is being downloaded piecemeal from somewhere and >>> won't be measured? >> It doesn't need to be measured for current driver needs. > Sure the device doesn't need the kernel measuring the firmware, but > hardened environments do measure firmware. > >> If someone has such need the infrastructure could be added to the kernel >> at a later date.  Existing functionality is not broken in any way by >> this patch series. > Wow!  You're saying that your patch set takes precedence over the > existing expectations and can break them. Huh? I said existing functionality is NOT broken by this patch series. > > Mimi