From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2108DC433DB for ; Wed, 10 Feb 2021 02:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFDC564DE7 for ; Wed, 10 Feb 2021 02:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234198AbhBJCWZ (ORCPT ); Tue, 9 Feb 2021 21:22:25 -0500 Received: from 3.mo6.mail-out.ovh.net ([178.33.253.26]:43005 "EHLO 3.mo6.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233610AbhBJCVZ (ORCPT ); Tue, 9 Feb 2021 21:21:25 -0500 Received: from player774.ha.ovh.net (unknown [10.109.143.220]) by mo6.mail-out.ovh.net (Postfix) with ESMTP id 5674F240356 for ; Tue, 9 Feb 2021 23:07:23 +0100 (CET) Received: from milecki.pl (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player774.ha.ovh.net (Postfix) with ESMTPSA id 72B011AFB9FE1; Tue, 9 Feb 2021 22:07:12 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-98R00214cc0512-b6f7-4d99-9498-2d40eb3402b0, ECAF73ED9022E26008F51CC3B8E5D9CA72646693) smtp.auth=rafal@milecki.pl X-OVh-ClientIp: 194.187.74.233 Subject: Re: [PATCH V2 net-next 1/2] dt-bindings: net: document BCM4908 Ethernet controller To: Rob Herring , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: "David S . Miller" , Jakub Kicinski , Florian Fainelli , Randy Dunlap , Masahiro Yamada , netdev@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <20210205214417.11178-1-zajec5@gmail.com> <20210207222632.10981-1-zajec5@gmail.com> <20210209214345.GA244143@robh.at.kernel.org> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: Date: Tue, 9 Feb 2021 23:07:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210209214345.GA244143@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 548031780550512271 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrheehgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomheptfgrfhgrlhcuofhilhgvtghkihcuoehrrghfrghlsehmihhlvggtkhhirdhplheqnecuggftrfgrthhtvghrnhepffefgefhhfehjeetfeetkefgkeehleeghefgtddthefhgfffhfduieetjeffveegnecuffhomhgrihhnpeguvghvihgtvghtrhgvvgdrohhrghenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeejgedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehrrghfrghlsehmihhlvggtkhhirdhplhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09.02.2021 22:43, Rob Herring wrote: > On Sun, Feb 07, 2021 at 11:26:31PM +0100, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> BCM4908 is a family of SoCs with integrated Ethernet controller. >> >> Signed-off-by: Rafał Miłecki >> --- >> .../bindings/net/brcm,bcm4908enet.yaml | 45 +++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml b/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml >> new file mode 100644 >> index 000000000000..5f12f51c5b19 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/brcm,bcm4908enet.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/brcm,bcm4908enet.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Broadcom BCM4908 Ethernet controller >> + >> +description: Broadcom's Ethernet controller integrated into BCM4908 family SoCs >> + >> +maintainers: >> + - Rafał Miłecki >> + > > allOf: > - $ref: 'ethernet-controller.yaml#' Thanks! >> +properties: >> + compatible: >> + const: brcm,bcm4908enet > > Normal convention is 'brcm,bcm4908-enet'. (And update the filename/$id) Is it? ;) It seems we have: brcm,bcmgenet (not brcm,bcmg-enet) fsl-enetc (not e.g. fsl-enet-c) xilinx_axienet (not xilinx_axi-enet) apm,xgene1-sgenet (not apm,xgene1-sg-enet) Of course, as you seem to prefer *-enet, I'll make it so! V3 soon. >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + description: RX interrupt >> + >> + interrupt-names: >> + const: rx > > Don't really need *-names when only 1 possible entry. I think this controller may have some more interrupts (I don't know about). We can "interrupt-names" later, when we find them out.