All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Kees Cook <keescook@chromium.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,  linux-media@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH v2 09/20] media: si470x: fix printk warnings with clang
Date: Mon, 29 Nov 2021 02:10:14 -0800	[thread overview]
Message-ID: <a22c082a661df0b548511f282fcc519a11bb3340.camel@perches.com> (raw)
In-Reply-To: <442df11dd08158df88e95a457175a65f20dc8369.1638179135.git.mchehab+huawei@kernel.org>

On Mon, 2021-11-29 at 10:47 +0100, Mauro Carvalho Chehab wrote:
> Clang doesn't like "%hu" on macros:
> 
> 	drivers/media/radio/si470x/radio-si470x-i2c.c:414:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
> 	drivers/media/radio/si470x/radio-si470x-i2c.c:417:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
> 
> Besides that, changeset cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
> dropped recomendation of using %h.
> 
> So, just replace them with "%u".

And perhaps change these to single dev_warn calls instead of multiple calls.

> diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
[]
> @@ -410,10 +410,10 @@ static int si470x_i2c_probe(struct i2c_client *client)
>  			radio->registers[DEVICEID], radio->registers[SI_CHIPID]);
>  	if ((radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE) < RADIO_FW_VERSION) {
>  		dev_warn(&client->dev,
> -			"This driver is known to work with firmware version %hu,\n",
> +			"This driver is known to work with firmware version %u,\n",
>  			RADIO_FW_VERSION);
>  		dev_warn(&client->dev,
> -			"but the device has firmware version %hu.\n",
> +			"but the device has firmware version %u.\n",
>  			radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);

		dev_warn(&client->dev,
			"This driver is known to work with firmware version %u, but the device has firmware version %u\n",
			RADIO_FW_VERSION, radio->registers[SI_CHIPID] & SI_CHIPID_FIRMWARE);

etc...



  reply	other threads:[~2021-11-29 10:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  9:47 [PATCH v2 00/20] Solve the remaining issues with clang and W=1 on media Mauro Carvalho Chehab
2021-11-29  9:47 ` Mauro Carvalho Chehab
2021-11-29  9:47 ` Mauro Carvalho Chehab
2021-11-29  9:47 ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 01/20] media: adv7842: get rid of two unused functions Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 02/20] media: saa7134-go7007: get rid of to_state() function Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 03/20] media: davinci: get rid of an unused function Mauro Carvalho Chehab
2021-11-29 10:18   ` Lad, Prabhakar
2021-11-29  9:47 ` [PATCH v2 04/20] media: drxd: drop offset var from DownloadMicrocode() Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 05/20] media: drxk: drop operation_mode from set_dvbt() Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 06/20] media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk() Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 07/20] media: si21xx: report eventual errors at set_frontend Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 08/20] media: solo6x10: mark unused functions as such Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 09/20] media: si470x: fix printk warnings with clang Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29 10:10   ` Joe Perches [this message]
2021-11-29 11:40     ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 10/20] media: radio-si476x: drop a container_of() abstraction macro Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 11/20] media: lmedm04: don't ignore errors when setting a filter Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 12/20] media: au0828-i2c: drop a duplicated function Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 13/20] media: adv7604: mark unused functions as such Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 14/20] media: adv7511: drop unused functions Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 15/20] media: imx290: mark read reg function as __always_unused Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-12-02 14:59   ` Manivannan Sadhasivam
2021-11-29  9:47 ` [PATCH v2 16/20] media: davinci: vpbe_osd: " Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29 10:19   ` Lad, Prabhakar
2021-11-29  9:47 ` [PATCH v2 17/20] media: camss: Remove unused static function Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 18/20] media: mtk-mdp: address a clang warning Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 19/20] media: cobalt: drop an unused variable Mauro Carvalho Chehab
2021-11-29  9:47 ` [PATCH v2 20/20] media: mxl5005s: drop some dead code Mauro Carvalho Chehab
2021-11-29  9:47   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a22c082a661df0b548511f282fcc519a11bb3340.camel@perches.com \
    --to=joe@perches.com \
    --cc=hverkuil@xs4all.nl \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=llvm@lists.linux.dev \
    --cc=mauro.chehab@huawei.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.