From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6425059163; Fri, 22 Mar 2024 15:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711122558; cv=none; b=r8wCUjkcofAmtv7tiB312z3KVbXLT+SfIYadY7Auz2HWkzYFTwchzuSxRaKNpwh2SAr5hVJdJUyUIgoLDn6U2ivEMsNc+KfL8j+cfwOGczDwtH5nl+K1hJlJA/RhfsYY+ogaGIcsh+TvTnEmfDOQPNDJeoXGk15o+hy1h/XL+wY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711122558; c=relaxed/simple; bh=SH0nqNuxhZgHCsVr9BNRBW8W8DQKuuRqCpmLlgkB5Zs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JjPeN9YPiTHOip3QuRCb2HPNzHXRurYnKaa/offmmmNKx/XexUGv+tEDpAfjeXAhILPVCy+Z0rT+R0/HfMRohRyCCPbiXpN0GzWwF0nPnPIByTwzElZcvJUfgnOYFFCh1MQXtQlc8j0fEPyDX44I+iz+C5WRtnaLlL/pf31BwIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=bkVeCRkP; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="bkVeCRkP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jgLIHqFNuXkHH5HYUZp2KdJbY2+i8m+EoWOC10J0nag=; b=bkVeCRkPeYKdrjZ5+hPC7Nr9sL IfWGLwhWrYUKy+NEb/c6mBu52TNd5wQyVd9q3dVq3okHbLg90PDZriwdohrJUJC8yJAe2DsMZsqAL St+0Cj3f2QU5LvRKgSjAmGAZ8Z/pvyF0g0PGEvmLEStsbrQ0M3qPuEgjFbaMrkpOeuzA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rnh8n-00AyBo-5d; Fri, 22 Mar 2024 16:49:09 +0100 Date: Fri, 22 Mar 2024 16:49:09 +0100 From: Andrew Lunn To: Josua Mayer Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] arm64: dts: add description for solidrun cn9130 som and clearfog boards Message-ID: References: <20240321-cn9130-som-v1-0-711127a409ae@solid-run.com> <20240321-cn9130-som-v1-2-711127a409ae@solid-run.com> <0d1afbcc-948e-4aff-8296-42f7166d318d@solid-run.com> <4fff2165-c3cc-41d8-b541-6e69ce4d98ac@lunn.ch> <748753a6-9fde-4d4f-8fee-5b93dbb532f0@solid-run.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <748753a6-9fde-4d4f-8fee-5b93dbb532f0@solid-run.com> > I (currently) can't put in the led node e.g. > linux,default-trigger = "link100|link1000|tx|rx"; > Right? No. The trigger will be 'netdev'. Or 'heartbeat', or 'kbd-numlock'. They are just LEDs, they can be used for anything. While testing some of this code i had the keyboard numlock indicating network packets, since it easier to see than the RJ45 socket... The same applies the other way. The RJ45 LEDs are just Linux LEDs, they can be used for anything... I do have some code adding additional properties for the blink reason. However, it is very debatable if it belongs in DT. DT describes hardware, not configuration of hardware. Do you actually have labels on the case indicating what the LEDs mean? It could be we describe the label, which is hardware, not the configuration of the LED, which is policy from user space. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCB95C54E71 for ; Fri, 22 Mar 2024 15:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mbKLNrQda4rQhTLm4OIoJT+JclH4mPkywXNQhNj/4hY=; b=XsB7FcL6RDBl3o h1rcX/JfoKQ9hmjwDWCyXlaZfMlVdl8LsYq9nuCWfiTZ/mlgT+7JetmJbh160+3aZnbfqY9nbZ+Y6 J/3TVuN7yFeyUx13baEC2iVKu6gKSjDcJ5dJ3EyLZjRLM8NH2SWGumP3fLOVw/cctQOqShDxkzR6x cI2YthDcNMIgtcfsTX9+4vYdRvORrWHImkLK0ZkzG7lvQc9X76lO2JcIkJYcmsKF6LcqjiaEA8VFi SkSHe/iJT+2bj3rjGhD96sbNjtvudl43N896f/9idzVflpD60FW1c+M8cz6T/crBZOZ15DQlRNMmr jDfUQqvBZ5LCbkKPp4Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnh8x-00000007oh9-2EkW; Fri, 22 Mar 2024 15:49:19 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnh8u-00000007ocR-0Wzp for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 15:49:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jgLIHqFNuXkHH5HYUZp2KdJbY2+i8m+EoWOC10J0nag=; b=bkVeCRkPeYKdrjZ5+hPC7Nr9sL IfWGLwhWrYUKy+NEb/c6mBu52TNd5wQyVd9q3dVq3okHbLg90PDZriwdohrJUJC8yJAe2DsMZsqAL St+0Cj3f2QU5LvRKgSjAmGAZ8Z/pvyF0g0PGEvmLEStsbrQ0M3qPuEgjFbaMrkpOeuzA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rnh8n-00AyBo-5d; Fri, 22 Mar 2024 16:49:09 +0100 Date: Fri, 22 Mar 2024 16:49:09 +0100 From: Andrew Lunn To: Josua Mayer Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] arm64: dts: add description for solidrun cn9130 som and clearfog boards Message-ID: References: <20240321-cn9130-som-v1-0-711127a409ae@solid-run.com> <20240321-cn9130-som-v1-2-711127a409ae@solid-run.com> <0d1afbcc-948e-4aff-8296-42f7166d318d@solid-run.com> <4fff2165-c3cc-41d8-b541-6e69ce4d98ac@lunn.ch> <748753a6-9fde-4d4f-8fee-5b93dbb532f0@solid-run.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <748753a6-9fde-4d4f-8fee-5b93dbb532f0@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_084916_227410_C4289CE3 X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > I (currently) can't put in the led node e.g. > linux,default-trigger = "link100|link1000|tx|rx"; > Right? No. The trigger will be 'netdev'. Or 'heartbeat', or 'kbd-numlock'. They are just LEDs, they can be used for anything. While testing some of this code i had the keyboard numlock indicating network packets, since it easier to see than the RJ45 socket... The same applies the other way. The RJ45 LEDs are just Linux LEDs, they can be used for anything... I do have some code adding additional properties for the blink reason. However, it is very debatable if it belongs in DT. DT describes hardware, not configuration of hardware. Do you actually have labels on the case indicating what the LEDs mean? It could be we describe the label, which is hardware, not the configuration of the LED, which is policy from user space. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel