From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2DEC433F5 for ; Mon, 20 Sep 2021 11:21:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8588860F5D for ; Mon, 20 Sep 2021 11:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236686AbhITLWj (ORCPT ); Mon, 20 Sep 2021 07:22:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236497AbhITLWN (ORCPT ); Mon, 20 Sep 2021 07:22:13 -0400 Received: from lb1-smtp-cloud9.xs4all.net (lb1-smtp-cloud9.xs4all.net [IPv6:2001:888:0:108::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96F0CC061574; Mon, 20 Sep 2021 04:19:52 -0700 (PDT) Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id SHKtmv90WcSrkSHKumAXcF; Mon, 20 Sep 2021 13:19:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1632136789; bh=HXMTp7CaoqOdcgMbLwjsoBfZrna7G+6Y5/y+9DvzrT0=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=rp63vtbkq6rrVDqH/aryOXf9o74TLOEmWuv/ux+LrnA8Ii1C0cjOtSq0LBYxrkwcx L5dS5l7h71mnzM5mY9iV4Ak+lceAANt02NvXZ+E8OrBmqdvjQg+KZrl1/YQBCKTpxM IqRVWE/4LyiXweyttGmL3eyauutZLaeB9Uz8vvZGrq4GU4xAXJEX2IQ52X4Gz5POxA HjLe6uBnMzd+Sw4qRo6aRCS3RIrV/+DXPHkGBAd2WnfHGfm++/zqL6+KgXRBgqiKyB EFHiwc0OhLfYUxmhYmK/XiPMMTwAslRkPCC5uGvPWV50twzzvXF+CwnCNeD3ISlRw/ kxnjJrcRdubSg== Subject: Re: [PATCH] media: rc and cec: keep all menu entries together To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Sean Young , linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20210822000450.27329-1-rdunlap@infradead.org> From: Hans Verkuil Message-ID: Date: Mon, 20 Sep 2021 13:19:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210822000450.27329-1-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfH35zTwZa8AZtNwGL1tdd01x5+N5PMKYtMBlZ6rV/gAwdj6q15h14GrFdjhwOzLO/He5+N8A/T3tOhp/m5tHNnS94v0lRNg37mIIc95JEkPiAfnsZAgn 1KOL5hsWn9LEaMlC1leJLjNv3eL9p8FtJx0NO6V2XBpcX78OSLOqtGtz0lpFp4tZoIfnHPTFLKButi1CiBp4eVoV4yTeQ84rEsy94wsWxbN78B3qcTUMy2q0 CAwcqDlSka0MlDsCAEhu+G/M8946eHy5TO25ZspFGN9KWCOVh9OBh1XJDPutzb5G5YzgIgpfHpy7k9/8paHUaQDmAF93SnZMm7aRcUj5zgVOXPYs4Ix1sPcz bnJZ89MqlLgn2p+qRevgG2hBa4zQfwKmfNAklvoInjcFdhlRZZVgwN1XpIlyppIbO48H9DegOijC+fdFn5q99vfqHJWSsA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 22/08/2021 02:04, Randy Dunlap wrote: > Keep all of the Remote Controller and CEC menu entries grouped > together. This is most relevant to 'make xconfig', where the > entries for "HDMI CEC RC integration" and "Enable CEC error injection > support" are not displayed (presented) anywhere near the other > Remote Controller support options. > By grouping all of these menu entries inside a menu/endmenu block, > they are forced to be kept together. > > Fixes: 46d2a3b964dd ("media: place CEC menu before MEDIA_SUPPORT") > Signed-off-by: Randy Dunlap > Cc: Sean Young > Cc: Hans Verkuil > Cc: linux-media@vger.kernel.org > Cc: Mauro Carvalho Chehab > --- > drivers/media/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20210820.orig/drivers/media/Kconfig > +++ linux-next-20210820/drivers/media/Kconfig > @@ -6,8 +6,10 @@ > # > # NOTE: CEC and Remote Controller support should not depend on MEDIA_SUPPORT > # > +menu "Remote Controller and CEC support" > source "drivers/media/rc/Kconfig" > source "drivers/media/cec/Kconfig" > +endmenu Remote control and CEC really have very little to do with one another, except for "HDMI CEC RC integration", which is a feature of CEC. It would make more sense IMHO to make a "CEC support" menu and move the CEC drivers and "HDMI CEC RC integration" and "Enable CEC error injection support" to that new menu. It's a bit odd that those two CEC options are directly under the Device Drivers menu. Would that work for you? Regards, Hans > > menuconfig MEDIA_SUPPORT > tristate "Multimedia support" >