From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DE0C4742C for ; Mon, 16 Nov 2020 04:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA13D216C4 for ; Mon, 16 Nov 2020 04:03:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WzzIqz07" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbgKPECk (ORCPT ); Sun, 15 Nov 2020 23:02:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49626 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgKPECk (ORCPT ); Sun, 15 Nov 2020 23:02:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605499359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+x1sdSjYElIzbzoPa6Ux6ilBlwEfssp+DCBplfeClMs=; b=WzzIqz07W2i3BrKddWmlRSQvBZozfa0nWyXUiCHhB1YPle495qlIbGeEbGT0UynTi9KwdY cXVlp0V7Ox2d8iM9kCwLeO0BAsDufeoF+BxERynViqnHZQmKsI5TE6T+QsdFleJNX5MPUi ixwVkDfb/UL08NJh33pglJR8sCViAv4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-K-jWbgH0POSB2x4eLQa0bQ-1; Sun, 15 Nov 2020 23:02:38 -0500 X-MC-Unique: K-jWbgH0POSB2x4eLQa0bQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9C3D100747F; Mon, 16 Nov 2020 04:02:36 +0000 (UTC) Received: from [10.72.13.126] (ovpn-13-126.pek2.redhat.com [10.72.13.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D74B10002A4; Mon, 16 Nov 2020 04:02:27 +0000 (UTC) Subject: Re: [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count To: Stefano Garzarella , virtualization@lists.linux-foundation.org Cc: Stefan Hajnoczi , Laurent Vivier , linux-kernel@vger.kernel.org, Eli Cohen , "Michael S. Tsirkin" , Max Gurtovoy References: <20201113134712.69744-1-sgarzare@redhat.com> <20201113134712.69744-4-sgarzare@redhat.com> From: Jason Wang Message-ID: Date: Mon, 16 Nov 2020 12:02:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201113134712.69744-4-sgarzare@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/13 下午9:47, Stefano Garzarella wrote: > From: Max Gurtovoy > > Add a new attribute that will define the number of virt queues to be > created for the vdpasim device. > > Signed-off-by: Max Gurtovoy > [sgarzare: replace kmalloc_array() with kcalloc()] > Signed-off-by: Stefano Garzarella > --- > v1: > - use kcalloc() instead of kmalloc_array() since some function expects > variables initialized to zero Looks good, one nit, I prefer to do this before patch 2. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A456C4742C for ; Mon, 16 Nov 2020 04:02:45 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07F39216C4 for ; Mon, 16 Nov 2020 04:02:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WzzIqz07" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07F39216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AE3BA203F6; Mon, 16 Nov 2020 04:02:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xfVuV4iF9Asw; Mon, 16 Nov 2020 04:02:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 33EDA2010A; Mon, 16 Nov 2020 04:02:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 14D30C0800; Mon, 16 Nov 2020 04:02:43 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 07843C07FF for ; Mon, 16 Nov 2020 04:02:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E839C86FC4 for ; Mon, 16 Nov 2020 04:02:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2iuE4UViNMHQ for ; Mon, 16 Nov 2020 04:02:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by hemlock.osuosl.org (Postfix) with ESMTPS id E2CC281AEE for ; Mon, 16 Nov 2020 04:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605499359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+x1sdSjYElIzbzoPa6Ux6ilBlwEfssp+DCBplfeClMs=; b=WzzIqz07W2i3BrKddWmlRSQvBZozfa0nWyXUiCHhB1YPle495qlIbGeEbGT0UynTi9KwdY cXVlp0V7Ox2d8iM9kCwLeO0BAsDufeoF+BxERynViqnHZQmKsI5TE6T+QsdFleJNX5MPUi ixwVkDfb/UL08NJh33pglJR8sCViAv4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-K-jWbgH0POSB2x4eLQa0bQ-1; Sun, 15 Nov 2020 23:02:38 -0500 X-MC-Unique: K-jWbgH0POSB2x4eLQa0bQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9C3D100747F; Mon, 16 Nov 2020 04:02:36 +0000 (UTC) Received: from [10.72.13.126] (ovpn-13-126.pek2.redhat.com [10.72.13.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D74B10002A4; Mon, 16 Nov 2020 04:02:27 +0000 (UTC) Subject: Re: [PATCH RFC 03/12] vdpa_sim: remove hard-coded virtq count To: Stefano Garzarella , virtualization@lists.linux-foundation.org References: <20201113134712.69744-1-sgarzare@redhat.com> <20201113134712.69744-4-sgarzare@redhat.com> From: Jason Wang Message-ID: Date: Mon, 16 Nov 2020 12:02:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201113134712.69744-4-sgarzare@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Cc: Laurent Vivier , Max Gurtovoy , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Stefan Hajnoczi , Eli Cohen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjAvMTEvMTMg5LiL5Y2IOTo0NywgU3RlZmFubyBHYXJ6YXJlbGxhIHdyb3RlOgo+IEZy b206IE1heCBHdXJ0b3ZveSA8bWd1cnRvdm95QG52aWRpYS5jb20+Cj4KPiBBZGQgYSBuZXcgYXR0 cmlidXRlIHRoYXQgd2lsbCBkZWZpbmUgdGhlIG51bWJlciBvZiB2aXJ0IHF1ZXVlcyB0byBiZQo+ IGNyZWF0ZWQgZm9yIHRoZSB2ZHBhc2ltIGRldmljZS4KPgo+IFNpZ25lZC1vZmYtYnk6IE1heCBH dXJ0b3ZveSA8bWd1cnRvdm95QG52aWRpYS5jb20+Cj4gW3NnYXJ6YXJlOiByZXBsYWNlIGttYWxs b2NfYXJyYXkoKSB3aXRoIGtjYWxsb2MoKV0KPiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW5vIEdhcnph cmVsbGEgPHNnYXJ6YXJlQHJlZGhhdC5jb20+Cj4gLS0tCj4gdjE6Cj4gLSB1c2Uga2NhbGxvYygp IGluc3RlYWQgb2Yga21hbGxvY19hcnJheSgpIHNpbmNlIHNvbWUgZnVuY3Rpb24gZXhwZWN0cwo+ ICAgIHZhcmlhYmxlcyBpbml0aWFsaXplZCB0byB6ZXJvCgoKTG9va3MgZ29vZCwgb25lIG5pdCwg SSBwcmVmZXIgdG8gZG8gdGhpcyBiZWZvcmUgcGF0Y2ggMi4KClRoYW5rcwoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxp bmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczov L2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlv bg==