From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11435C433F5 for ; Wed, 17 Nov 2021 10:36:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7CE561BFA for ; Wed, 17 Nov 2021 10:36:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7CE561BFA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnIJA-00078q-Qv for qemu-devel@archiver.kernel.org; Wed, 17 Nov 2021 05:36:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnIHN-00061H-16 for qemu-devel@nongnu.org; Wed, 17 Nov 2021 05:35:01 -0500 Received: from 10.mo552.mail-out.ovh.net ([87.98.187.244]:58497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnIHI-0002X1-Cl for qemu-devel@nongnu.org; Wed, 17 Nov 2021 05:35:00 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.25]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id 65BE7218AC; Wed, 17 Nov 2021 10:34:53 +0000 (UTC) Received: from kaod.org (37.59.142.104) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 17 Nov 2021 11:34:52 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-104R0056f123be8-0222-4de7-b188-00a1d2d72523, 6BDA4A3F9269C8E5581A3C4EE5F64AFAFECCD473) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Wed, 17 Nov 2021 11:34:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: Fwd: New Defects reported by Coverity Scan for QEMU Content-Language: en-US To: Luis Fernando Fujita Pires , Matheus Kowalczuk Ferst , QEMU Developers , QEMU PowerPC References: <618af1a42c458_27197b2b2515bd79b8920c6@prd-scan-dashboard-0.mail> <9db2efb6-5161-6c17-f7aa-4d8b7e1aba98@kaod.org> <92434193-3727-8994-9ebd-b823665aa90a@eldorado.org.br> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.104] X-ClientProxiedBy: DAG7EX2.mxp5.local (172.16.2.62) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: dd567e58-e27d-441b-b7e8-ecdc189bf813 X-Ovh-Tracer-Id: 15766257873656712160 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeeigedvffekgeeftedutddttdevudeihfegudffkeeitdekkeetkefhffelveelleenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdqphhptgesnhhonhhgnhhurdhorhhg Received-SPF: pass client-ip=87.98.187.244; envelope-from=clg@kaod.org; helo=10.mo552.mail-out.ovh.net X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.009, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/16/21 21:21, Luis Fernando Fujita Pires wrote: > From: Matheus K. Ferst >> Hi Cédric, >> >> The only change was the helper name that is now uppercase, so nothing new >> here. The underlying cause is that dfp_finalize_decimal64 only sets >> dfp->vt.VsrD(1) and set_dfp64 receives a pointer to the complete struct. >> >> But since set_dfp64 also only access VsrD(1), it shouldn't be a real >> problem AFAICT. The same applies to CID 1465776~1465786 and >> 1465788~1465790. > > Right. Coverity is probably reporting these as new just because the helper macros were re-written as part of the move to decodetree. > I believe these should be marked as false positives. > > We *could* also wrap set_dfp{64,128} in new macros that would then reference only the appropriate parts of dfp, but, in this case, I don't think it's worth the trouble. Thanks for the help on this, C.