From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51436C433DF for ; Mon, 24 Aug 2020 21:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E09D207DF for ; Mon, 24 Aug 2020 21:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727841AbgHXVBW (ORCPT ); Mon, 24 Aug 2020 17:01:22 -0400 Received: from mail2.sp2max.com.br ([138.185.4.9]:51508 "EHLO mail2.sp2max.com.br" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgHXVBV (ORCPT ); Mon, 24 Aug 2020 17:01:21 -0400 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Mon, 24 Aug 2020 17:01:19 EDT Received: from [172.17.0.6] (37-247-245-190.fibertel.com.ar [190.245.247.37]) (Authenticated sender: pablo@fliagreco.com.ar) by mail2.sp2max.com.br (Postfix) with ESMTPSA id B81627B3207; Mon, 24 Aug 2020 17:54:03 -0300 (-03) Subject: Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator To: jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org Cc: robh+dt@kernel.org, icenowy@aosc.io, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <20200824193649.978197-1-jernej.skrabec@siol.net> From: =?UTF-8?Q?Pablo_Sebasti=c3=a1n_Greco?= Message-ID: Date: Mon, 24 Aug 2020 17:54:01 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200824193649.978197-1-jernej.skrabec@siol.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SP2Max-MailScanner-Information: Please contact the ISP for more information X-SP2Max-MailScanner-ID: B81627B3207.A21CE X-SP2Max-MailScanner: Sem Virus encontrado X-SP2Max-MailScanner-SpamCheck: nao spam, SpamAssassin (not cached, escore=-5.15, requerido 6, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90, NICE_REPLY_A -2.25) X-SP2Max-MailScanner-From: pgreco@centosproject.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/8/20 16:36, Jernej Skrabec wrote: > DCDC1 regulator powers many different subsystems. While some of them can > work at 3.0 V, some of them can not. For example, VCC-HDMI can only work > between 3.24 V and 3.36 V. According to OS images provided by the board > manufacturer this regulator should be set to 3.3 V. > > Set DCDC1 and DCDC1SW to 3.3 V in order to fix this. > > Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2 > Ultra") > Signed-off-by: Jernej Skrabec > --- > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index 42d62d1ba1dc..ea15073f0c79 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -223,16 +223,16 @@ ®_aldo3 { > }; > > ®_dc1sw { > - regulator-min-microvolt = <3000000>; > - regulator-max-microvolt = <3000000>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > regulator-name = "vcc-gmac-phy"; > }; > > ®_dcdc1 { > regulator-always-on; > - regulator-min-microvolt = <3000000>; > - regulator-max-microvolt = <3000000>; > - regulator-name = "vcc-3v0"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-3v3"; > }; > > ®_dcdc2 { Should this be done also for the bananapi-m2-berry?, it is basically the same device sun8i-v40-bananapi-m2-berry.dts Pablo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E051C433E1 for ; Mon, 24 Aug 2020 20:55:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A70A2072D for ; Mon, 24 Aug 2020 20:55:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xJqLyEsL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A70A2072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=centosproject.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jZC3kzPmfMM9y4zRbMNDePOcuIIzBXNGmvzcAfBUXVc=; b=xJqLyEsLXYe/9+yefxazkouGJ xPGoP6Jm9KByEOrctO34qC7phPNCrfJgu1KlFzD3EGgyfHT468BtiRjXjCpKurdS3/Zwrl/HGPYwu uGiaZeAgLOw/QhT9Uk46SK2wGtt26DSgeS04XzZfaoVE42Iv5a1G/2O+H6m6JU+KiapTDu/R1/gBw M1P7JYVf3l+Upy6nz7rHw2WW//W8yvAJ7pfUpStQFSqoLAwCmjjopTrRqsovM47bVHqsicJLytC0H SKsLQUjzYnXVtRoyRSjZLrlvIiLCiudbwPdPrudqQcAcDK8oE+A+63NXTehZG7ZIbb5U3sZVKOi73 GtK3dzsyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAJTv-0007JS-7O; Mon, 24 Aug 2020 20:54:19 +0000 Received: from mail2.sp2max.com.br ([138.185.4.9]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAJTr-0007Hs-Id for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 20:54:16 +0000 Received: from [172.17.0.6] (37-247-245-190.fibertel.com.ar [190.245.247.37]) (Authenticated sender: pablo@fliagreco.com.ar) by mail2.sp2max.com.br (Postfix) with ESMTPSA id B81627B3207; Mon, 24 Aug 2020 17:54:03 -0300 (-03) Subject: Re: [linux-sunxi] [PATCH] ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix dcdc1 regulator To: jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org References: <20200824193649.978197-1-jernej.skrabec@siol.net> From: =?UTF-8?Q?Pablo_Sebasti=c3=a1n_Greco?= Message-ID: Date: Mon, 24 Aug 2020 17:54:01 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200824193649.978197-1-jernej.skrabec@siol.net> Content-Language: en-US X-SP2Max-MailScanner-Information: Please contact the ISP for more information X-SP2Max-MailScanner-ID: B81627B3207.A21CE X-SP2Max-MailScanner: Sem Virus encontrado X-SP2Max-MailScanner-SpamCheck: nao spam, SpamAssassin (not cached, escore=-5.15, requerido 6, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90, NICE_REPLY_A -2.25) X-SP2Max-MailScanner-From: pgreco@centosproject.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_165415_775387_DC5C0033 X-CRM114-Status: GOOD ( 17.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/8/20 16:36, Jernej Skrabec wrote: > DCDC1 regulator powers many different subsystems. While some of them can > work at 3.0 V, some of them can not. For example, VCC-HDMI can only work > between 3.24 V and 3.36 V. According to OS images provided by the board > manufacturer this regulator should be set to 3.3 V. > > Set DCDC1 and DCDC1SW to 3.3 V in order to fix this. > > Fixes: da7ac948fa93 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2 > Ultra") > Signed-off-by: Jernej Skrabec > --- > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index 42d62d1ba1dc..ea15073f0c79 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -223,16 +223,16 @@ ®_aldo3 { > }; > > ®_dc1sw { > - regulator-min-microvolt = <3000000>; > - regulator-max-microvolt = <3000000>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > regulator-name = "vcc-gmac-phy"; > }; > > ®_dcdc1 { > regulator-always-on; > - regulator-min-microvolt = <3000000>; > - regulator-max-microvolt = <3000000>; > - regulator-name = "vcc-3v0"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "vcc-3v3"; > }; > > ®_dcdc2 { Should this be done also for the bananapi-m2-berry?, it is basically the same device sun8i-v40-bananapi-m2-berry.dts Pablo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel