From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1B1C433E0 for ; Thu, 14 May 2020 07:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 949D6206BE for ; Thu, 14 May 2020 07:03:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="X2aR4bOY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbgENHDi (ORCPT ); Thu, 14 May 2020 03:03:38 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:33955 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgENHDi (ORCPT ); Thu, 14 May 2020 03:03:38 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589439817; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=mD6zwcTcSV2rURIM5M2MgMVSc+SPDGYA1hmogi2AOqw=; b=X2aR4bOYoESxTn0Gk1HWE7eiNyFH4kikPlI9HXxJYLkszUglgFM9lgEjrfA89eHBb9JLlOlD 2J//GjSIx9Cfo04oplq96sDM/j0vDfkPfcDDPA6nx2GlRNPRf5HuG3n6fwt5IvvVRZq4YWi/ kRK+mR39hvlterCxfu6XyxfsvBI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ebced3f.7fd5c3656f80-smtp-out-n03; Thu, 14 May 2020 07:03:27 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 999D5C43636; Thu, 14 May 2020 07:03:26 +0000 (UTC) Received: from [10.206.24.246] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7D00DC433F2; Thu, 14 May 2020 07:03:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7D00DC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH V5 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash To: Matthias Kaehlcke Cc: gregkh@linuxfoundation.org, agross@kernel.org, bjorn.andersson@linaro.org, wsa@the-dreams.de, broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, swboyd@chromium.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org, georgi.djakov@linaro.org References: <1588919619-21355-1-git-send-email-akashast@codeaurora.org> <1588919619-21355-3-git-send-email-akashast@codeaurora.org> <20200508175938.GB4525@google.com> <20200508191454.GH4525@google.com> From: Akash Asthana Message-ID: Date: Thu, 14 May 2020 12:33:17 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200508191454.GH4525@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Matthias, >> The loop should have curly braces ("use braces when a loop contains more than >> a single simple statement"), even though the compiler doesn't need them in >> this case. This is not a loop, but I was told by a maintainer that it equally >> applies, which makes sense. >> >> You could avoid one level of indentation through: >> >> if (!console_drivers) >> goto exit; >> >>> + for_each_console(bcon) > Actually the NULL check of 'console_drivers' is not needed: > > #define for_each_console(con) \ > for (con = console_drivers; con != NULL; con = con->next) Ok, I will remove this check. Regards, Akash > > see also: > > commit caa72c3bc584bc28b557bcf1a47532a7a6f37e6f > Author: Andy Shevchenko > Date: Mon Feb 3 15:31:25 2020 +0200 > > console: Drop double check for console_drivers being non-NULL -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project