From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH v2 03/12] drm/i915/guc: Allocate separate shared data object for GuC communication Date: Wed, 25 Oct 2017 14:04:46 -0700 Message-ID: References: <20171025200020.16636-1-michal.winiarski@intel.com> <20171025200020.16636-4-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99A9C6E0F9 for ; Wed, 25 Oct 2017 21:04:48 +0000 (UTC) In-Reply-To: <20171025200020.16636-4-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMjUvMTAvMTcgMTM6MDAsIE1pY2hhxYIgV2luaWFyc2tpIHdyb3RlOgo+IFdlIHdlcmUgdXNp bmcgZmlyc3QgcGFnZSBvZiBrZXJuZWwgY29udGV4dCByZW5kZXIgc3RhdGUgZm9yIHNoYXJpbmcg ZGF0YQo+IHdpdGggR3VDLiBXaGlsZSBpdCdzIGp1c3RpZmllZCBieSB0aGUgZmFjdCB0aGF0IHRo b3NlIHBhZ2VzIGFyZSBub3QgdXNlZAo+IChub3RlLCBHdUMgc3RpbGwgZW5mb3JjZXMgdGhpcyBs YXlvdXQgYW5kIHJlZnVzZXMgdG8gd29yayBpZiB3ZSByZW1vdmUKPiB0aGUgZXh0cmEgcGFnZSBp biBmcm9udCksIGl0J3MgYWxzbyBjb25mdXNpbmcgKHdoeSBhcmUgd2UgdXNpbmcgdGhpcwo+IHBh cnRpY3VsYXIgcGFnZT8pLiBMZXQncyBhbGxvY2F0ZSBhIHNlcGFyYXRlIG9iamVjdCBpbnN0ZWFk Lgo+IAo+IHYyOiBEcm9wIGtlcm5lbF9jb250ZXh0IGZyb20gR3VDIHN1c3BlbmQvcmVzdW1lIGFj dGlvbiBoYW5kbGVycyAoTWljaGVsKQoKdjIgUmV2aWV3ZWQtYnk6IE1pY2hlbCBUaGllcnJ5IDxt aWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gCj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWxlIENlcmFv bG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IE1pY2hhxYIgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiBDYzog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IERhbmllbGUgQ2Vy YW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IEplZmYg TWNHZWUgPGplZmYubWNnZWVAaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2FqZGVjemtvIDxtaWNo YWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGlu dGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5j ZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMgICAgICAgICAgIHwgMTQgKystLS0t LS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCAgICAgICAgICAgfCAg MiArKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlz c2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gaW5k ZXggZTE5NWJkZWUwNDczLi5kMWE1NjEzZGEyNGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4gQEAgLTQzNyw2ICs0MzcsMzMgQEAgc3RhdGljIHZv aWQgZ3VjX3N0YWdlX2Rlc2NfZmluaShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsCj4gICAgICAgICAg bWVtc2V0KGRlc2MsIDAsIHNpemVvZigqZGVzYykpOwo+ICAgfQo+IAo+ICtzdGF0aWMgaW50IGd1 Y19zaGFyZWRfZGF0YV9jcmVhdGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICt7Cj4gKyAgICAg ICBzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiArICAgICAgIHZvaWQgKnZhZGRyOwo+ICsKPiArICAg ICAgIHZtYSA9IGludGVsX2d1Y19hbGxvY2F0ZV92bWEoZ3VjLCBQQUdFX1NJWkUpOwo+ICsgICAg ICAgaWYgKElTX0VSUih2bWEpKQo+ICsgICAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUih2bWEp Owo+ICsKPiArICAgICAgIHZhZGRyID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAodm1hLT5vYmos IEk5MTVfTUFQX1dCKTsKPiArICAgICAgIGlmIChJU19FUlIodmFkZHIpKSB7Cj4gKyAgICAgICAg ICAgICAgIGk5MTVfdm1hX3VucGluX2FuZF9yZWxlYXNlKCZ2bWEpOwo+ICsgICAgICAgICAgICAg ICByZXR1cm4gUFRSX0VSUih2YWRkcik7Cj4gKyAgICAgICB9Cj4gKwo+ICsgICAgICAgZ3VjLT5z aGFyZWRfZGF0YSA9IHZtYTsKPiArICAgICAgIGd1Yy0+c2hhcmVkX2RhdGFfdmFkZHIgPSB2YWRk cjsKPiArCj4gKyAgICAgICByZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgZ3VjX3No YXJlZF9kYXRhX2Rlc3Ryb3koc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICt7Cj4gKyAgICAgICBp OTE1X2dlbV9vYmplY3RfdW5waW5fbWFwKGd1Yy0+c2hhcmVkX2RhdGEtPm9iaik7Cj4gKyAgICAg ICBpOTE1X3ZtYV91bnBpbl9hbmRfcmVsZWFzZSgmZ3VjLT5zaGFyZWRfZGF0YSk7Cj4gK30KPiAr Cj4gICAvKiBDb25zdHJ1Y3QgYSBXb3JrIEl0ZW0gYW5kIGFwcGVuZCBpdCB0byB0aGUgR3VDJ3Mg V29yayBRdWV1ZSAqLwo+ICAgc3RhdGljIHZvaWQgZ3VjX3dxX2l0ZW1fYXBwZW5kKHN0cnVjdCBp OTE1X2d1Y19jbGllbnQgKmNsaWVudCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEpCj4gQEAgLTk5Myw5ICsxMDIwLDEzIEBA IGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICAgICAgICAgIGlmIChyZXQpCj4gICAgICAgICAgICAgICAgICByZXR1cm4gcmV0 Owo+IAo+ICsgICAgICAgcmV0ID0gZ3VjX3NoYXJlZF9kYXRhX2NyZWF0ZShndWMpOwo+ICsgICAg ICAgaWYgKHJldCkKPiArICAgICAgICAgICAgICAgZ290byBlcnJfc3RhZ2VfZGVzY19wb29sOwo+ ICsKPiAgICAgICAgICByZXQgPSBpbnRlbF9ndWNfbG9nX2NyZWF0ZShndWMpOwo+ICAgICAgICAg IGlmIChyZXQgPCAwKQo+IC0gICAgICAgICAgICAgICBnb3RvIGVycl9zdGFnZV9kZXNjX3Bvb2w7 Cj4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyX3NoYXJlZF9kYXRhOwo+IAo+ICAgICAgICAgIHJl dCA9IGd1Y19hZHNfY3JlYXRlKGd1Yyk7Cj4gICAgICAgICAgaWYgKHJldCA8IDApCj4gQEAgLTEw MDUsNiArMTAzNiw4IEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IAo+ICAgZXJyX2xvZzoKPiAgICAgICAgICBpbnRlbF9n dWNfbG9nX2Rlc3Ryb3koZ3VjKTsKPiArZXJyX3NoYXJlZF9kYXRhOgo+ICsgICAgICAgZ3VjX3No YXJlZF9kYXRhX2Rlc3Ryb3koZ3VjKTsKPiAgIGVycl9zdGFnZV9kZXNjX3Bvb2w6Cj4gICAgICAg ICAgZ3VjX3N0YWdlX2Rlc2NfcG9vbF9kZXN0cm95KGd1Yyk7Cj4gICAgICAgICAgcmV0dXJuIHJl dDsKPiBAQCAtMTAxNiw2ICsxMDQ5LDcgQEAgdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmko c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IAo+ICAgICAgICAgIGd1Y19hZHNf ZGVzdHJveShndWMpOwo+ICAgICAgICAgIGludGVsX2d1Y19sb2dfZGVzdHJveShndWMpOwo+ICsg ICAgICAgZ3VjX3NoYXJlZF9kYXRhX2Rlc3Ryb3koZ3VjKTsKPiAgICAgICAgICBndWNfc3RhZ2Vf ZGVzY19wb29sX2Rlc3Ryb3koZ3VjKTsKPiAgIH0KPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMu Ywo+IGluZGV4IDEwMDM3YzBmZGY5NS4uZjc0ZDUwZmRhZWIwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjLmMKPiBAQCAtMjY4LDcgKzI2OCw2IEBAIGludCBpbnRlbF9ndWNfYXV0aF9odWMo c3RydWN0IGludGVsX2d1YyAqZ3VjLCB1MzIgcnNhX29mZnNldCkKPiAgIGludCBpbnRlbF9ndWNf c3VzcGVuZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICB7Cj4gICAgICAg ICAgc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRldl9wcml2LT5ndWM7Cj4gLSAgICAgICBzdHJ1 Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4Owo+ICAgICAgICAgIHUzMiBkYXRhWzNdOwo+IAo+ICAg ICAgICAgIGlmIChndWMtPmZ3LmxvYWRfc3RhdHVzICE9IElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NF U1MpCj4gQEAgLTI3NiwxNCArMjc1LDEwIEBAIGludCBpbnRlbF9ndWNfc3VzcGVuZChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gCj4gICAgICAgICAgZ2VuOV9kaXNhYmxlX2d1 Y19pbnRlcnJ1cHRzKGRldl9wcml2KTsKPiAKPiAtICAgICAgIGN0eCA9IGRldl9wcml2LT5rZXJu ZWxfY29udGV4dDsKPiAtCj4gICAgICAgICAgZGF0YVswXSA9IElOVEVMX0dVQ19BQ1RJT05fRU5U RVJfU19TVEFURTsKPiAgICAgICAgICAvKiBhbnkgdmFsdWUgZ3JlYXRlciB0aGFuIEdVQ19QT1dF Ul9EMCAqLwo+ICAgICAgICAgIGRhdGFbMV0gPSBHVUNfUE9XRVJfRDE7Cj4gLSAgICAgICAvKiBm aXJzdCBwYWdlIGlzIHNoYXJlZCBkYXRhIHdpdGggR3VDICovCj4gLSAgICAgICBkYXRhWzJdID0g Z3VjX2dndHRfb2Zmc2V0KGN0eC0+ZW5naW5lW1JDU10uc3RhdGUpICsKPiAtICAgICAgICAgICAg ICAgICBMUkNfR1VDU0hSX1BOICogUEFHRV9TSVpFOwo+ICsgICAgICAgZGF0YVsyXSA9IGd1Y19n Z3R0X29mZnNldChndWMtPnNoYXJlZF9kYXRhKTsKPiAKPiAgICAgICAgICByZXR1cm4gaW50ZWxf Z3VjX3NlbmQoZ3VjLCBkYXRhLCBBUlJBWV9TSVpFKGRhdGEpKTsKPiAgIH0KPiBAQCAtMjk1LDcg KzI5MCw2IEBAIGludCBpbnRlbF9ndWNfc3VzcGVuZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gICBpbnQgaW50ZWxfZ3VjX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gICB7Cj4gICAgICAgICAgc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmRl dl9wcml2LT5ndWM7Cj4gLSAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4Owo+ICAg ICAgICAgIHUzMiBkYXRhWzNdOwo+IAo+ICAgICAgICAgIGlmIChndWMtPmZ3LmxvYWRfc3RhdHVz ICE9IElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1MpCj4gQEAgLTMwNCwxMyArMjk4LDkgQEAgaW50 IGludGVsX2d1Y19yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAg ICAgICAgIGlmIChpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVsID49IDApCj4gICAgICAgICAg ICAgICAgICBnZW45X2VuYWJsZV9ndWNfaW50ZXJydXB0cyhkZXZfcHJpdik7Cj4gCj4gLSAgICAg ICBjdHggPSBkZXZfcHJpdi0+a2VybmVsX2NvbnRleHQ7Cj4gLQo+ICAgICAgICAgIGRhdGFbMF0g PSBJTlRFTF9HVUNfQUNUSU9OX0VYSVRfU19TVEFURTsKPiAgICAgICAgICBkYXRhWzFdID0gR1VD X1BPV0VSX0QwOwo+IC0gICAgICAgLyogZmlyc3QgcGFnZSBpcyBzaGFyZWQgZGF0YSB3aXRoIEd1 QyAqLwo+IC0gICAgICAgZGF0YVsyXSA9IGd1Y19nZ3R0X29mZnNldChjdHgtPmVuZ2luZVtSQ1Nd LnN0YXRlKSArCj4gLSAgICAgICAgICAgICAgICAgTFJDX0dVQ1NIUl9QTiAqIFBBR0VfU0laRTsK PiArICAgICAgIGRhdGFbMl0gPSBndWNfZ2d0dF9vZmZzZXQoZ3VjLT5zaGFyZWRfZGF0YSk7Cj4g Cj4gICAgICAgICAgcmV0dXJuIGludGVsX2d1Y19zZW5kKGd1YywgZGF0YSwgQVJSQVlfU0laRShk YXRhKSk7Cj4gICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Yy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBpbmRleCA0MTg0NTBiMWFl MjcuLmFhMTU4MzE2N2IwYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ndWMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gQEAgLTU0 LDYgKzU0LDggQEAgc3RydWN0IGludGVsX2d1YyB7Cj4gICAgICAgICAgc3RydWN0IGk5MTVfdm1h ICpzdGFnZV9kZXNjX3Bvb2w7Cj4gICAgICAgICAgdm9pZCAqc3RhZ2VfZGVzY19wb29sX3ZhZGRy Owo+ICAgICAgICAgIHN0cnVjdCBpZGEgc3RhZ2VfaWRzOwo+ICsgICAgICAgc3RydWN0IGk5MTVf dm1hICpzaGFyZWRfZGF0YTsKPiArICAgICAgIHZvaWQgKnNoYXJlZF9kYXRhX3ZhZGRyOwo+IAo+ ICAgICAgICAgIHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmV4ZWNidWZfY2xpZW50Owo+IAo+IC0t Cj4gMi4xMy42Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=