From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:55110 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbeEGFLP (ORCPT ); Mon, 7 May 2018 01:11:15 -0400 Subject: Re: [PATCH] orangefs: report attributes_mask and attributes for statx To: Martin Brandenburg , linux-fsdevel@vger.kernel.org, devel@lists.orangefs.org Cc: hubcap@omnibond.com References: <20180504190752.1704-1-martin@omnibond.com> From: Ritesh Harjani Message-ID: Date: Mon, 7 May 2018 10:41:10 +0530 MIME-Version: 1.0 In-Reply-To: <20180504190752.1704-1-martin@omnibond.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Martin, On 5/5/2018 12:37 AM, Martin Brandenburg wrote: > Reported-by: Becky Ligon > Signed-off-by: Martin Brandenburg > Cc: hubcap@omnibond.com Probably some commit message would help understand others(like me who are new at this) what this patch is about. I could not follow your patch until I read about statx by ( git log --grep=STATX_ATTR_IMMUTABLE) Thanks for your help!! > --- > fs/orangefs/inode.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c > index b583fbf90665..f301e4957659 100644 > --- a/fs/orangefs/inode.c > +++ b/fs/orangefs/inode.c > @@ -268,6 +268,13 @@ int orangefs_getattr(const struct path *path, struct kstat *stat, > else > stat->result_mask = STATX_BASIC_STATS & > ~STATX_SIZE; > + > + stat->attributes_mask = STATX_ATTR_IMMUTABLE | > + STATX_ATTR_APPEND; > + if (inode->i_flags & S_IMMUTABLE) > + stat->attributes |= STATX_ATTR_IMMUTABLE; > + if (inode->i_flags & S_APPEND) > + stat->attributes |= STATX_ATTR_APPEND; > } > return ret; > } > -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.