From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194C1C00449 for ; Wed, 3 Oct 2018 16:18:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0B152082A for ; Wed, 3 Oct 2018 16:18:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B152082A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbeJCXHa (ORCPT ); Wed, 3 Oct 2018 19:07:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:11379 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbeJCXH3 (ORCPT ); Wed, 3 Oct 2018 19:07:29 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 09:18:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="91864852" Received: from 2b52.sc.intel.com ([143.183.136.147]) by fmsmga002.fm.intel.com with ESMTP; 03 Oct 2018 09:12:32 -0700 Message-ID: Subject: Re: [RFC PATCH v4 09/27] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW From: Yu-cheng Yu To: Matthew Wilcox Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Date: Wed, 03 Oct 2018 09:07:52 -0700 In-Reply-To: <20181003133856.GA24782@bombadil.infradead.org> References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <20180921150351.20898-10-yu-cheng.yu@intel.com> <20181003133856.GA24782@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-10-03 at 06:38 -0700, Matthew Wilcox wrote: > On Fri, Sep 21, 2018 at 08:03:33AM -0700, Yu-cheng Yu wrote: > > We are going to create _PAGE_DIRTY_SW for non-hardware, memory > > management purposes. Rename _PAGE_DIRTY to _PAGE_DIRTY_HW and > > _PAGE_BIT_DIRTY to _PAGE_BIT_DIRTY_HW to make these PTE dirty > > bits more clear. There are no functional changes in this > > patch. > > I would like there to be some documentation in this patchset which > explains the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. I will add some comments for the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [RFC PATCH v4 09/27] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW Date: Wed, 03 Oct 2018 09:07:52 -0700 Message-ID: References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <20180921150351.20898-10-yu-cheng.yu@intel.com> <20181003133856.GA24782@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181003133856.GA24782@bombadil.infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Wilcox Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek Peter List-Id: linux-api@vger.kernel.org On Wed, 2018-10-03 at 06:38 -0700, Matthew Wilcox wrote: > On Fri, Sep 21, 2018 at 08:03:33AM -0700, Yu-cheng Yu wrote: > > We are going to create _PAGE_DIRTY_SW for non-hardware, memory > > management purposes. Rename _PAGE_DIRTY to _PAGE_DIRTY_HW and > > _PAGE_BIT_DIRTY to _PAGE_BIT_DIRTY_HW to make these PTE dirty > > bits more clear. There are no functional changes in this > > patch. > > I would like there to be some documentation in this patchset which > explains the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. I will add some comments for the difference between PAGE_SOFT_DIRTY and PAGE_DIRTY_SW. Yu-cheng