From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0CBEC433ED for ; Wed, 12 May 2021 19:45:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 081FA61417 for ; Wed, 12 May 2021 19:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 081FA61417 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgunX-0000aY-RW for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 15:45:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lguEk-0002Nu-Pk; Wed, 12 May 2021 15:09:38 -0400 Received: from [201.28.113.2] (port=65047 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lguEj-0007Lp-0t; Wed, 12 May 2021 15:09:38 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Wed, 12 May 2021 16:09:34 -0300 Received: from [127.0.0.1] (unknown [10.10.71.235]) by power9a (Postfix) with ESMTPS id 0DF228000C2; Wed, 12 May 2021 16:09:34 -0300 (-03) Subject: Re: [RFC PATCH 10/11] target/ppc: created tcg-stub.c file To: Richard Henderson , qemu-devel@nongnu.org References: <20210512140813.112884-1-bruno.larsen@eldorado.org.br> <20210512140813.112884-11-bruno.larsen@eldorado.org.br> From: Bruno Piazera Larsen Message-ID: Date: Wed, 12 May 2021 16:09:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------AF48C6F306AC572EB3CC99B2" Content-Language: en-US X-OriginalArrivalTime: 12 May 2021 19:09:34.0396 (UTC) FILETIME=[584457C0:01D74762] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=bruno.larsen@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br, lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------AF48C6F306AC572EB3CC99B2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 12/05/2021 15:39, Richard Henderson wrote: > On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: >> +++ b/target/ppc/tcg-stub.c >> @@ -0,0 +1,33 @@ >> + >> +#include "qemu/osdep.h" > > All files get copyright boilerplate. yeah, I didn't expect this file to stick around, though, as the last time we made a stub file, it ended up not being used, so I decided to go the quick route > >> +#include "exec/hwaddr.h" >> +#include "cpu.h" >> +#include "hw/ppc/spapr.h" >> + >> +hwaddr ppc_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) >> +{ >> +    return 0; >> +} > > This is used by gdbstub. > > If there's a way for kvm to convert a virtual address to a physical > address using the hardware, then use that.  I suspect there is not. > > Otherwise, you have to keep all of the mmu page table walking stuff > for kvm as well as tcg.  Which probably means that all of the other > stuff that you're stubbing out is used or usable as well. ah, this probably means we'll need to compile mmu_helper.c too... that was something we were hoping to avoid, because of the sheer size. > > > r~ -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer --------------AF48C6F306AC572EB3CC99B2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 12/05/2021 15:39, Richard Henderson wrote:
On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote:
+++ b/target/ppc/tcg-stub.c
@@ -0,0 +1,33 @@
+
+#include "qemu/osdep.h"

All files get copyright boilerplate.
yeah, I didn't expect this file to stick around, though, as the last time we made a stub file, it ended up not being used, so I decided to go the quick route

+#include "exec/hwaddr.h"
+#include "cpu.h"
+#include "hw/ppc/spapr.h"
+
+hwaddr ppc_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
+{
+    return 0;
+}

This is used by gdbstub.

If there's a way for kvm to convert a virtual address to a physical address using the hardware, then use that.  I suspect there is not.

Otherwise, you have to keep all of the mmu page table walking stuff for kvm as well as tcg.  Which probably means that all of the other stuff that you're stubbing out is used or usable as well.
ah, this probably means we'll need to compile mmu_helper.c too... that was something we were hoping to avoid, because of the sheer size.


r~
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer
--------------AF48C6F306AC572EB3CC99B2--