From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbdBUUNe (ORCPT ); Tue, 21 Feb 2017 15:13:34 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:46404 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdBUUNZ (ORCPT ); Tue, 21 Feb 2017 15:13:25 -0500 Subject: Re: [PATCH v9 1/2] Add OV5647 device tree documentation To: Vladimir Zapolskiy , Ramiro Oliveira , , , References: <5a93352142495528dd56d5e281a8ed8ad6404a05.1487334912.git.roliveir@synopsys.com> CC: , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greg Kroah-Hartman , Guenter Roeck , Hans Verkuil , "Lars-Peter Clausen" , Mark Rutland , "Mauro Carvalho Chehab" , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek , Robert Jarzmik , Rob Herring , Sakari Ailus , Steve Longerbeam From: Ramiro Oliveira Message-ID: Date: Tue, 21 Feb 2017 20:13:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.136] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vladimir, Thank you for your feedback On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> new file mode 100644 >> index 000000000000..31956426d3b9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> @@ -0,0 +1,35 @@ >> +Omnivision OV5647 raw image sensor >> +--------------------------------- >> + >> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces >> +and CCI (I2C compatible) control bus. >> + >> +Required properties: >> + >> +- compatible : "ovti,ov5647". >> +- reg : I2C slave address of the sensor. >> +- clocks : Reference to the xclk clock. > > Is "xclk" clock a pixel clock or something else? > It's an external oscillator. >> +- clock-names : Should be "xclk". > > You can remove this property, because there is only one source clock. > Ok. >> +- clock-frequency : Frequency of the xclk clock. > > And after the last updates in the driver this property can be removed as well. > But I'm still using clk_get_rate in the driver, if I remove the frequency here the probing will fail. >> + >> +The common video interfaces bindings (see video-interfaces.txt) should be >> +used to specify link to the image data receiver. The OV5647 device >> +node should contain one 'port' child node with an 'endpoint' subnode. >> + >> +Example: >> + >> + i2c@2000 { >> + ... >> + ov: camera@36 { >> + compatible = "ovti,ov5647"; >> + reg = <0x36>; >> + clocks = <&camera_clk>; >> + clock-names = "xclk"; >> + clock-frequency = <25000000>; > > When you remove two unused properties, please don't forget to update the > example. > Ok. >> + port { >> + camera_1: endpoint { >> + remote-endpoint = <&csi1_ep1>; >> + }; >> + }; >> + }; >> + }; >> > > -- > With best wishes, > Vladimir > -- Best Regards Ramiro Oliveira Ramiro.Oliveira@synopsys.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ramiro Oliveira Subject: Re: [PATCH v9 1/2] Add OV5647 device tree documentation Date: Tue, 21 Feb 2017 20:13:16 +0000 Message-ID: References: <5a93352142495528dd56d5e281a8ed8ad6404a05.1487334912.git.roliveir@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vladimir Zapolskiy , Ramiro Oliveira , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: CARLOS.PALMINHA-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greg Kroah-Hartman , Guenter Roeck , Hans Verkuil , Lars-Peter Clausen , Mark Rutland , Mauro Carvalho Chehab , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek , Robert Jarzmik , Rob Herring , Sakari Ailus , Steve Longerbeam List-Id: devicetree@vger.kernel.org Hi Vladimir, Thank you for your feedback On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> new file mode 100644 >> index 000000000000..31956426d3b9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> @@ -0,0 +1,35 @@ >> +Omnivision OV5647 raw image sensor >> +--------------------------------- >> + >> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces >> +and CCI (I2C compatible) control bus. >> + >> +Required properties: >> + >> +- compatible : "ovti,ov5647". >> +- reg : I2C slave address of the sensor. >> +- clocks : Reference to the xclk clock. > > Is "xclk" clock a pixel clock or something else? > It's an external oscillator. >> +- clock-names : Should be "xclk". > > You can remove this property, because there is only one source clock. > Ok. >> +- clock-frequency : Frequency of the xclk clock. > > And after the last updates in the driver this property can be removed as well. > But I'm still using clk_get_rate in the driver, if I remove the frequency here the probing will fail. >> + >> +The common video interfaces bindings (see video-interfaces.txt) should be >> +used to specify link to the image data receiver. The OV5647 device >> +node should contain one 'port' child node with an 'endpoint' subnode. >> + >> +Example: >> + >> + i2c@2000 { >> + ... >> + ov: camera@36 { >> + compatible = "ovti,ov5647"; >> + reg = <0x36>; >> + clocks = <&camera_clk>; >> + clock-names = "xclk"; >> + clock-frequency = <25000000>; > > When you remove two unused properties, please don't forget to update the > example. > Ok. >> + port { >> + camera_1: endpoint { >> + remote-endpoint = <&csi1_ep1>; >> + }; >> + }; >> + }; >> + }; >> > > -- > With best wishes, > Vladimir > -- Best Regards Ramiro Oliveira Ramiro.Oliveira-HKixBCOQz3hWk0Htik3J/w@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html