From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B387C49EA6 for ; Thu, 24 Jun 2021 18:38:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E289061921 for ; Thu, 24 Jun 2021 18:38:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E289061921 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwUFI-0000qX-1f for qemu-devel@archiver.kernel.org; Thu, 24 Jun 2021 14:38:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwUDr-0008Ml-88 for qemu-devel@nongnu.org; Thu, 24 Jun 2021 14:37:07 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:11730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwUDo-0003rN-7Y for qemu-devel@nongnu.org; Thu, 24 Jun 2021 14:37:06 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id EB32D74570B; Thu, 24 Jun 2021 20:37:01 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id B8FA57456E3; Thu, 24 Jun 2021 20:37:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id B72387456B4; Thu, 24 Jun 2021 20:37:01 +0200 (CEST) Date: Thu, 24 Jun 2021 20:37:01 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PULL 30/43] vt82c686: Fix SMBus IO base and configuration registers In-Reply-To: <0c52a343-ed4c-92fa-fac0-0f32f37b0df2@amsat.org> Message-ID: References: <20210221143432.2468220-1-f4bug@amsat.org> <20210221143432.2468220-31-f4bug@amsat.org> <0c52a343-ed4c-92fa-fac0-0f32f37b0df2@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1658082471-1624559821=:63692" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Paul Burton , "Michael S. Tsirkin" , Huacai Chen , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Cleber Rosa , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1658082471-1624559821=:63692 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: > Hi Zoltan, > > On 2/21/21 3:34 PM, Philippe Mathieu-Daudé wrote: >> From: BALATON Zoltan >> >> The base address of the SMBus io ports and its enabled status is set >> by registers in the PCI config space but this was not correctly >> emulated. Instead the SMBus registers were mapped on realize to the >> base address set by a property to the address expected by fuloong2e >> firmware. >> >> Fix the base and config register handling to more closely model >> hardware which allows to remove the property and allows the guest to >> control this mapping. Do all this in reset instead of realize so it's >> correctly updated on reset. > > This commit broken running PMON on Fuloong2E: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg752605.html By the way, I'm not sure I'm reading this test right but looks like the one which claims to test ati-vga has -vga std command line option that probably turns off ati-vga so maybe it does not really test it and the one which has no -vga option so could test ati-vga is not declaring it. Not sure it's a problem just something I've noticed. Regards, BALATON Zoltan --3866299591-1658082471-1624559821=:63692--