From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61085C433E1 for ; Thu, 13 Aug 2020 08:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 347B0204FD for ; Thu, 13 Aug 2020 08:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726639AbgHMIVg (ORCPT ); Thu, 13 Aug 2020 04:21:36 -0400 Received: from foss.arm.com ([217.140.110.172]:51522 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgHMIVf (ORCPT ); Thu, 13 Aug 2020 04:21:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 291C61063; Thu, 13 Aug 2020 01:21:35 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E13B73F70D; Thu, 13 Aug 2020 01:21:32 -0700 (PDT) Subject: Re: [PATCH v2 1/2] mmap locking API: add mmap_lock_is_contended() To: Chinwen Chang , Matthias Brugger , Michel Lespinasse , Andrew Morton , Vlastimil Babka , Daniel Jordan , Davidlohr Bueso , Alexey Dobriyan , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , Song Liu , Jimmy Assarsson , Huang Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-fsdevel@vger.kernel.org, wsd_upstream@mediatek.com References: <1597284810-17454-1-git-send-email-chinwen.chang@mediatek.com> <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> From: Steven Price Message-ID: Date: Thu, 13 Aug 2020 09:21:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/2020 03:13, Chinwen Chang wrote: > Add new API to query if someone wants to acquire mmap_lock > for write attempts. > > Using this instead of rwsem_is_contended makes it more tolerant > of future changes to the lock type. > > Signed-off-by: Chinwen Chang Reviewed-by: Steven Price > --- > include/linux/mmap_lock.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > index 0707671..18e7eae 100644 > --- a/include/linux/mmap_lock.h > +++ b/include/linux/mmap_lock.h > @@ -87,4 +87,9 @@ static inline void mmap_assert_write_locked(struct mm_struct *mm) > VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > } > > +static inline int mmap_lock_is_contended(struct mm_struct *mm) > +{ > + return rwsem_is_contended(&mm->mmap_lock); > +} > + > #endif /* _LINUX_MMAP_LOCK_H */ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BBBC433E1 for ; Thu, 13 Aug 2020 08:21:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D80C204FD for ; Thu, 13 Aug 2020 08:21:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VL4Q9N6n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D80C204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f8ZDDY6tHVnejvJWEnJU526HHnwBEVnOeR4zwLSAxao=; b=VL4Q9N6njoFBq4So3VWWcmu6h PLTqe0BBY8rvyQeqY6fb9DCMPXI4xZa1qBARgchFufheYXmd3KTdT5QlHnQKpg6Ulk6NzAOi8vyXf IxfnyY3FEi3KPYDYREXTXiu1/9cEFVXOsNv13a27qmL2mw373ySScZHQtp8bTV0oAgUtp7HLwHGQI a9kVW+tHdtR6KD3pSa/O7TbtaX4kfdP+9uaNlTQeXGhjmBE0Zzul2iUR7CQItjOvHOeUnMYsWhWSY 9x5ZwuLb8/37x9xMvoev0RMt8nkp48EYNANAKEHATFPHL403UHBzwk2IFsViUs7agvyt9ib3zUkyb UQe1plqSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k68Ua-0000YR-MU; Thu, 13 Aug 2020 08:21:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k68UW-0000X2-Cm; Thu, 13 Aug 2020 08:21:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 291C61063; Thu, 13 Aug 2020 01:21:35 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E13B73F70D; Thu, 13 Aug 2020 01:21:32 -0700 (PDT) Subject: Re: [PATCH v2 1/2] mmap locking API: add mmap_lock_is_contended() To: Chinwen Chang , Matthias Brugger , Michel Lespinasse , Andrew Morton , Vlastimil Babka , Daniel Jordan , Davidlohr Bueso , Alexey Dobriyan , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , Song Liu , Jimmy Assarsson , Huang Ying References: <1597284810-17454-1-git-send-email-chinwen.chang@mediatek.com> <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> From: Steven Price Message-ID: Date: Thu, 13 Aug 2020 09:21:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_042140_499261_25413CE5 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 13/08/2020 03:13, Chinwen Chang wrote: > Add new API to query if someone wants to acquire mmap_lock > for write attempts. > > Using this instead of rwsem_is_contended makes it more tolerant > of future changes to the lock type. > > Signed-off-by: Chinwen Chang Reviewed-by: Steven Price > --- > include/linux/mmap_lock.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > index 0707671..18e7eae 100644 > --- a/include/linux/mmap_lock.h > +++ b/include/linux/mmap_lock.h > @@ -87,4 +87,9 @@ static inline void mmap_assert_write_locked(struct mm_struct *mm) > VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > } > > +static inline int mmap_lock_is_contended(struct mm_struct *mm) > +{ > + return rwsem_is_contended(&mm->mmap_lock); > +} > + > #endif /* _LINUX_MMAP_LOCK_H */ > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68368C433DF for ; Thu, 13 Aug 2020 08:22:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 368DB204FD for ; Thu, 13 Aug 2020 08:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yo9QY0xO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 368DB204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y+pYi7RH/VxHdhedPzkqK3CztQVEgB39k9QH9jg0ICI=; b=Yo9QY0xO7EqVkRIrdg5Dgk8pV 0JgNs4uEmhSuhunneYgjTB6QaNzyLdsEOtSTWZUNnXDK6Y+msHMfrHqwEogQBicGsbGDtkatksQ+5 tMVeA2nJ2MzVpB3x6GRQr2HUoKbgbMUkhaNhw6J6x1sg55+XWSvi8K28qRSeWEmjue3q0JMRF1CXZ 4Vqr1TAKscDq/yqH0GIxQTb4zp7MxFFokIDofMtyiRmtozUA964ZwQIFW7Rc9/ODtwZcLKJRjDG+b 3EHhc7wF+Q6BFLf0j6sxoCrrNEssS2oAp7gM/joPTHa5rlF31QkoqGPISXpwolnextFySM4oNoqOf ZirSQ+NIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k68UY-0000Xx-Us; Thu, 13 Aug 2020 08:21:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k68UW-0000X2-Cm; Thu, 13 Aug 2020 08:21:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 291C61063; Thu, 13 Aug 2020 01:21:35 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E13B73F70D; Thu, 13 Aug 2020 01:21:32 -0700 (PDT) Subject: Re: [PATCH v2 1/2] mmap locking API: add mmap_lock_is_contended() To: Chinwen Chang , Matthias Brugger , Michel Lespinasse , Andrew Morton , Vlastimil Babka , Daniel Jordan , Davidlohr Bueso , Alexey Dobriyan , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , Song Liu , Jimmy Assarsson , Huang Ying References: <1597284810-17454-1-git-send-email-chinwen.chang@mediatek.com> <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> From: Steven Price Message-ID: Date: Thu, 13 Aug 2020 09:21:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1597284810-17454-2-git-send-email-chinwen.chang@mediatek.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_042140_499261_25413CE5 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/08/2020 03:13, Chinwen Chang wrote: > Add new API to query if someone wants to acquire mmap_lock > for write attempts. > > Using this instead of rwsem_is_contended makes it more tolerant > of future changes to the lock type. > > Signed-off-by: Chinwen Chang Reviewed-by: Steven Price > --- > include/linux/mmap_lock.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > index 0707671..18e7eae 100644 > --- a/include/linux/mmap_lock.h > +++ b/include/linux/mmap_lock.h > @@ -87,4 +87,9 @@ static inline void mmap_assert_write_locked(struct mm_struct *mm) > VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); > } > > +static inline int mmap_lock_is_contended(struct mm_struct *mm) > +{ > + return rwsem_is_contended(&mm->mmap_lock); > +} > + > #endif /* _LINUX_MMAP_LOCK_H */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel