From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOkFi-0006k6-7X for qemu-devel@nongnu.org; Mon, 19 Nov 2018 09:10:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOkFf-0007hH-0b for qemu-devel@nongnu.org; Mon, 19 Nov 2018 09:10:14 -0500 References: <20181119120820.29878-1-maozhongyi@cmss.chinamobile.com> <20181119120820.29878-22-maozhongyi@cmss.chinamobile.com> <20181119132527.0e7c26c9.cohuck@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 19 Nov 2018 15:10:00 +0100 MIME-Version: 1.0 In-Reply-To: <20181119132527.0e7c26c9.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 21/22] event-facility: Change SysBusDeviceClass *sbdc to SysBusDeviceClass *sbc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Mao Zhongyi Cc: david@redhat.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, Zhang Shengju , rth@twiddle.net On 2018-11-19 13:25, Cornelia Huck wrote: > On Mon, 19 Nov 2018 20:08:19 +0800 > Mao Zhongyi wrote: > >> Most of the SysBusDeviceClass variables are named sbc, >> and sbdc here is a bit weird, so changing sbdc to keep >> it consistent with others might look good. > > A quick git grep also gives sbd and k as variable names, and it is used > in a total of two lines which have not been touched since 2013, so... > meh. If others like the change, I'm not opposed to merging, though. I think I agree with Cornelia, just changing the variable name because it's named differently in a couple of other places is just unnecessary code churn, which makes "git blame" output harder to read later. I'd suggest to drop this patch, too. Thomas