From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8852C4332F for ; Sun, 6 Nov 2022 10:43:25 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9CAA40691; Sun, 6 Nov 2022 11:43:24 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 744794003C; Sun, 6 Nov 2022 11:43:23 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CEE3E62; Sun, 6 Nov 2022 13:43:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CEE3E62 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667731402; bh=5fIsiUg3VJ19IeFQKdOa5fWMbl/Pjm05itb6OBbxLoA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LyLJnwTzmwCwZMAJGkel0lWuS3bBp5sEj5Da57vCbV9k1+dJo24MTjSIbVo/TLXsa AkHoUlGNa/y1FQPMlU53RXwbnfywx8l+pruZ01je8D1Dr6/RI3zvqGhKp4IXpfppoD qpO73JLy2/5aI0ExGlxXL5iJ9+xoErTUDEBbWGE0= Message-ID: Date: Sun, 6 Nov 2022 13:43:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] drivers/net: remove alias for virtual devices Content-Language: en-US To: Bruce Richardson , Thomas Monjalon Cc: "John W. Linville" , Chas Williams , "Min Hu (Connor)" , Liron Himi , Tetsuya Mukawa , Harman Kalra , Matan Azrad , Maxime Coquelin , Chenbo Xia , Ferruh Yigit , dev@dpdk.org, Stephen Hemminger , techboard@dpdk.org References: <20220921133451.4164506-1-ferruh.yigit@amd.com> <37814289.10thIPus4b@thomas> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/19/22 16:13, Bruce Richardson wrote: > On Wed, Sep 21, 2022 at 04:26:11PM +0200, Thomas Monjalon wrote: >> I think this patch requires a techboard vote >> as it is dropping some user-facing naming. >> > I think a better solution is to centralize the use of aliases. I've just > posted a patch to this thread to add the aliasing for net drivers to the > vdev bus driver. While it does imply a certain amount of abstraction > "leakage", it does make the use of aliases consistent and saves it being > spread across multiple driver files. > > Thoughts? > > /Bruce Removal is declined by techboard. So, I'm marking the patch as Rejected. However, moving allies to common code, as suggested by Bruce, should be considered.