All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Jacob Kroon <jacob.kroon@gmail.com>,
	Yocto Project <yocto@yoctoproject.org>
Cc: jason.wessel@windriver.com
Subject: Re: kernel menuconfig/ncurses patch in linux-yocto
Date: Wed, 20 Jul 2016 23:22:20 -0400	[thread overview]
Message-ID: <a2afecd0-e6c0-ee36-5643-c08ecfd7adbb@windriver.com> (raw)
In-Reply-To: <CAPbeDCmbBpkOe9PY8UJMYUg2e9ddwSEiJufXFwyY_MkzaKJm6w@mail.gmail.com>

On 2016-07-20 4:19 PM, Jacob Kroon wrote:
> Hi,
> I'm trying to get the SDK to be able to run the kernel's "make
> menuconfig" target
> using nativesdk-ncurses from the SDK. Looking at
>
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.4/commit/scripts/kconfig/lxdialog/check-lxdialog.sh?h=standard/beaglebone&id=badf6fedf455958fe0ff3c060c8e3965ef6d80dc
>
> I figured out I could pass CROSS_CURSES_[INC,LIB], but the second chunk
> in that patch looks weird:
>
>     elif pkg-config --cflags ncurses 2>/dev/null; then
>         echo '-DCURSES_LOC="<ncurses.h>"'
> +   if [ x"$CROSS_CURSES_INC" != x ]; then
> +   echo "$CROSS_CURSES_INC"
> +   exit
> +   fi
>     elif [ -f /usr/include/ncursesw/curses.h ]; then
>         echo '-I/usr/include/ncursesw -DCURSES_LOC="<curses.h>"'
>
> (I had to do manual indentation with spaces in gmail)
> Is the indentation or the logic incorrect ?

In the commit itself, the indentation is fine.

That block of code is just dumping flags that are used in the
build. So in this case, it is correct. If the variable is
non empty, it is echoed and then processing exits.

Bruce

>
> Regards Jacob
>



  reply	other threads:[~2016-07-21  3:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 20:19 kernel menuconfig/ncurses patch in linux-yocto Jacob Kroon
2016-07-21  3:22 ` Bruce Ashfield [this message]
2016-07-21  6:35   ` Jacob Kroon
2016-07-21 12:58     ` Bruce Ashfield
2016-07-21 13:06       ` Bruce Ashfield
2016-07-21 14:24         ` Jacob Kroon
2016-07-21 17:01           ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2afecd0-e6c0-ee36-5643-c08ecfd7adbb@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=jacob.kroon@gmail.com \
    --cc=jason.wessel@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.