From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait Date: Fri, 17 Jul 2020 02:01:28 +0300 Message-ID: References: <1594786855-26506-1-git-send-email-skomatineni@nvidia.com> <1594786855-26506-17-git-send-email-skomatineni@nvidia.com> <20d63eca-4b2b-584e-a391-a4fb64a16b40@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi, robh+dt@kernel.org, helen.koike@collabora.com Cc: sboyd@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 17.07.2020 01:49, Sowjanya Komatineni пишет: >> What keeps MIPI clock enabled after completion of the >> tegra_mipi_calibrate() invocation? > > MIPI clock is disabled at end of tegra_mipi_calibrate and is re-enabled > during tegra_mipi_wait. > > I think I should fix this to keep the clock enabled till calibration > results are latched. > > All consumers of tegra_mipi_calibrate() will call tegra_mipi_wait(). > > So will remove clk_disable mipi clk at end of tegra_mipi_calibrate() and > clk_enable mipi_clk at beginning of tegra_mipi_wait() Isn't it possible to perform the calibration after enabling CSI and before of starting the sensor streaming?