From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDC6C12002 for ; Mon, 19 Jul 2021 04:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E9BA61175 for ; Mon, 19 Jul 2021 04:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbhGSEtf (ORCPT ); Mon, 19 Jul 2021 00:49:35 -0400 Received: from foss.arm.com ([217.140.110.172]:48884 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbhGSEte (ORCPT ); Mon, 19 Jul 2021 00:49:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B309B31B; Sun, 18 Jul 2021 21:46:34 -0700 (PDT) Received: from [10.163.64.230] (unknown [10.163.64.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 026E33F694; Sun, 18 Jul 2021 21:46:30 -0700 (PDT) Subject: Re: [RFC 07/10] arm64/mm: Detect and enable FEAT_LPA2 To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, steven.price@arm.com References: <1626229291-6569-1-git-send-email-anshuman.khandual@arm.com> <1626229291-6569-8-git-send-email-anshuman.khandual@arm.com> <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> <8adefac5-c677-1fca-20dd-bba8543f8d59@arm.com> <429105f9-e967-492e-1d1f-5bb913ef6854@arm.com> From: Anshuman Khandual Message-ID: Date: Mon, 19 Jul 2021 10:17:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <429105f9-e967-492e-1d1f-5bb913ef6854@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/16/21 1:38 PM, Suzuki K Poulose wrote: > On 16/07/2021 08:06, Anshuman Khandual wrote: >> >> On 7/14/21 1:51 PM, Suzuki K Poulose wrote: >>> On 14/07/2021 03:21, Anshuman Khandual wrote: >>>> Detect FEAT_LPA2 implementation early enough during boot when requested via >>>> CONFIG_ARM64_PA_BITS_52_LPA2 and remember in a variable arm64_lpa2_enabled. >>>> This variable could then be used to turn on TCR_EL1.TCR_DS effecting the 52 >>>> bits PA range or fall back to default 48 bits PA range if FEAT_LPA2 feature >>>> was requested but found not to be implemented. >>>> >>>> Signed-off-by: Anshuman Khandual >>>> --- >>>>    arch/arm64/include/asm/memory.h |  1 + >>>>    arch/arm64/kernel/head.S        | 15 +++++++++++++++ >>>>    arch/arm64/mm/mmu.c             |  3 +++ >>>>    arch/arm64/mm/proc.S            |  9 +++++++++ >>>>    4 files changed, 28 insertions(+) >>>> >>>> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h >>>> index 824a365..d0ca002 100644 >>>> --- a/arch/arm64/include/asm/memory.h >>>> +++ b/arch/arm64/include/asm/memory.h >>>> @@ -178,6 +178,7 @@ >>>>    #include >>>>      extern u64            vabits_actual; >>>> +extern u64            arm64_lpa2_enabled; >>>>      extern s64            memstart_addr; >>>>    /* PHYS_OFFSET - the physical address of the start of memory. */ >>>> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S >>>> index 6444147..9cf79ea 100644 >>>> --- a/arch/arm64/kernel/head.S >>>> +++ b/arch/arm64/kernel/head.S >>>> @@ -94,6 +94,21 @@ SYM_CODE_START(primary_entry) >>>>        adrp    x23, __PHYS_OFFSET >>>>        and    x23, x23, MIN_KIMG_ALIGN - 1    // KASLR offset, defaults to 0 >>>>        bl    set_cpu_boot_mode_flag >>>> + >>>> +#ifdef CONFIG_ARM64_PA_BITS_52_LPA2 >>>> +    mrs     x10, ID_AA64MMFR0_EL1 >>>> +    ubfx    x10, x10, #ID_AA64MMFR0_TGRAN_SHIFT, 4 >>>> +    cmp     x10, #ID_AA64MMFR0_TGRAN_LPA2 >>>> +    b.ne    1f >>> >>> For the sake of forward compatibility, this should be "b.lt" >> Right, I guess we could assume that the feature will be present from the >> current ID_AA64MMFR0_TGRAN_LPA2 values onward in the future. But should >> not this also be capped at ID_AA64MMFR0_TGRAN_SUPPORTED_MAX as the upper >> limit is different for 4K and 16K page sizes. > > Absolutely. ID_AA64MMFR0_TGRAN_SUPPORTED_MAX check there is not required as __enable_mmu() already performs the required boundary check for a given page size support. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3B64C12002 for ; Mon, 19 Jul 2021 04:49:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A08B26115B for ; Mon, 19 Jul 2021 04:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A08B26115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=h7yvtSVFLryUpzVdeURdcncN4Mib+NtBLgB1GOC+jNo=; b=emZCf4Hj3v9pbjNgjLkjkOKGHu Z/Yyb8Th08kYkQt4ORoidnLP+NZcZbpxaqz1soBiOD6rn7gw8iCjvXgqJNoST8k635QSQA999QeQr QbANskjk7cpstkIW1H793u1gRBMh8wo4BBXd3nZUUmt4pHQly0a8Py4kEBpX8HfwiaSCLSEC2Zt+L w07/VkBQ50ckSSXixvlyHOU6yxyCiOzMd0c9U+Wgcl6ZdYUrwkxFvEglnwSYoTu0IlGZSCDYdqv+t hGxb3FK8NsA8/xwC4uBJmZqvV19W2oYadsea19ugvCF11nssII57IO0rrLg94BD0vVm/ZV0Umtxh3 TwUXiUcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5LB3-008PGA-Li; Mon, 19 Jul 2021 04:46:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5LAz-008PFr-Gu for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 04:46:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B309B31B; Sun, 18 Jul 2021 21:46:34 -0700 (PDT) Received: from [10.163.64.230] (unknown [10.163.64.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 026E33F694; Sun, 18 Jul 2021 21:46:30 -0700 (PDT) Subject: Re: [RFC 07/10] arm64/mm: Detect and enable FEAT_LPA2 To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, steven.price@arm.com References: <1626229291-6569-1-git-send-email-anshuman.khandual@arm.com> <1626229291-6569-8-git-send-email-anshuman.khandual@arm.com> <18c42dd0-b6db-d118-dad0-cac0bf6ab2ce@arm.com> <8adefac5-c677-1fca-20dd-bba8543f8d59@arm.com> <429105f9-e967-492e-1d1f-5bb913ef6854@arm.com> From: Anshuman Khandual Message-ID: Date: Mon, 19 Jul 2021 10:17:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <429105f9-e967-492e-1d1f-5bb913ef6854@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210718_214645_697537_7FE4AB48 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA3LzE2LzIxIDE6MzggUE0sIFN1enVraSBLIFBvdWxvc2Ugd3JvdGU6Cj4gT24gMTYvMDcv MjAyMSAwODowNiwgQW5zaHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4+Cj4+IE9uIDcvMTQvMjEgMTo1 MSBQTSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4+IE9uIDE0LzA3LzIwMjEgMDM6MjEsIEFu c2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+Pj4+IERldGVjdCBGRUFUX0xQQTIgaW1wbGVtZW50YXRp b24gZWFybHkgZW5vdWdoIGR1cmluZyBib290IHdoZW4gcmVxdWVzdGVkIHZpYQo+Pj4+IENPTkZJ R19BUk02NF9QQV9CSVRTXzUyX0xQQTIgYW5kIHJlbWVtYmVyIGluIGEgdmFyaWFibGUgYXJtNjRf bHBhMl9lbmFibGVkLgo+Pj4+IFRoaXMgdmFyaWFibGUgY291bGQgdGhlbiBiZSB1c2VkIHRvIHR1 cm4gb24gVENSX0VMMS5UQ1JfRFMgZWZmZWN0aW5nIHRoZSA1Mgo+Pj4+IGJpdHMgUEEgcmFuZ2Ug b3IgZmFsbCBiYWNrIHRvIGRlZmF1bHQgNDggYml0cyBQQSByYW5nZSBpZiBGRUFUX0xQQTIgZmVh dHVyZQo+Pj4+IHdhcyByZXF1ZXN0ZWQgYnV0IGZvdW5kIG5vdCB0byBiZSBpbXBsZW1lbnRlZC4K Pj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFu ZHVhbEBhcm0uY29tPgo+Pj4+IC0tLQo+Pj4+IMKgwqAgYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9t ZW1vcnkuaCB8wqAgMSArCj4+Pj4gwqDCoCBhcmNoL2FybTY0L2tlcm5lbC9oZWFkLlPCoMKgwqDC oMKgwqDCoCB8IDE1ICsrKysrKysrKysrKysrKwo+Pj4+IMKgwqAgYXJjaC9hcm02NC9tbS9tbXUu Y8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqAgMyArKysKPj4+PiDCoMKgIGFyY2gvYXJtNjQv bW0vcHJvYy5TwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqAgOSArKysrKysrKysKPj4+PiDCoMKg IDQgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBh L2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vbWVtb3J5LmggYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNt L21lbW9yeS5oCj4+Pj4gaW5kZXggODI0YTM2NS4uZDBjYTAwMiAxMDA2NDQKPj4+PiAtLS0gYS9h cmNoL2FybTY0L2luY2x1ZGUvYXNtL21lbW9yeS5oCj4+Pj4gKysrIGIvYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9tZW1vcnkuaAo+Pj4+IEBAIC0xNzgsNiArMTc4LDcgQEAKPj4+PiDCoMKgICNpbmNs dWRlIDxhc20vYnVnLmg+Cj4+Pj4gwqDCoCDCoCBleHRlcm4gdTY0wqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB2YWJpdHNfYWN0dWFsOwo+Pj4+ICtleHRlcm4gdTY0wqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBhcm02NF9scGEyX2VuYWJsZWQ7Cj4+Pj4gwqDCoCDCoCBleHRlcm4gczY0wqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBtZW1zdGFydF9hZGRyOwo+Pj4+IMKgwqAgLyogUEhZU19PRkZTRVQgLSB0aGUg cGh5c2ljYWwgYWRkcmVzcyBvZiB0aGUgc3RhcnQgb2YgbWVtb3J5LiAqLwo+Pj4+IGRpZmYgLS1n aXQgYS9hcmNoL2FybTY0L2tlcm5lbC9oZWFkLlMgYi9hcmNoL2FybTY0L2tlcm5lbC9oZWFkLlMK Pj4+PiBpbmRleCA2NDQ0MTQ3Li45Y2Y3OWVhIDEwMDY0NAo+Pj4+IC0tLSBhL2FyY2gvYXJtNjQv a2VybmVsL2hlYWQuUwo+Pj4+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL2hlYWQuUwo+Pj4+IEBA IC05NCw2ICs5NCwyMSBAQCBTWU1fQ09ERV9TVEFSVChwcmltYXJ5X2VudHJ5KQo+Pj4+IMKgwqDC oMKgwqDCoCBhZHJwwqDCoMKgIHgyMywgX19QSFlTX09GRlNFVAo+Pj4+IMKgwqDCoMKgwqDCoCBh bmTCoMKgwqAgeDIzLCB4MjMsIE1JTl9LSU1HX0FMSUdOIC0gMcKgwqDCoCAvLyBLQVNMUiBvZmZz ZXQsIGRlZmF1bHRzIHRvIDAKPj4+PiDCoMKgwqDCoMKgwqAgYmzCoMKgwqAgc2V0X2NwdV9ib290 X21vZGVfZmxhZwo+Pj4+ICsKPj4+PiArI2lmZGVmIENPTkZJR19BUk02NF9QQV9CSVRTXzUyX0xQ QTIKPj4+PiArwqDCoMKgIG1yc8KgwqDCoMKgIHgxMCwgSURfQUE2NE1NRlIwX0VMMQo+Pj4+ICvC oMKgwqAgdWJmeMKgwqDCoCB4MTAsIHgxMCwgI0lEX0FBNjRNTUZSMF9UR1JBTl9TSElGVCwgNAo+ Pj4+ICvCoMKgwqAgY21wwqDCoMKgwqAgeDEwLCAjSURfQUE2NE1NRlIwX1RHUkFOX0xQQTIKPj4+ PiArwqDCoMKgIGIubmXCoMKgwqAgMWYKPj4+Cj4+PiBGb3IgdGhlIHNha2Ugb2YgZm9yd2FyZCBj b21wYXRpYmlsaXR5LCB0aGlzIHNob3VsZCBiZSAiYi5sdCIKPj4gUmlnaHQsIEkgZ3Vlc3Mgd2Ug Y291bGQgYXNzdW1lIHRoYXQgdGhlIGZlYXR1cmUgd2lsbCBiZSBwcmVzZW50IGZyb20gdGhlCj4+ IGN1cnJlbnQgSURfQUE2NE1NRlIwX1RHUkFOX0xQQTIgdmFsdWVzIG9ud2FyZCBpbiB0aGUgZnV0 dXJlLiBCdXQgc2hvdWxkCj4+IG5vdCB0aGlzIGFsc28gYmUgY2FwcGVkIGF0IElEX0FBNjRNTUZS MF9UR1JBTl9TVVBQT1JURURfTUFYIGFzIHRoZSB1cHBlcgo+PiBsaW1pdCBpcyBkaWZmZXJlbnQg Zm9yIDRLIGFuZCAxNksgcGFnZSBzaXplcy4KPiAKPiBBYnNvbHV0ZWx5LgoKSURfQUE2NE1NRlIw X1RHUkFOX1NVUFBPUlRFRF9NQVggY2hlY2sgdGhlcmUgaXMgbm90IHJlcXVpcmVkIGFzIF9fZW5h YmxlX21tdSgpCmFscmVhZHkgcGVyZm9ybXMgdGhlIHJlcXVpcmVkIGJvdW5kYXJ5IGNoZWNrIGZv ciBhIGdpdmVuIHBhZ2Ugc2l6ZSBzdXBwb3J0LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=