From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDF9C433DB for ; Thu, 18 Mar 2021 09:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00F0E64F30 for ; Thu, 18 Mar 2021 09:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbhCRJeZ (ORCPT ); Thu, 18 Mar 2021 05:34:25 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:13190 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhCRJeA (ORCPT ); Thu, 18 Mar 2021 05:34:00 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F1MGr1z7XzmZCK; Thu, 18 Mar 2021 17:31:32 +0800 (CST) Received: from [127.0.0.1] (10.69.38.203) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Thu, 18 Mar 2021 17:33:51 +0800 Subject: Re: [Linuxarm] Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to sysfs_emit_at To: Joe Perches , , , , CC: , , References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com> <1615974111-45601-3-git-send-email-liuqi115@huawei.com> From: "liuqi (BA)" Message-ID: Date: Thu, 18 Mar 2021 17:33:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.38.203] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/17 22:57, Joe Perches wrote: > On Wed, 2021-03-17 at 17:41 +0800, Qi Liu wrote: >> Use the generic sysfs_emit_at() function take place of scnprintf() > [] >> diff --git a/drivers/perf/arm-ccn.c b/drivers/perf/arm-ccn.c > [] >> @@ -328,41 +328,37 @@ static ssize_t arm_ccn_pmu_event_show(struct device *dev, >>   struct arm_ccn_pmu_event, attr); >>   ssize_t res; >> >> >> - res = scnprintf(buf, PAGE_SIZE, "type=0x%x", event->type); >> + res = sysfs_emit(buf, "type=0x%x", event->type); >>   if (event->event) >> - res += scnprintf(buf + res, PAGE_SIZE - res, ",event=0x%x", >> + res += sysfs_emit_at(buf + res, res, ",event=0x%x", >>   event->event); > > sysfs_emit_at should always use buf, not buf + offset. > res should be int and is the offset from buf for the output > > so the form should be similar to > > int len; > > len = sysfs_emit(buf, "type=0x%x", event->type); > if (event->event) { > len += sysfs_emit_at(buf, len, ",event=0x%x", event->event); > > etc... > Hi Joe, I'll fix the use of sysfs_emit_at in next version, thanks. But I think it's better to keep the res as ssize_t, as the return value of this function is ssize_t. Thanks, Qi > _______________________________________________ > Linuxarm mailing list -- linuxarm@openeuler.org > To unsubscribe send an email to linuxarm-leave@openeuler.org > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412C6C433E0 for ; Thu, 18 Mar 2021 09:36:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B73B86146D for ; Thu, 18 Mar 2021 09:36:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B73B86146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h1pXgI+2xAbjcd2euawWOteiSDlrCvKpIN5l06yjLuI=; b=QL7DtZbVgWs22VQ32OKgoEhwX wLqn8Xtkqq6z+n3d9d+tAKTsmWkL821YPcwtt7WPaMAkHRJswfgRgmlqkcx4XpmSlfgvXSv67XYQd wAjOuRfnS8WoKQ+DI2slqneSamvVLp0nlWCZL/Yxuy7Z/90HdXu5cDknCAKfz4zOHN7bElimjqw3p Up1ExuUThgwTBvG2KpgGJftMh8ZPrwaYOBuCWJgZye24oJ3m9eUmtENHxE2h8onVwYGYmAE0B00ry ESNbCnjjlJdpiWpEu0bzgfnHhcm93R37vrhdi9txEsXSrqJQ3qR/VpzqBKe3pRTB8fOWhPaO9H3/h gFAJCFmNA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMp2g-004vF1-LR; Thu, 18 Mar 2021 09:34:10 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMp2b-004vDK-1k for linux-arm-kernel@lists.infradead.org; Thu, 18 Mar 2021 09:34:08 +0000 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F1MGr1z7XzmZCK; Thu, 18 Mar 2021 17:31:32 +0800 (CST) Received: from [127.0.0.1] (10.69.38.203) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Thu, 18 Mar 2021 17:33:51 +0800 Subject: Re: [Linuxarm] Re: [PATCH 2/3] drivers/perf: convert sysfs scnprintf family to sysfs_emit_at To: Joe Perches , , , , CC: , , References: <1615974111-45601-1-git-send-email-liuqi115@huawei.com> <1615974111-45601-3-git-send-email-liuqi115@huawei.com> From: "liuqi (BA)" Message-ID: Date: Thu, 18 Mar 2021 17:33:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [10.69.38.203] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210318_093406_724397_5DA548DD X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIxLzMvMTcgMjI6NTcsIEpvZSBQZXJjaGVzIHdyb3RlOgo+IE9uIFdlZCwgMjAyMS0w My0xNyBhdCAxNzo0MSArMDgwMCwgUWkgTGl1IHdyb3RlOgo+PiBVc2UgdGhlIGdlbmVyaWMgc3lz ZnNfZW1pdF9hdCgpIGZ1bmN0aW9uIHRha2UgcGxhY2Ugb2Ygc2NucHJpbnRmKCkKPiBbXQo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9wZXJmL2FybS1jY24uYyBiL2RyaXZlcnMvcGVyZi9hcm0tY2Nu LmMKPiBbXQo+PiBAQCAtMzI4LDQxICszMjgsMzcgQEAgc3RhdGljIHNzaXplX3QgYXJtX2Njbl9w bXVfZXZlbnRfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4+ICDCoAkJCXN0cnVjdCBhcm1fY2Nu X3BtdV9ldmVudCwgYXR0cik7Cj4+ICDCoAlzc2l6ZV90IHJlczsKPj4gICAKPj4KPj4gLQlyZXMg PSBzY25wcmludGYoYnVmLCBQQUdFX1NJWkUsICJ0eXBlPTB4JXgiLCBldmVudC0+dHlwZSk7Cj4+ ICsJcmVzID0gc3lzZnNfZW1pdChidWYsICJ0eXBlPTB4JXgiLCBldmVudC0+dHlwZSk7Cj4+ICDC oAlpZiAoZXZlbnQtPmV2ZW50KQo+PiAtCQlyZXMgKz0gc2NucHJpbnRmKGJ1ZiArIHJlcywgUEFH RV9TSVpFIC0gcmVzLCAiLGV2ZW50PTB4JXgiLAo+PiArCQlyZXMgKz0gc3lzZnNfZW1pdF9hdChi dWYgKyByZXMsIHJlcywgIixldmVudD0weCV4IiwKPj4gIMKgCQkJCWV2ZW50LT5ldmVudCk7Cj4g Cj4gc3lzZnNfZW1pdF9hdCBzaG91bGQgYWx3YXlzIHVzZSBidWYsIG5vdCBidWYgKyBvZmZzZXQu Cj4gcmVzIHNob3VsZCBiZSBpbnQgYW5kIGlzIHRoZSBvZmZzZXQgZnJvbSBidWYgZm9yIHRoZSBv dXRwdXQKPiAKPiBzbyB0aGUgZm9ybSBzaG91bGQgYmUgc2ltaWxhciB0bwo+IAo+IAlpbnQgbGVu Owo+IAo+IAlsZW4gPSBzeXNmc19lbWl0KGJ1ZiwgInR5cGU9MHgleCIsIGV2ZW50LT50eXBlKTsK PiAJaWYgKGV2ZW50LT5ldmVudCkgewo+IAkJbGVuICs9IHN5c2ZzX2VtaXRfYXQoYnVmLCBsZW4s ICIsZXZlbnQ9MHgleCIsIGV2ZW50LT5ldmVudCk7Cj4gCj4gCQlldGMuLi4KPiAKSGkgSm9lLAoK SSdsbCBmaXggdGhlIHVzZSBvZiBzeXNmc19lbWl0X2F0IGluIG5leHQgdmVyc2lvbiwgdGhhbmtz LgpCdXQgSSB0aGluayBpdCdzIGJldHRlciB0byBrZWVwIHRoZSByZXMgYXMgc3NpemVfdCwgYXMg dGhlIHJldHVybiB2YWx1ZSAKb2YgdGhpcyBmdW5jdGlvbiBpcyBzc2l6ZV90LgoKVGhhbmtzLAoK UWkKCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBM aW51eGFybSBtYWlsaW5nIGxpc3QgLS0gbGludXhhcm1Ab3BlbmV1bGVyLm9yZwo+IFRvIHVuc3Vi c2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gbGludXhhcm0tbGVhdmVAb3BlbmV1bGVyLm9yZwo+IAoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK