All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Jean Delvare <jdelvare@suse.de>,
	linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Biao Huang" <biao.huang@mediatek.com>,
	"James Liao" <jamesjj.liao@mediatek.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH] pinctrl: mediatek: Use real dependencies
Date: Wed, 25 Jan 2017 11:57:45 +0100	[thread overview]
Message-ID: <a2d129dd-3195-e187-1941-486423939914@gmail.com> (raw)
In-Reply-To: <20170125103209.1d97b0bd@endymion>



On 01/25/2017 10:32 AM, Jean Delvare wrote:
> Do not hide pinctrl drivers for Mediatek platforms using
> conditionals. Doing so actually leaves the symbols present (but
> always disabled) on all other platforms, which is confusing and
> inefficient. Better use real dependencies so that the symbols do not
> exist at all on platforms where they are not relevant.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/pinctrl/mediatek/Kconfig |   15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> --- linux-4.10-rc4.orig/drivers/pinctrl/mediatek/Kconfig	2017-01-01 23:31:53.000000000 +0100
> +++ linux-4.10-rc4/drivers/pinctrl/mediatek/Kconfig	2017-01-25 10:29:00.465436987 +0100
> @@ -10,25 +10,29 @@ config PINCTRL_MTK
>
>  # For ARMv7 SoCs
>  config PINCTRL_MT2701
> -	bool "Mediatek MT2701 pin control" if COMPILE_TEST && !MACH_MT2701
> +	bool "Mediatek MT2701 pin control"
> +	depends on MACH_MT2701 || COMPILE_TEST
>  	depends on OF
>  	default MACH_MT2701
>  	select PINCTRL_MTK
>
>  config PINCTRL_MT7623
> -	bool "Mediatek MT7623 pin control" if COMPILE_TEST && !MACH_MT7623
> +	bool "Mediatek MT7623 pin control"
> +	depends on MACH_MT7623 || COMPILE_TEST
>  	depends on OF
>  	default MACH_MT7623
>  	select PINCTRL_MTK_COMMON
>
>  config PINCTRL_MT8135
> -	bool "Mediatek MT8135 pin control" if COMPILE_TEST && !MACH_MT8135
> +	bool "Mediatek MT8135 pin control"
> +	depends on MACH_MT8135 || COMPILE_TEST
>  	depends on OF
>  	default MACH_MT8135
>  	select PINCTRL_MTK
>
>  config PINCTRL_MT8127
> -	bool "Mediatek MT8127 pin control" if COMPILE_TEST && !MACH_MT8127
> +	bool "Mediatek MT8127 pin control"
> +	depends on MACH_MT8127 || COMPILE_TEST
>  	depends on OF
>  	default MACH_MT8127
>  	select PINCTRL_MTK
> @@ -43,7 +47,8 @@ config PINCTRL_MT8173
>
>  # For PMIC
>  config PINCTRL_MT6397
> -	bool "Mediatek MT6397 pin control" if COMPILE_TEST && !MFD_MT6397
> +	bool "Mediatek MT6397 pin control"
> +	depends on MFD_MT6397 || COMPILE_TEST
>  	depends on OF
>  	default MFD_MT6397
>  	select PINCTRL_MTK
>
>

  parent reply	other threads:[~2017-01-25 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  9:32 [PATCH] pinctrl: mediatek: Use real dependencies Jean Delvare
2017-01-25  9:34 ` John Crispin
2017-01-25 10:57 ` Matthias Brugger [this message]
2017-01-26 15:26 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2d129dd-3195-e187-1941-486423939914@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=afaerber@suse.de \
    --cc=biao.huang@mediatek.com \
    --cc=jamesjj.liao@mediatek.com \
    --cc=jdelvare@suse.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.