From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932869AbdBVOf7 (ORCPT ); Wed, 22 Feb 2017 09:35:59 -0500 Received: from foss.arm.com ([217.140.101.70]:45138 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbdBVOfu (ORCPT ); Wed, 22 Feb 2017 09:35:50 -0500 Subject: Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode To: Geert Uytterhoeven References: <1487622809-25127-1-git-send-email-geert+renesas@glider.be> <1487622809-25127-4-git-send-email-geert+renesas@glider.be> <20170221110712.GB5021@amd> <3caf0f3f-76e5-cb1e-7c0f-87ed5e1c2b86@arm.com> Cc: Sudeep Holla , Pavel Machek , Geert Uytterhoeven , Lorenzo Pieralisi , Mark Rutland , Lina Iyer , John Stultz , Thomas Gleixner , "Rafael J . Wysocki" , Len Brown , Rob Herring , Magnus Damm , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux-Renesas , Linux PM list , "linux-kernel@vger.kernel.org" From: Sudeep Holla Organization: ARM Message-ID: Date: Wed, 22 Feb 2017 14:35:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/17 13:47, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 6:22 PM, Sudeep Holla wrote: [...] >> >> IIUC, it's not implemented today. I can't talk about future ;), but your > > Good, so there's no need for the DT property, and drivers/firmware/psci.c > should aways call do_cpu_idle() instead of PSCI SYSTEM_SUSPEND if any > other wake-up sources are configured? > No. > That follows the principle of least surprise: it doesn't leave the user with > a system that won't wake up the way he configured it to wake up. > But he can still wake up with the "switch" so there's no surprise. He just need to better understand his system before playing with it ;) -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode Date: Wed, 22 Feb 2017 14:35:37 +0000 Message-ID: References: <1487622809-25127-1-git-send-email-geert+renesas@glider.be> <1487622809-25127-4-git-send-email-geert+renesas@glider.be> <20170221110712.GB5021@amd> <3caf0f3f-76e5-cb1e-7c0f-87ed5e1c2b86@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Sudeep Holla , Pavel Machek , Geert Uytterhoeven , Lorenzo Pieralisi , Mark Rutland , Lina Iyer , John Stultz , Thomas Gleixner , "Rafael J . Wysocki" , Len Brown , Rob Herring , Magnus Damm , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux-Renesas , Linux PM list , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 22/02/17 13:47, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 6:22 PM, Sudeep Holla wrote: [...] >> >> IIUC, it's not implemented today. I can't talk about future ;), but your > > Good, so there's no need for the DT property, and drivers/firmware/psci.c > should aways call do_cpu_idle() instead of PSCI SYSTEM_SUSPEND if any > other wake-up sources are configured? > No. > That follows the principle of least surprise: it doesn't leave the user with > a system that won't wake up the way he configured it to wake up. > But he can still wake up with the "switch" so there's no surprise. He just need to better understand his system before playing with it ;) -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Wed, 22 Feb 2017 14:35:37 +0000 Subject: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode In-Reply-To: References: <1487622809-25127-1-git-send-email-geert+renesas@glider.be> <1487622809-25127-4-git-send-email-geert+renesas@glider.be> <20170221110712.GB5021@amd> <3caf0f3f-76e5-cb1e-7c0f-87ed5e1c2b86@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/02/17 13:47, Geert Uytterhoeven wrote: > Hi Sudeep, > > On Tue, Feb 21, 2017 at 6:22 PM, Sudeep Holla wrote: [...] >> >> IIUC, it's not implemented today. I can't talk about future ;), but your > > Good, so there's no need for the DT property, and drivers/firmware/psci.c > should aways call do_cpu_idle() instead of PSCI SYSTEM_SUSPEND if any > other wake-up sources are configured? > No. > That follows the principle of least surprise: it doesn't leave the user with > a system that won't wake up the way he configured it to wake up. > But he can still wake up with the "switch" so there's no surprise. He just need to better understand his system before playing with it ;) -- Regards, Sudeep