From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFAAC433E0 for ; Mon, 1 Jun 2020 11:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE91B206E2 for ; Mon, 1 Jun 2020 11:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbgFALc3 (ORCPT ); Mon, 1 Jun 2020 07:32:29 -0400 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:33308 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgFALc3 (ORCPT ); Mon, 1 Jun 2020 07:32:29 -0400 Received: from [192.168.1.41] ([92.140.207.208]) by mwinf5d35 with ME id lnXo2200Y4WJoZY03nXyvM; Mon, 01 Jun 2020 13:32:27 +0200 X-ME-Helo: [192.168.1.41] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 01 Jun 2020 13:32:27 +0200 X-ME-IP: 92.140.207.208 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken To: Robert Jarzmik Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel.janitors,gmane.linux.ports.arm.kernel,gmane.linux.kernel.gpio,gmane.linux.kernel References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> From: Christophe JAILLET Message-ID: Date: Mon, 1 Jun 2020 13:31:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <87h7vvb1s3.fsf@belgarion.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > Christophe JAILLET writes: > >> Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") >> has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in >> 'pxa2xx_pinctrl_init()'. >> However, the corresponding 'pinctrl_unregister()' call in >> 'pxa2xx_pinctrl_exit()' has not been removed. >> >> This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. >> Remove it now to avoid some wondering in the future and save a few LoC. >> >> Signed-off-by: Christophe JAILLET > Acked-by: Robert Jarzmik > > Would be even a better patch with a : > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") I was wondering it was was needed in this case. The patch does not really fix anything, as the function is unused. Or it fixes things on a theoretical point of view. CJ > Cheers. > > -- > Robert > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe JAILLET Date: Mon, 01 Jun 2020 11:31:23 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> In-Reply-To: <87h7vvb1s3.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Robert Jarzmik Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, linux-gpio@vger.kernel.org, daniel@zonque.org, linux-arm-kernel@lists.infradead.org Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > Christophe JAILLET writes: > >> Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") >> has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in >> 'pxa2xx_pinctrl_init()'. >> However, the corresponding 'pinctrl_unregister()' call in >> 'pxa2xx_pinctrl_exit()' has not been removed. >> >> This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. >> Remove it now to avoid some wondering in the future and save a few LoC. >> >> Signed-off-by: Christophe JAILLET > Acked-by: Robert Jarzmik > > Would be even a better patch with a : > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") I was wondering it was was needed in this case. The patch does not really fix anything, as the function is unused. Or it fixes things on a theoretical point of view. CJ > Cheers. > > -- > Robert > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13BB6C433E0 for ; Mon, 1 Jun 2020 11:32:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEEEC206E2 for ; Mon, 1 Jun 2020 11:32:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uv6c5jFb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEEEC206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bFio66K+IWNp2SWMuOAYf0fY7ZPGuStWkLOWn66Durg=; b=uv6c5jFbYXBSJZBtjyJjluu5p ElDS6N8+IEOFGFINcMQsK5Q4LJ6Qn1VpiWJPBTJ+GC7OVoYTbpCo19hz6hD1I3OKxhON68gc6LoNy TVS2zPKIC1mB0pXRwn4H3MiP8lj4LkJoCf4zpaqWxIS0T7023jHiwWvKF1XGLjL5btU56IPEyYXP9 tYOZpfUdNP4bR4cFHg+S7lQJiomvGPlPnN/gtWsh+GFsEzF66jZwtkATBBGFzTMyElmkr//Q2kTvZ HOv8vlm3H2CG23aBTcvBZt9oGcyT8VkHAf2fbS6xv7beorLY4ECVd2DcfOvSvlqN8NSX1JBZo+ULy yELcQIKjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfigF-0002S5-HW; Mon, 01 Jun 2020 11:32:35 +0000 Received: from smtp12.smtpout.orange.fr ([80.12.242.134] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfigC-0002RB-Nj for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 11:32:34 +0000 Received: from [192.168.1.41] ([92.140.207.208]) by mwinf5d35 with ME id lnXo2200Y4WJoZY03nXyvM; Mon, 01 Jun 2020 13:32:27 +0200 X-ME-Helo: [192.168.1.41] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 01 Jun 2020 13:32:27 +0200 X-ME-IP: 92.140.207.208 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken To: Robert Jarzmik Newsgroups: gmane.linux.kernel.janitors, gmane.linux.ports.arm.kernel, gmane.linux.kernel.gpio, gmane.linux.kernel References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> From: Christophe JAILLET Message-ID: Date: Mon, 1 Jun 2020 13:31:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <87h7vvb1s3.fsf@belgarion.home> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_043233_054467_4C7E4062 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, linux-gpio@vger.kernel.org, daniel@zonque.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMDEvMDYvMjAyMCDDoCAxMDo1OCwgUm9iZXJ0IEphcnptaWsgYSDDqWNyaXTCoDoKPiBDaHJp c3RvcGhlIEpBSUxMRVQgPGNocmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPiB3cml0ZXM6Cj4K Pj4gQ29tbWl0IDZkMzNlZTdhMDUzNCAoInBpbmN0cmw6IHB4YTogVXNlIGRldm1fcGluY3RybF9y ZWdpc3RlcigpIGZvciBwaW5jdHJsIHJlZ2lzdHJhdGlvbiIpCj4+IGhhcyB0dXJuZWQgYSAncGlu Y3RybF9yZWdpc3RlcigpJyBpbnRvICdkZXZtX3BpbmN0cmxfcmVnaXN0ZXIoKScgaW4KPj4gJ3B4 YTJ4eF9waW5jdHJsX2luaXQoKScuCj4+IEhvd2V2ZXIsIHRoZSBjb3JyZXNwb25kaW5nICdwaW5j dHJsX3VucmVnaXN0ZXIoKScgY2FsbCBpbgo+PiAncHhhMnh4X3BpbmN0cmxfZXhpdCgpJyBoYXMg bm90IGJlZW4gcmVtb3ZlZC4KPj4KPj4gVGhpcyBpcyBub3QgYW4gaXNzdWUsIGJlY2F1c2UgJ3B4 YTJ4eF9waW5jdHJsX2V4aXQoKScgaXMgdW51c2VkLgo+PiBSZW1vdmUgaXQgbm93IHRvIGF2b2lk IHNvbWUgd29uZGVyaW5nIGluIHRoZSBmdXR1cmUgYW5kIHNhdmUgYSBmZXcgTG9DLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEpBSUxMRVQgPGNocmlzdG9waGUuamFpbGxldEB3YW5h ZG9vLmZyPgo+IEFja2VkLWJ5OiBSb2JlcnQgSmFyem1payA8cm9iZXJ0LmphcnptaWtAZnJlZS5m cj4KPgo+IFdvdWxkIGJlIGV2ZW4gYSBiZXR0ZXIgcGF0Y2ggd2l0aCBhIDoKPiBGaXhlczogNmQz M2VlN2EwNTM0ICgicGluY3RybDogcHhhOiBVc2UgZGV2bV9waW5jdHJsX3JlZ2lzdGVyKCkgZm9y IHBpbmN0cmwgcmVnaXN0cmF0aW9uIikKCkkgd2FzIHdvbmRlcmluZyBpdCB3YXMgd2FzIG5lZWRl ZCBpbiB0aGlzIGNhc2UuClRoZSBwYXRjaCBkb2VzIG5vdCByZWFsbHkgZml4IGFueXRoaW5nLCBh cyB0aGUgZnVuY3Rpb24gaXMgdW51c2VkLiBPciBpdCAKZml4ZXMgdGhpbmdzIG9uIGEgdGhlb3Jl dGljYWwgcG9pbnQgb2Ygdmlldy4KCkNKCgoKPiBDaGVlcnMuCj4KPiAtLQo+IFJvYmVydAo+CgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=