From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750991AbeFAJP6 (ORCPT ); Fri, 1 Jun 2018 05:15:58 -0400 Received: from mo4-p05-ob.smtp.rzone.de ([85.215.255.134]:9548 "EHLO mo4-p05-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbeFAJPy (ORCPT ); Fri, 1 Jun 2018 05:15:54 -0400 X-RZG-AUTH: ":LX8JdEmkW/4tAFwMkcNJIloh1hrA5u3owhPk7bdT5Fx2zAOrX/r2ZbrrxoyOl37jyAS87PDYc9ZbLQuBYnGyPFydOVsjnssucaVzia+6/AK6" X-RZG-CLASS-ID: mo05 Subject: Re: [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller To: Yogesh Narayan Gaur Cc: Boris Brezillon , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "miquel.raynal@bootlin.com" , "broonie@kernel.org" , David Wolfe , Fabio Estevam , Prabhakar Kushwaha , Han Xu , "linux-kernel@vger.kernel.org" References: <1527686082-15142-1-git-send-email-frieder.schrempf@exceet.de> <1527686082-15142-4-git-send-email-frieder.schrempf@exceet.de> <20180530162439.7b5eec2b@bbrezillon> From: Frieder Schrempf Message-ID: Date: Fri, 1 Jun 2018 11:14:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180530162439.7b5eec2b@bbrezillon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yogesh, On 30.05.2018 16:24, Boris Brezillon wrote: > Hi Yogesh, > > On Wed, 30 May 2018 13:50:51 +0000 > Yogesh Narayan Gaur wrote: > >> Hi Frieder, >> >> Thanks for migrating the fsl-quadspi.c driver on the new SPI >> framework. This patch is using dynamic LUT approach to create the LUT >> at run time instead of fixed static LUT as being used in current >> driver present at mtd/spi-nor/fsl-quadspi.c. I have pushed the >> changes for dynamic LUT on mtd/spi-nor/fsl-quadspi.c and v10 has been >> in review stage. >> >> Request you to please add 'signed-off' mentioned in those patches in >> this patch, patchwork link is >> https://patchwork.ozlabs.org/patch/896534/ So for reasons already given by Boris, I won't add your S-o-b tags. But I can add your name (and that of Suresh Gupta?) to the file header and as MODULE_AUTHOR in the next version. Regards, Frieder > > First, I'd like to state that this work has not been based on your > dynamic LUT code, and I actually asked you to adapt your code to match > the way we were handling it in the new driver (which at that time was > still under development). Then, even if you want to be cited as one of > the author of the new code, SoB tag is not the right way to do it (see > [1] for an explanation on when SoB should be added). Instead, you > should add your name in the copyright header and maybe be add a > MODULE_AUTHOR(): > > /* > * Copyright ... > * ... > * Authors: > * ... > * Yogesh Narayan Gaur > */ > > ... > > MODULE_AUTHOR("Yogesh Narayan Gaur "); > > Regards, > > Boris > > [1]https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L429 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frieder Schrempf Subject: Re: [PATCH 03/11] spi: Add a driver for the Freescale/NXP QuadSPI controller Date: Fri, 1 Jun 2018 11:14:52 +0200 Message-ID: References: <1527686082-15142-1-git-send-email-frieder.schrempf@exceet.de> <1527686082-15142-4-git-send-email-frieder.schrempf@exceet.de> <20180530162439.7b5eec2b@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: Boris Brezillon , "richard@nod.at" , Prabhakar Kushwaha , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "marek.vasut@gmail.com" , Han Xu , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "miquel.raynal@bootlin.com" , Fabio Estevam , David Wolfe , "computersforpeace@gmail.com" , "dwmw2@infradead.org" To: Yogesh Narayan Gaur Return-path: In-Reply-To: <20180530162439.7b5eec2b@bbrezillon> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org Hi Yogesh, On 30.05.2018 16:24, Boris Brezillon wrote: > Hi Yogesh, > > On Wed, 30 May 2018 13:50:51 +0000 > Yogesh Narayan Gaur wrote: > >> Hi Frieder, >> >> Thanks for migrating the fsl-quadspi.c driver on the new SPI >> framework. This patch is using dynamic LUT approach to create the LUT >> at run time instead of fixed static LUT as being used in current >> driver present at mtd/spi-nor/fsl-quadspi.c. I have pushed the >> changes for dynamic LUT on mtd/spi-nor/fsl-quadspi.c and v10 has been >> in review stage. >> >> Request you to please add 'signed-off' mentioned in those patches in >> this patch, patchwork link is >> https://patchwork.ozlabs.org/patch/896534/ So for reasons already given by Boris, I won't add your S-o-b tags. But I can add your name (and that of Suresh Gupta?) to the file header and as MODULE_AUTHOR in the next version. Regards, Frieder > > First, I'd like to state that this work has not been based on your > dynamic LUT code, and I actually asked you to adapt your code to match > the way we were handling it in the new driver (which at that time was > still under development). Then, even if you want to be cited as one of > the author of the new code, SoB tag is not the right way to do it (see > [1] for an explanation on when SoB should be added). Instead, you > should add your name in the copyright header and maybe be add a > MODULE_AUTHOR(): > > /* > * Copyright ... > * ... > * Authors: > * ... > * Yogesh Narayan Gaur > */ > > ... > > MODULE_AUTHOR("Yogesh Narayan Gaur "); > > Regards, > > Boris > > [1]https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L429 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/