From: Thranur Andul <thranur@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Noah Pendleton <noah.pendleton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] blame: Skip missing ignore-revs file
Date: Fri, 4 Mar 2022 10:51:43 +0100 [thread overview]
Message-ID: <a30ebbe3-596e-84a5-9023-b53402dfe70c@gmail.com> (raw)
In-Reply-To: <xmqqr1f5hszw.fsf@gitster.g>
On 07/08/2021 22:58, Junio C Hamano wrote:
> Noah Pendleton <noah.pendleton@gmail.com> writes:
>
>
> That cuts both ways, though. Failing upon missing configuration
> file is a way to catch misconfiguration that is hard to diagnose.
>
> I wonder if we can easily learn where the configuration variable
> came from in the codepath that diagnoses it as a misconfiguration.
>
> If it came from a per-repo configuration and names a non-existent
> file, it clearly is a misconfiguration that we want to flag as an
> error. Even if it came from a per-user configuration, if it was
> specified in a conditionally included file, it is likely to be a
> misconfiguration. If it came from a per-user configuration that
> applies without any condition, it can be a good convenience feature
> to silently (or with a warning) ignore missing file.
>
I am very interested in this feature, but I'd like to add another point
to the discussion: in the case of ignoreRevsFile in particular, no one
creates a repository with such a file; it is always added later.
However, when bisecting (a typical usage scenario for git-blame), we may
end up returning back to a point _before_ the file had been added, and
then, git-blame fails. This often happens to me, and I am then forced to
`touch` the file to create it again, only to ensure git-blame keeps
working. And then, when I want to return to the HEAD commit, the file
must be erased again otherwise there is a conflict. So, for me, the
"ignore if absent" behavior seems to me like it should be the default.
next prev parent reply other threads:[~2022-03-04 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 20:27 [PATCH 0/1] blame: Skip missing ignore-revs file Noah Pendleton
2021-08-07 20:58 ` Junio C Hamano
2021-08-07 21:34 ` Noah Pendleton
2021-08-08 5:43 ` Junio C Hamano
2021-08-08 17:50 ` Junio C Hamano
2021-08-08 18:21 ` Noah Pendleton
2021-08-09 15:47 ` Junio C Hamano
2022-03-04 9:51 ` Thranur Andul [this message]
2021-08-08 17:48 ` [PATCH v2] blame: add config `blame.ignoreRevsFileIsOptional` Noah Pendleton
2021-08-07 20:29 [PATCH 0/1] blame: Skip missing ignore-revs file Noah Pendleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30ebbe3-596e-84a5-9023-b53402dfe70c@gmail.com \
--to=thranur@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=noah.pendleton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.