From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27A3C3A5A5 for ; Thu, 5 Sep 2019 10:50:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC350206BB for ; Thu, 5 Sep 2019 10:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC350206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5pLd-0003be-Pg for qemu-devel@archiver.kernel.org; Thu, 05 Sep 2019 06:50:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39522) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5pK4-0002Et-TA for qemu-devel@nongnu.org; Thu, 05 Sep 2019 06:49:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5pK3-0004qq-UD for qemu-devel@nongnu.org; Thu, 05 Sep 2019 06:49:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i5pK3-0004qF-Md for qemu-devel@nongnu.org; Thu, 05 Sep 2019 06:49:03 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE645C04BD33 for ; Thu, 5 Sep 2019 10:49:02 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id s5so794410wrv.23 for ; Thu, 05 Sep 2019 03:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6pM+3eZHIWqCoFeesnYPtsSMBI5mAk9ZSdVAV3cN4oo=; b=Snr/YsXtbr1IsqZh1dVGi+MEhc56Av43vx2iPqSapyhljHgt05jclPsmjk4gDrM9/g oqscFl/lkqFxPAR2gZSp1fVD7UIF7ZbC5jVc4FzDbYWPb4WWOTAMGS3Im9bmDtTZiEub DvegUZNBE+WARCHFtJz6WVmiqyfmT2vucQpc9vY1sgKFjdr9hKXzb6InWcIh5WvAv0Xv kkgomtIOtmH6qhlSyr16yf52pbh7btGswBmwL43GIAVoNuMbVFpQUyJ1VgdpSc6l7ugM Ez920h6bODT35wSddf65/t+9zwzGvlGDxuyVHvZ7trLWbCS6xNazdrnag818nCUvgTg5 j9lQ== X-Gm-Message-State: APjAAAUMQg2QWRhMApq/1j/erynrjJmpi9PYt+bVNiSjmwbcco3hHUzF Dd3c5Td78BfzQpVZVOQvFnqOTwT7cHcSgjLWWOBgCrrGY5Jo3gnQDyHQUNokt0l6UppNOb00JNc ZXIYiN+lAawNNmmI= X-Received: by 2002:a5d:4247:: with SMTP id s7mr2068491wrr.110.1567680541504; Thu, 05 Sep 2019 03:49:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRzzsC5EJl1Ar7U9XANcmrg/ANDHtDlxzDVynOu/r9b8qLXnQalhByV6mKLzcOyzT5fAanFw== X-Received: by 2002:a5d:4247:: with SMTP id s7mr2068479wrr.110.1567680541349; Thu, 05 Sep 2019 03:49:01 -0700 (PDT) Received: from [192.168.1.48] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id o129sm3047459wmb.41.2019.09.05.03.49.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2019 03:49:00 -0700 (PDT) To: Richard Henderson , qemu-devel@nongnu.org References: <20190904193059.26202-1-richard.henderson@linaro.org> <20190904193059.26202-60-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 5 Sep 2019 12:49:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190904193059.26202-60-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v4 59/69] target/arm: Convert T16, nop hints X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/4/19 9:30 PM, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 3 +-- > target/arm/t16.decode | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) >=20 > diff --git a/target/arm/translate.c b/target/arm/translate.c > index b70491d39e..69092c12c3 100644 > --- a/target/arm/translate.c > +++ b/target/arm/translate.c > @@ -10891,8 +10891,7 @@ static void disas_thumb_insn(DisasContext *s, u= int32_t insn) > =20 > case 15: /* IT, nop-hint. */ > if ((insn & 0xf) =3D=3D 0) { > - gen_nop_hint(s, (insn >> 4) & 0xf); > - break; > + goto illegal_op; /* nop hint, in decodetree */ > } > /* > * IT (If-Then) > diff --git a/target/arm/t16.decode b/target/arm/t16.decode > index 19a442b894..5829b9a58c 100644 > --- a/target/arm/t16.decode > +++ b/target/arm/t16.decode > @@ -19,6 +19,7 @@ > # This file is processed by scripts/decodetree.py > # > =20 > +&empty !extern > &s_rrr_shi !extern s rd rn rm shim shty > &s_rrr_shr !extern s rn rd rm rs shty > &s_rri_rot !extern s rn rd imm rot > @@ -204,3 +205,19 @@ SETEND 1011 0110 010 1 E:1 000 &s= etend > REV 1011 1010 00 ... ... @rdm > REV16 1011 1010 01 ... ... @rdm > REVSH 1011 1010 11 ... ... @rdm > + > +# Hints > + > +{ > + YIELD 1011 1111 0001 0000 > + WFE 1011 1111 0010 0000 > + WFI 1011 1111 0011 0000 > + > + # TODO: Implement SEV, SEVL; may help SMP performance. > + # SEV 1011 1111 0100 0000 > + # SEVL 1011 1111 0101 0000 > + > + # The canonical nop has the second nibble as 0000, but the whole of = the > + # rest of the space is a reserved hint, behaves as nop. > + NOP 1011 1111 ---- 0000 > +} >=20 Reviewed-by: Philippe Mathieu-Daud=C3=A9