From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FD0C433FE for ; Fri, 5 Nov 2021 15:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F5A861245 for ; Fri, 5 Nov 2021 15:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233592AbhKEPta (ORCPT ); Fri, 5 Nov 2021 11:49:30 -0400 Received: from www62.your-server.de ([213.133.104.62]:55634 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233549AbhKEPt2 (ORCPT ); Fri, 5 Nov 2021 11:49:28 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mj1QT-0008ua-Ri; Fri, 05 Nov 2021 16:46:45 +0100 Received: from [85.1.206.226] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj1QT-000TP1-JG; Fri, 05 Nov 2021 16:46:45 +0100 Subject: Re: [PATCH bpf 0/4] Fix some issues for selftest test_xdp_redirect_multi.sh To: Hangbin Liu , netdev@vger.kernel.org Cc: bpf@vger.kernel.org, Alexei Starovoitov , Jesper Dangaard Brouer , linux-kselftest@vger.kernel.org, "David S . Miller" , Jiri Benc References: <20211027033553.962413-1-liuhangbin@gmail.com> From: Daniel Borkmann Message-ID: Date: Fri, 5 Nov 2021 16:46:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20211027033553.962413-1-liuhangbin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.3/26344/Fri Nov 5 09:18:44 2021) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 10/27/21 5:35 AM, Hangbin Liu wrote: > Jiri reported some issues in test_xdp_redirect_multi.sh. Like > the test logs not cleaned after testing. The tcpdump not terminated cleanly. > arp number count may have false positive. And the most important, after > creating/deleting a lot interfaces, the interface index may exceed the > DEVMAP max entry and cause program xdp_redirect_multi exec failed. > > This patch set fix all these issues. > > Hangbin Liu (4): > selftests/bpf/xdp_redirect_multi: put the logs to tmp folder > selftests/bpf/xdp_redirect_multi: use arping to accurate the arp > number > selftests/bpf/xdp_redirect_multi: give tcpdump a chance to terminate > cleanly > selftests/bpf/xdp_redirect_multi: limit the tests in netns > > .../selftests/bpf/test_xdp_redirect_multi.sh | 62 +++++++++++-------- > .../selftests/bpf/xdp_redirect_multi.c | 4 +- > 2 files changed, 37 insertions(+), 29 deletions(-) Applied, thanks, been fixing up a small merge conflict in the last one due to 8fffa0e3451ab ("selftests/bpf: Normalize XDP section names in selftests"), pls double check.